From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C5F3C761A6 for ; Fri, 31 Mar 2023 14:16:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CE14385FA1; Fri, 31 Mar 2023 16:16:00 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="eLGeq713"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E33D85F9B; Fri, 31 Mar 2023 16:15:35 +0200 (CEST) Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8123485F9D for ; Fri, 31 Mar 2023 16:15:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2c.google.com with SMTP id f188so9089240ybb.3 for ; Fri, 31 Mar 2023 07:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680272116; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=OhbdKQdrEywX6vbXyyu3oPh/kxpc6GaVFUcfKz1y4DA=; b=eLGeq713A+ZIewTW1w4P5YTJwE68aOFZAdl8l/8xHzCiIemYTxufg8+sLP8D4Q0OT5 jYgEEslGbPaVl7byaqcC/o77oLP+KMbyFRapV+c8Vuv1vKYE6IT1GY6ODQ537eqUVnUM mggnRyDRHFRO0qFjIe7DC96qd1bXEJenrjmPE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680272116; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OhbdKQdrEywX6vbXyyu3oPh/kxpc6GaVFUcfKz1y4DA=; b=6QpslP8hhDoMLRlJ9oU+k1RHTPsNs7NCEc6bFRn2pcbSrx/DlEYKeVN2JMEw0nLaSS 9QQUzx4+VjwO64TCnrlQqUPf3hMokKqz3WvoRDD9Oi65xH4Bd6tmcN6PTSJrHPK1Aydx RX1jaaFy78StSCNNt998DwQgKq3fgymOMtFulEISYUd8kFsgTX51m1Y+kxCYyG1F7kNH wZ7mzMB6hGCDDcR9PHqsvvug4mNVCqqOf6eT/ZTOnB4HfHwwmMeA2HIoDx3xkNMuyIl0 gYyeWxeKjWU2c8KJZCwFpgStE+MhK/ag67IfLxwdnMxw6qyTfDerwtheagjUy/l+AEN1 z60w== X-Gm-Message-State: AAQBX9erLzclOiAFoZdeVAPINsJkZBcmPsAtqHLwfB3GoIAO6dvtcEnJ jMBNAsVkzA75sLakoPr6SPu40g== X-Google-Smtp-Source: AKy350Zxs4ZCif+vPpCA3EgdBU2j62UWRGRAAIV1wGo3D/z1VjT900/yvVCdqKBHDmKQwSfSja4ylw== X-Received: by 2002:a25:3493:0:b0:b61:c6bf:a9f8 with SMTP id b141-20020a253493000000b00b61c6bfa9f8mr8185945yba.24.1680272116221; Fri, 31 Mar 2023 07:15:16 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-1500-2834-9def-41f1.res6.spectrum.com. [2603:6081:7b00:6400:1500:2834:9def:41f1]) by smtp.gmail.com with ESMTPSA id x12-20020a25ac8c000000b00b784b00772esm579111ybi.50.2023.03.31.07.15.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 07:15:15 -0700 (PDT) Date: Fri, 31 Mar 2023 10:15:13 -0400 From: Tom Rini To: Evgeny Bachinin Cc: Simon Glass , Hector Palacios , Marek Vasut , Heinrich Schuchardt , John Keeping , u-boot@lists.denx.de, kernel@sberdevices.ru, evgen89bachinin@gmail.com Subject: Re: [PATCH v2 1/4] cli: run_commandf(): small fixups Message-ID: <20230331141513.GD13222@bill-the-cat> References: <20230320082314.2018-1-EABachinin@sberdevices.ru> <20230320082314.2018-2-EABachinin@sberdevices.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Fk9o2422aA7JPY3K" Content-Disposition: inline In-Reply-To: <20230320082314.2018-2-EABachinin@sberdevices.ru> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --Fk9o2422aA7JPY3K Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 20, 2023 at 11:23:11AM +0300, Evgeny Bachinin wrote: > * vsnprintf() can truncate cmd, hence it makes no sense to launch such > command (it's broken). Moreover, it's better to signalize to the caller > about such case (for facilitating debugging or bug hunting). >=20 > * Fix kernel-doc warnings: > include/command.h:264: info: Scanning doc for run_commandf > include/command.h:268: warning: contents before sections > include/command.h:271: warning: No description found for return value > of 'run_commandf' >=20 > * Add printf-like format attribute to validate at compile-time the format > string against parameters's type. >=20 > * Fix compilation error in case of -Wall, -Werror, -Wextra: > error: variable =E2=80=98i=E2=80=99 set but not used [-Werror=3Dunused-bu= t-set-variable] >=20 > * Drop extra ret variable. >=20 > Signed-off-by: Evgeny Bachinin > Reviewed-by: Simon Glass Applied to u-boot/next, thanks! --=20 Tom --Fk9o2422aA7JPY3K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQm6vEACgkQFHw5/5Y0 tyyaCAv7B5/QdA1d7cM2TzCHgbLyfHxLEJEi7KOyXreCgmIxXT/2c0c/6/ut49hS 9WIt3xhzV3YoZ6nknYfK24/v9ClBWUikUlxIyDX+t5hwH9a2HnIuAABpqfyIpPv9 aNvlIxMau848pNB4vQveOzslbIeQJmMwhQDyl3ETBgibEPy6Cg1UbasAHG8kepTM kWSeBz4MCGrt6kxYKs0LEw4c0ejGxIqXIcr9LUjzvIJfazQITyiwvNAwtaeLoX9d EMQGf6+cXwxTuuj/Qewy8iBVFWlSsHFv5Z6az4PuhUgARJEInGttVWg/eIk7yCbo 23+lWo4MXYtQWhbtjhVnozI6jZKf2sBDvtq92VQQbVl7389osDSLabvpT0eO/9He pspdnE/45tTmITlv2qkFJ2+tsdXNFGeLlmseIS7qioyMDs/oGFAoo1pCUnNsayz0 Yk7G9RKYdhCYMSoM2XWsL6PUNWf63AeXYZcW3lzjzOaOEW6AtdGJgdGT2BLS/FFr 2Nfi7jkP =W2V0 -----END PGP SIGNATURE----- --Fk9o2422aA7JPY3K--