From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9376DC76196 for ; Fri, 31 Mar 2023 17:04:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BF01C85F46; Fri, 31 Mar 2023 19:04:26 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="POgeTu4G"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8BDCA85F52; Fri, 31 Mar 2023 19:04:24 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3B4CD85F17 for ; Fri, 31 Mar 2023 19:04:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=nm@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 32VH4Gtu028977; Fri, 31 Mar 2023 12:04:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1680282256; bh=fpwS0wYZb/qo1dyLhXuExVdySkfXZdilqv3E5VCQgq0=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=POgeTu4GzTQ6gPCJ0CJwpbKTbw7rAogMUiXYqOMY7S0xNgEfWUltZrksg8dJCdGmz 8zyfzanP/9LTsQtQ97rqW9Gdn9ux2erJ9EAre8pVYcecap1MxOSdZEo58nyT5TMuJM YVVtPkqhGhQh3j0Kqbd1n/r/8Dfjz82HUbqGITQ8= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 32VH4GQd017954 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 31 Mar 2023 12:04:16 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 31 Mar 2023 12:04:16 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 31 Mar 2023 12:04:16 -0500 Received: from localhost (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 32VH4G0Q008104; Fri, 31 Mar 2023 12:04:16 -0500 Date: Fri, 31 Mar 2023 12:04:16 -0500 From: Nishanth Menon To: Ryan Eatmon CC: Praneeth Bajjuri , Tom Rini , Andrew Davis , Bryan Brattlof , Subject: Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core Message-ID: <20230331170416.djwalg37btxdaomm@stunned> References: <20230330210613.17984-1-reatmon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230330210613.17984-1-reatmon@ti.com> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 16:06-20230330, Ryan Eatmon wrote: > The oe-core class for assembling the fitImage includes the vendor > sub-directory (with the / changed to _) in the config sections of > the fitImage. Our env var settings for chosing which section to > boot from needs to be updated to agree with the fitImage. > > Signed-off-by: Ryan Eatmon > --- > include/configs/am64x_evm.h | 4 ++-- > include/configs/am65x_evm.h | 2 +- > include/configs/j721e_evm.h | 6 +++--- > include/configs/j721s2_evm.h | 6 +++--- > 4 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/include/configs/am64x_evm.h b/include/configs/am64x_evm.h > index 26a7f2521e..456a44730c 100644 > --- a/include/configs/am64x_evm.h > +++ b/include/configs/am64x_evm.h > @@ -26,9 +26,9 @@ > #define EXTRA_ENV_AM642_BOARD_SETTINGS \ > "findfdt=" \ > "if test $board_name = am64x_gpevm; then " \ > - "setenv fdtfile k3-am642-evm.dtb; fi; " \ > + "setenv fdtfile ti_k3-am642-evm.dtb; fi; " \ > "if test $board_name = am64x_skevm; then " \ > - "setenv fdtfile k3-am642-sk.dtb; fi;" \ > + "setenv fdtfile ti_k3-am642-sk.dtb; fi;" \ Kernel.org builds k3-am642-sk.dtb Why would we want to go and fix it with non-standard? > "if test $fdtfile = undefined; then " \ > "echo WARNING: Could not determine device tree to use; fi; \0" \ > "name_kern=Image\0" \ > diff --git a/include/configs/am65x_evm.h b/include/configs/am65x_evm.h > index 33dd6cfdfa..60a7eb1453 100644 > --- a/include/configs/am65x_evm.h > +++ b/include/configs/am65x_evm.h > @@ -24,7 +24,7 @@ > /* U-Boot general configuration */ > #define EXTRA_ENV_AM65X_BOARD_SETTINGS \ > "findfdt=" \ > - "setenv name_fdt k3-am654-base-board.dtb;" \ > + "setenv name_fdt ti_k3-am654-base-board.dtb;" \ > "setenv fdtfile ${name_fdt}\0" \ > "name_kern=Image\0" \ > "console=ttyS2,115200n8\0" \ > diff --git a/include/configs/j721e_evm.h b/include/configs/j721e_evm.h > index 48b1cea6e3..eac5cd5b76 100644 > --- a/include/configs/j721e_evm.h > +++ b/include/configs/j721e_evm.h > @@ -34,11 +34,11 @@ > #define EXTRA_ENV_J721E_BOARD_SETTINGS \ > "default_device_tree=" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0" \ > "findfdt=" \ > - "setenv name_fdt ${default_device_tree};" \ > + "setenv name_fdt ti_${default_device_tree};" \ > "if test $board_name = j721e; then " \ > - "setenv name_fdt k3-j721e-common-proc-board.dtb; fi;" \ > + "setenv name_fdt ti_k3-j721e-common-proc-board.dtb; fi;" \ > "if test $board_name = j721e-eaik || test $board_name = j721e-sk; then " \ > - "setenv name_fdt k3-j721e-sk.dtb; fi;" \ > + "setenv name_fdt ti_k3-j721e-sk.dtb; fi;" \ > "setenv fdtfile ${name_fdt}\0" \ > "name_kern=Image\0" \ > "console=ttyS2,115200n8\0" \ > diff --git a/include/configs/j721s2_evm.h b/include/configs/j721s2_evm.h > index bfada9eebc..b30a4a8da4 100644 > --- a/include/configs/j721s2_evm.h > +++ b/include/configs/j721s2_evm.h > @@ -31,11 +31,11 @@ > #define EXTRA_ENV_J721S2_BOARD_SETTINGS \ > "default_device_tree=" CONFIG_DEFAULT_DEVICE_TREE ".dtb\0" \ > "findfdt=" \ > - "setenv name_fdt ${default_device_tree};" \ > + "setenv name_fdt ti_${default_device_tree};" \ > "if test $board_name = j721s2; then " \ > - "setenv name_fdt k3-j721s2-common-proc-board.dtb; fi;" \ > + "setenv name_fdt ti_k3-j721s2-common-proc-board.dtb; fi;" \ > "if test $board_name = am68-sk; then " \ > - "setenv name_fdt k3-am68-sk-base-board.dtb; fi;"\ > + "setenv name_fdt ti_k3-am68-sk-base-board.dtb; fi;"\ > "setenv fdtfile ${name_fdt}\0" \ > "name_kern=Image\0" \ > "console=ttyS2,115200n8\0" \ > -- > 2.17.1 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D