From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED064C761A6 for ; Fri, 31 Mar 2023 18:11:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E7E3085FAD; Fri, 31 Mar 2023 20:11:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="NweNUV4r"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4175285FB2; Fri, 31 Mar 2023 20:11:19 +0200 (CEST) Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3877985BBB for ; Fri, 31 Mar 2023 20:11:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2b.google.com with SMTP id d3so503367ybu.1 for ; Fri, 31 Mar 2023 11:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680286275; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NxYCRkiVJMSk4Mf4gK6SpmKglgFAsDSFhqAP+CidfIg=; b=NweNUV4r202unZwRAvk41BlcwvUmdL+8Rlaj7mngfE37uhVCIHqMO/VJZ7nyiNaDz4 IQG5IT1QyYW6ErlR36lVzhQKa5HMVy4Zi/xvu4tXxJMDGtgmwl+HUWS1p4zVMZsLWcGf KyR/JfHsmw+qGOQHf+KSdtdfCCw23aNd1pPl8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680286275; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NxYCRkiVJMSk4Mf4gK6SpmKglgFAsDSFhqAP+CidfIg=; b=1rqvYGR0Ei2ueLTJWsuL0jB1W0TnU03V6ZUQ0//BzSHoAkiXu/itTvNMPa4NMB+SFp B6OqcV2J44+EKdKvn4jgd2nqfJ4fs0B0JS8c99K2gyg3mydiBqRHWJKk9V4DtSdQeGQT tlFSouR/TcqzH1Q3bnr9CKoAKc32ZnRGIbxMH4/NUH3mSp0OCZ5iLpkzdth+ur9dQoCl 45Ic2Qw0tdsf26stnWNXaHAMC7n1l9vfyWEsT/N6Eyf7obucDU5hWjO3xHEBFnCtMDET IaG3dH2wMHi0858YqbewCXM5t4uXHp3NnmcvJg8HGCrxBWmy98bdpPSyOBsHbSpQ1Kc8 IeKQ== X-Gm-Message-State: AAQBX9fdG5YFqwBzcrRDaoIE5XvlhREAMlld0HaqFp3OHnLAbF2pNe3n rLO2cPK05mBN5Br3CkiCncqFlpvZe2cA4XCEbid2+Q== X-Google-Smtp-Source: AKy350ZsPX/++B6EnEU4aC0Nu3v2JEiJS9MvTVo52Th8PUo2oSV+pBHNluXxrXI7JquwiAJgiH4ySQ== X-Received: by 2002:a25:a146:0:b0:a6a:3356:6559 with SMTP id z64-20020a25a146000000b00a6a33566559mr26078604ybh.47.1680286274926; Fri, 31 Mar 2023 11:11:14 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-1500-2834-9def-41f1.res6.spectrum.com. [2603:6081:7b00:6400:1500:2834:9def:41f1]) by smtp.gmail.com with ESMTPSA id h7-20020a255f47000000b00b7767ca74a4sm689487ybm.65.2023.03.31.11.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 11:11:14 -0700 (PDT) Date: Fri, 31 Mar 2023 14:11:12 -0400 From: Tom Rini To: Andrew Davis Cc: Nishanth Menon , Ryan Eatmon , Praneeth Bajjuri , Bryan Brattlof , u-boot@lists.denx.de Subject: Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core Message-ID: <20230331181112.GC13222@bill-the-cat> References: <20230330210613.17984-1-reatmon@ti.com> <20230331170416.djwalg37btxdaomm@stunned> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+3s2WZ37bNyr63f/" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --+3s2WZ37bNyr63f/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: > On 3/31/23 12:04 PM, Nishanth Menon wrote: > > On 16:06-20230330, Ryan Eatmon wrote: > > > The oe-core class for assembling the fitImage includes the vendor > > > sub-directory (with the / changed to _) in the config sections of > > > the fitImage. Our env var settings for chosing which section to > > > boot from needs to be updated to agree with the fitImage. > > >=20 > > > Signed-off-by: Ryan Eatmon > > > --- > > > include/configs/am64x_evm.h | 4 ++-- > > > include/configs/am65x_evm.h | 2 +- > > > include/configs/j721e_evm.h | 6 +++--- > > > include/configs/j721s2_evm.h | 6 +++--- > > > 4 files changed, 9 insertions(+), 9 deletions(-) > > >=20 > > > diff --git a/include/configs/am64x_evm.h b/include/configs/am64x_evm.h > > > index 26a7f2521e..456a44730c 100644 > > > --- a/include/configs/am64x_evm.h > > > +++ b/include/configs/am64x_evm.h > > > @@ -26,9 +26,9 @@ > > > #define EXTRA_ENV_AM642_BOARD_SETTINGS \ > > > "findfdt=3D" \ > > > "if test $board_name =3D am64x_gpevm; then " \ > > > - "setenv fdtfile k3-am642-evm.dtb; fi; " \ > > > + "setenv fdtfile ti_k3-am642-evm.dtb; fi; " \ > > > "if test $board_name =3D am64x_skevm; then " \ > > > - "setenv fdtfile k3-am642-sk.dtb; fi;" \ > > > + "setenv fdtfile ti_k3-am642-sk.dtb; fi;" \ > >=20 > >=20 > > Kernel.org builds k3-am642-sk.dtb > >=20 >=20 > Nope, kernel.org build ti/k3-am642-sk.dtb >=20 > > Why would we want to go and fix it with non-standard? > >=20 >=20 > The dtbs need to have their dir prefixed or there could be collisions The key here is we're talking about what's used in FIT images, and not just loaded directly. All of the cases where fdtfile is used on arm64 platforms in tree today use "/" because it's loading a literal. In this case, why again is OE mangling the name, and what are we using it for again here? In other words, why can't it be treated as "/" to match the load a file case? And if it _must_ be mangled, must we still use fdtfile and not something else? --=20 Tom --+3s2WZ37bNyr63f/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQnIkAACgkQFHw5/5Y0 tyy+Swv/ZfghsL0qLK4AkawvktY0Yh17PLkJzu3rNkGn7dpJxpZ0+B/3CZGdmOX5 fRhVbTkKn62kR7v/YVbH8wRPjlVTjlyfdgT5pzRn9oP5XxOTL1JrCmT5elI8kRmn 7Pt9iewFwgtWlICXLfhDo3BOLVWi0qGPVqugqNjqbX09F0h9k/0asXJx3EZuReIr fPiyCLuieT3SMkTs0mDy7Q35hthR5cSHqA1sQFQUZBrA732ywXgo0qrJw94uzgfC yqSPqJee0yCVRjqTvD8lWKsGEBhCf/UBNpIajZDm2ExsoBQpQg4fbK9KtyhoSQtK 0e4t2RsP5OlR/b6eNuSfG6ZG9HXnfeZwiqU0ATia8GmNFuPcbdJzOl9kEbJGKKFB 9u3XUFcUyPPVdWJveVbnV51DKLUZXnx+v4HvAL1b4Yy6urPzVbjj3bpNm/Ke/ArL vgpj1A8ZQlP4ew4Bvk7vA6nejZtCHtH0O1e+QDVx+SovOkvHbN8fBmpQASE2/sxm gclmKfSp =ls1l -----END PGP SIGNATURE----- --+3s2WZ37bNyr63f/--