From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D2C20C761A6 for ; Fri, 31 Mar 2023 18:37:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9EDB585FA5; Fri, 31 Mar 2023 20:36:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fXyrKLIU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 473E885FC1; Fri, 31 Mar 2023 20:36:58 +0200 (CEST) Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7193485F5C for ; Fri, 31 Mar 2023 20:36:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-544f7c176easo431194837b3.9 for ; Fri, 31 Mar 2023 11:36:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680287813; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sz4ogJGv1OV5npawmV5AUhzLi3jKpHXuh9VCX+rY228=; b=fXyrKLIUWCr2xR1M+EYTJxSz9cceXRILO/pTqN7b5cx1OiDUsI4e9i64G7grnOJ8aq f8Tamw9m6y6i3J3a1XyxNBan5lY2lx333IPMhcSW8Oo8Cv3OIPVvMl0yF/nLp4GosMeM rTek9EM7WqVq7B5jxfwRv8jt/NsP+qJTQNrCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680287813; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sz4ogJGv1OV5npawmV5AUhzLi3jKpHXuh9VCX+rY228=; b=jmurdRywNfM9l2wf6GNwNOnuZKtmYmCjRVncyPs5bArKUZAvn3eJcstsOTlrPDpccl oQXbVPPf4xpjm1Lcsi5bOXbcT/Qn2AFpAflT94EHZBl2EEohjhtOg/7HXRSXJtSqtku6 tLhMor70syrmnuVyGYI95DHvEejw+3WDU4QlHH5H2pU3pujzgwRYqDcnXDs44e8wlWpd qcUMobFVbp2qlo3mM7woqgGzu0OFbg16DifJ7008Pw9pir308wRaZaiQM7quryXquqP3 oksVywVx4cpMp1U36Y755edKizaXrnXrOS+4u3cZrPXk8DyucBRTvmk90RjUFRQsDHRC D/xg== X-Gm-Message-State: AAQBX9eAWy7UUF38PpOVxKO+rlMkUht42qxudyRQRwAeQuNGTuOKCOxd 6HI8Ghjy/jzsQ/mWI+35nNhQPg== X-Google-Smtp-Source: AKy350aW2slhWqdhxpfOhB2LWAMe914yB29S4++LAfYFEPPhndXVoojPde4FSNj5nMcC61JAhS/FgA== X-Received: by 2002:a81:c243:0:b0:541:8c9c:9515 with SMTP id t3-20020a81c243000000b005418c9c9515mr22843701ywg.15.1680287813027; Fri, 31 Mar 2023 11:36:53 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-1500-2834-9def-41f1.res6.spectrum.com. [2603:6081:7b00:6400:1500:2834:9def:41f1]) by smtp.gmail.com with ESMTPSA id l133-20020a81258b000000b00545a08184e5sm680313ywl.117.2023.03.31.11.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Mar 2023 11:36:52 -0700 (PDT) Date: Fri, 31 Mar 2023 14:36:50 -0400 From: Tom Rini To: Andrew Davis Cc: Nishanth Menon , Ryan Eatmon , Praneeth Bajjuri , Bryan Brattlof , u-boot@lists.denx.de Subject: Re: [PATCH] include: configs: Change dtb names in fitImage to match oe-core Message-ID: <20230331183650.GD13222@bill-the-cat> References: <20230330210613.17984-1-reatmon@ti.com> <20230331170416.djwalg37btxdaomm@stunned> <20230331181112.GC13222@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RwLV7Kpqa28Pu2VH" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --RwLV7Kpqa28Pu2VH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 31, 2023 at 01:23:23PM -0500, Andrew Davis wrote: > On 3/31/23 1:11 PM, Tom Rini wrote: > > On Fri, Mar 31, 2023 at 12:19:14PM -0500, Andrew Davis wrote: > > > On 3/31/23 12:04 PM, Nishanth Menon wrote: > > > > On 16:06-20230330, Ryan Eatmon wrote: > > > > > The oe-core class for assembling the fitImage includes the vendor > > > > > sub-directory (with the / changed to _) in the config sections of > > > > > the fitImage. Our env var settings for chosing which section to > > > > > boot from needs to be updated to agree with the fitImage. > > > > >=20 > > > > > Signed-off-by: Ryan Eatmon > > > > > --- > > > > > include/configs/am64x_evm.h | 4 ++-- > > > > > include/configs/am65x_evm.h | 2 +- > > > > > include/configs/j721e_evm.h | 6 +++--- > > > > > include/configs/j721s2_evm.h | 6 +++--- > > > > > 4 files changed, 9 insertions(+), 9 deletions(-) > > > > >=20 > > > > > diff --git a/include/configs/am64x_evm.h b/include/configs/am64x_= evm.h > > > > > index 26a7f2521e..456a44730c 100644 > > > > > --- a/include/configs/am64x_evm.h > > > > > +++ b/include/configs/am64x_evm.h > > > > > @@ -26,9 +26,9 @@ > > > > > #define EXTRA_ENV_AM642_BOARD_SETTINGS \ > > > > > "findfdt=3D" \ > > > > > "if test $board_name =3D am64x_gpevm; then " \ > > > > > - "setenv fdtfile k3-am642-evm.dtb; fi; " \ > > > > > + "setenv fdtfile ti_k3-am642-evm.dtb; fi; " \ > > > > > "if test $board_name =3D am64x_skevm; then " \ > > > > > - "setenv fdtfile k3-am642-sk.dtb; fi;" \ > > > > > + "setenv fdtfile ti_k3-am642-sk.dtb; fi;" \ > > > >=20 > > > >=20 > > > > Kernel.org builds k3-am642-sk.dtb > > > >=20 > > >=20 > > > Nope, kernel.org build ti/k3-am642-sk.dtb > > >=20 > > > > Why would we want to go and fix it with non-standard? > > > >=20 > > >=20 > > > The dtbs need to have their dir prefixed or there could be collisions > >=20 > > The key here is we're talking about what's used in FIT images, and not > > just loaded directly. All of the cases where fdtfile is used on arm64 > > platforms in tree today use "/" because it's loading a literal. In this > > case, why again is OE mangling the name, and what are we using it for > > again here? In other words, why can't it be treated as "/" to match the > > load a file case? And if it _must_ be mangled, must we still use fdtfile > > and not something else? > >=20 >=20 > So to match other plats, we should: >=20 > setenv fdtfile ti/k3-am642-sk.dtb >=20 > That way loading works in the non-FIT case (and we just need to stop movi= ng > all the DTBs out of the ti/ to the root dir (which is probably broken on = our > part anyway..)) Yes, this sounds right for the non-FIT case to match other platforms / etc. > Then when we use "fdtfile" in the FIT case, we just mangle ("/"->"_") it > at that point only before use. That work for everyone? Well, what _is_ the FIT case and how does it go exactly? I still want to know why we're mangling things and come up with something that'll work for when someone says "I've got an imx8mm and I'm using a FIT image from OE and this doesn't work!". --=20 Tom --RwLV7Kpqa28Pu2VH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQnKDgACgkQFHw5/5Y0 tyy8xAv+NPxJbx/OrO0D7z7vomO/4fUwotHSceqrflpS5fj/WiW96aqEdlYXeTJ/ +CDai4cJavjR1p0hKBo+1qUs0NapPxezkCnM2xj25ar/TTs/Uu8g7UkQ5tialDBc XJdMZx3jT6+TmIF2/p5M5eP4UAWuMfLKQGNo+F4Jq4MZdv0QSXK58tHGWCZCNBoi zqRbf/fcTUWQ+qi51/kKPbRmeqlwikj7qQoEbTUwlGPi1fIHRzKAXJOZ8Iurwmpr Qgi2D8GoU0cw3b3QdSnnwz/4bjY0bne6WFbKbAqq3OfZ7NXyVGTt0PtmO2vQHS0z jMc6xetirdS50p0KZs7Mw8YUlLp+pqvZpn/KhU7AiwI75OR/aPAMBsCSlz+eiw1x B6zfAb1yCoDzgoyjJCQTAGFtwucVuCg6rBd5323NeLUTLHja/F+2BQYizbYyVf4j d/Dl0r3/kiAFO4c2761UCBYvCH+Kok04HO5a4JNBvUxsLBJtBFyeDg8AwezlAm5M y6MP6TAq =Kh1p -----END PGP SIGNATURE----- --RwLV7Kpqa28Pu2VH--