From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5FBBAC6FD1D for ; Tue, 4 Apr 2023 14:22:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 09D68859E0; Tue, 4 Apr 2023 16:22:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="B7KVB/mH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DD1A18594F; Tue, 4 Apr 2023 16:22:20 +0200 (CEST) Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A31FD859E0 for ; Tue, 4 Apr 2023 16:22:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-5491fa028adso120084047b3.10 for ; Tue, 04 Apr 2023 07:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1680618135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iRNeXbyxz9dFwW8BIPKMFGdn35agTtoGD6WVW0o7xjk=; b=B7KVB/mHL/VDHwO0F3Ka3guKs+HEPZ7aCSOujiueGhJP0mKoJhEUGMtHFKLzIrX4KH 3QyuIYY4cKDbI1FPWrggBHiDt9Kg9bCCybMtQr8Wu9IL7fT6S66DQ1hfVPubv8yxxjJ1 EXXtNfn5fnR6GnXHW5Dy+u0FBH5cjm3/BvPns= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680618135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iRNeXbyxz9dFwW8BIPKMFGdn35agTtoGD6WVW0o7xjk=; b=CJKWLY9FvlDOd086/yN59Br813QrDFwxEj371KuzgURqFPSVzQDOKZwpsVO1SYvYpk +Pny1JcpFbJcnyrp08v3cEIFVuGhooBxhMRWGKBU1HkLbiPZtfKCjt1JsZ09Hx/xaOMq fRY54qbTdkdpD0um8CruO+c0ec7Hb29VlBt0vDwsFbOhNxqiZ1DD8dmMtes1YsGSgirv CztbgKuuRDZ3xsj03rmtBtCmOSbd5nZS5aG245eQF+XnoqW3MdRvJMnlrCQVFFt1v4DQ VupztWYvrlOazIDMaFx7obBA5CUJjSs6wro9Rygof8Qw3FRbFVvEAeBhuAq9vPlOPpYp pBNg== X-Gm-Message-State: AAQBX9d1lZtsFFoGTMyOqQbbOrhRVzJqc5RiX1WERMPCvr6sBvW7NvoI U8kvmWqfbOI0A+DgNypzJ+EKiA== X-Google-Smtp-Source: AKy350bb+uxTTnbYi+h8Wj1D5uYCqhQRU0d1MfJdCRfeYE4Iqi56eFsJbbjSZ8iQDHwKc/nsteypOQ== X-Received: by 2002:a81:6cc1:0:b0:545:62d7:6fab with SMTP id h184-20020a816cc1000000b0054562d76fabmr2568865ywc.21.1680618135116; Tue, 04 Apr 2023 07:22:15 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-95a0-3855-b5d9-960b.res6.spectrum.com. [2603:6081:7b00:6400:95a0:3855:b5d9:960b]) by smtp.gmail.com with ESMTPSA id 84-20020a810757000000b00545a08184cfsm3202050ywh.95.2023.04.04.07.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 07:22:14 -0700 (PDT) Date: Tue, 4 Apr 2023 10:22:12 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Judith Mendez , Andrew Davis , Bryan Brattlof , u-boot@lists.denx.de Subject: Re: [PATCH] doc: ti: Add switch setting for boot modes on AM62 SK Message-ID: <20230404142212.GJ1134230@bill-the-cat> References: <20230331203615.8718-1-jm@ti.com> <0eb24e03-08c2-95b1-f4a8-298c20121810@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZJEgCeNBvyuILvZ0" Content-Disposition: inline In-Reply-To: <0eb24e03-08c2-95b1-f4a8-298c20121810@gmx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --ZJEgCeNBvyuILvZ0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Apr 04, 2023 at 03:59:56PM +0200, Heinrich Schuchardt wrote: > On 3/31/23 22:36, Judith Mendez wrote: > > List some common boot modes and their corresponding switch > > settings for AM62 SK. > >=20 > > Signed-off-by: Judith Mendez > > --- > >=20 > > Changes from v1: Change table format from ascii-art to list-table > >=20 > > doc/board/ti/am62x_sk.rst | 36 ++++++++++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > >=20 > > diff --git a/doc/board/ti/am62x_sk.rst b/doc/board/ti/am62x_sk.rst > > index b1b7d99befb..3d85400b1a1 100644 > > --- a/doc/board/ti/am62x_sk.rst > > +++ b/doc/board/ti/am62x_sk.rst > > @@ -229,3 +229,39 @@ Image formats: > > | | SPL DTB 1...N | | > > | +-------------------+ | > > +-----------------------+ > > + > > +Switch Setting for Boot Mode > > +---------------------------- > > + > > +Boot Mode pins provide means to select the boot mode and options befor= e the > > +device is powered up. After every POR, they are the main source to pop= ulate > > +the Boot Parameter Tables. > > + > > +The following table shows some common boot modes used on AM62 platform= =2E More > > +details can be found in the Technical Reference Manual: > > +https://www.ti.com/lit/pdf/spruiv7 under the `Boot Mode Pins` section. > > + > > +.. list-table:: Boot Modes > > + :widths: 32 32 32 > > + :header-rows: 1 > > + > > + * - Switch Label > > + - SW2: 12345678 > > + - SW3: 12345678 > > + * - SD > > + - 01000000 > > + - 11000010 > > + * - OSPI > > + - 00000000 > > + - 11001110 > > + * - EMMC > > + - 00000000 > > + - 11010010 > > + * - UART > > + - 00000000 > > + - 11011100 > > + * - USB DFU > > + - 00000000 > > + - 11001010 >=20 > Hello Judith, >=20 > ReStructured text allows different flavors of formatting tables. >=20 > The HTML output for the table above is correct but the .rst file is hard > to read in a text-editor. I would prefer: >=20 > *Boot Modes* >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > Switch Label SW2: 12345678 SW3: 12345678 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > SD 01000000 11000010 > OSPI 00000000 11001110 > EMMC 00000000 11010010 > UART 00000000 11011100 > USB DFU 00000000 11001010 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D There's other list-table entires in the docs today. I'm fine either way, but we need to be consistent in the docs, and should update perhaps doc/develop/codingstyle.rst should get a section too on docs? --=20 Tom --ZJEgCeNBvyuILvZ0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmQsMo4ACgkQFHw5/5Y0 tywaIwwAsOfUyuUrgwclQqGuY4szeOAYuVdqPU6L9yoocpT6IRPskBtRzxIxjv1d fmJqJ3VssTRE7w6NJZHtQnJZRS8+XkNNvtx60WAA34jwAWlQjkVeu+6H0ERbMJQG cN8xXji3tYQMzyRo38sxmUVkKBWuT2kudpbOE1P3HPZy03/pK4lE3XgEivqQ6Jk+ ct/Xu0Vv0dOKsLvE9dCOQd8qeQHjzSj6nVE2NUzZyjxP/Ou+ptRwzOhxPoltp4Bj nEM1BCjwhyu3tm4yG4hvwLAxrt+EKGS2QuWEtRy6wQ5Qpgs09E/EE5FqzJIgScAy GDxjwxr6wB/0LdRWS9sNzts7JnQ1ma0VMLD82HdPyuxnSaV1XJnWTTsU9NyfLLML FmXejHx7gjn+TQcmGQTsbuHpFHB2oqZs8SJdAsst8xd7cqb8mK/XAxJ73GluGvtk oDSTIkYsAe3TtYI8F/VTo3jQvRQzQDnGPKGO6AuuwvAoasSJSXxUKmhITNHKC5Vf xxRCuLWe =rgDN -----END PGP SIGNATURE----- --ZJEgCeNBvyuILvZ0--