From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8669C761A6 for ; Tue, 4 Apr 2023 19:25:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BFECF85AEC; Tue, 4 Apr 2023 21:25:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1680636331; bh=uFyVU2YT2V5oU0KGEDNLWNdY60+RAAH1b38sX7gm5Wo=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=y1rkZNM0eXcJkH1SBXAIGcjl3Le5oyStcz/yqYmlsVl1Sp+qfnQhFgtGjY0Rsa8Sk 4zXeMXx1f6w8cPY5fu/XFuXMr/gauwOg3qbi7sv1+s9URr6yDNRTymbhMq3znIbn6X VhNypeDuQTvOOsVWPFwjZNoIIH+NEoJjs9wqrSIrwNIsfhYF1+oank5kKNXcRbjOkq IvSonkubHtm2HUNSMxIvwJCNzO7yklLlITZA1Oj6GV7pcZK2J5VcP2IOVgoF9dXZ5g rIi4Jbyhk9No0mQ+gF+mVg2QG/5AdE89riuc04vkvfLzO71I7bZdrSyFKoE5ZQN7W3 Dz6rmgvdN1mGg== Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 4E5FC85837; Tue, 4 Apr 2023 21:25:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1680636328; bh=uFyVU2YT2V5oU0KGEDNLWNdY60+RAAH1b38sX7gm5Wo=; h=From:To:Cc:Subject:Date:From; b=aDM5A2nQ6XrrB89AYbZZsmwYromED0BdmheYPSgJZsTwO4ixoYpb7/D/ofI7zZd3v BDfcTu6u/0ZJOAF3ueVRbkhIEydIQQPJc9V6tYGxkbsVoaVz96k4g4d4RqN6TAALLq b9sSghGUNLF33razTSU0za4ZYcegMs+YDS4BBZVqXOwGoM1AV1LJeDdXsIWc+zXbIN aOETBTZSvcvOwXWD4Ci3v+y+yVRwRSyBOdjs7qa14DpjSeBiqKwpan4/cwbmTBFU6+ dB+oB2xly4Z6oyl3bZzsQ7EXeD5WXl4dub/Va7Oye0jVcWze8diatBvXgh6yZsk5mm INVC6TbRd/d7Q== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , "NXP i.MX U-Boot Team" , Andrejs Cainikovs , Fabio Estevam , Fedor Ross , Peng Fan , Stefano Babic , Ye Li Subject: [PATCH 1/2] thermal: imx_tmu: Clean up all prints Date: Tue, 4 Apr 2023 21:25:09 +0200 Message-Id: <20230404192510.160819-1-marex@denx.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Use dev_(dev, ...) for all printing and debug logging, since this already includes the device name. Drop device name where duplicate. Signed-off-by: Marek Vasut --- Cc: "NXP i.MX U-Boot Team" Cc: Andrejs Cainikovs Cc: Fabio Estevam Cc: Fedor Ross Cc: Marek Vasut Cc: Peng Fan Cc: Stefano Babic Cc: Ye Li --- drivers/thermal/imx_tmu.c | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/thermal/imx_tmu.c b/drivers/thermal/imx_tmu.c index ca45abbb8e1..8d638797eb7 100644 --- a/drivers/thermal/imx_tmu.c +++ b/drivers/thermal/imx_tmu.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include @@ -185,8 +186,8 @@ int imx_tmu_get_temp(struct udevice *dev, int *temp) return ret; while (cpu_tmp >= pdata->alert) { - printf("CPU Temperature (%dC) has beyond alert (%dC), close to critical (%dC)", cpu_tmp, pdata->alert, pdata->critical); - puts(" waiting...\n"); + dev_info(dev, "CPU Temperature (%dC) has beyond alert (%dC), close to critical (%dC) waiting...\n", + cpu_tmp, pdata->alert, pdata->critical); mdelay(pdata->polling_delay); ret = read_temperature(dev, &cpu_tmp); if (ret) @@ -210,14 +211,14 @@ static int imx_tmu_calibration(struct udevice *dev) struct imx_tmu_plat *pdata = dev_get_plat(dev); ulong drv_data = dev_get_driver_data(dev); - debug("%s\n", __func__); + dev_dbg(dev, "%s\n", __func__); if (drv_data & (FLAGS_VER2 | FLAGS_VER3)) return 0; ret = dev_read_u32_array(dev, "fsl,tmu-range", range, 4); if (ret) { - printf("TMU: missing calibration range, ret = %d.\n", ret); + dev_err(dev, "TMU: missing calibration range, ret = %d.\n", ret); return ret; } @@ -229,7 +230,7 @@ static int imx_tmu_calibration(struct udevice *dev) calibration = dev_read_prop(dev, "fsl,tmu-calibration", &len); if (!calibration || len % 8) { - printf("TMU: invalid calibration data.\n"); + dev_err(dev, "TMU: invalid calibration data.\n"); return -ENODEV; } @@ -252,7 +253,7 @@ static void imx_tmu_init(struct udevice *dev) struct imx_tmu_plat *pdata = dev_get_plat(dev); ulong drv_data = dev_get_driver_data(dev); - debug("%s\n", __func__); + dev_dbg(dev, "%s\n", __func__); if (drv_data & FLAGS_VER3) { /* Disable monitoring */ @@ -287,7 +288,7 @@ static int imx_tmu_enable_msite(struct udevice *dev) ulong drv_data = dev_get_driver_data(dev); u32 reg; - debug("%s\n", __func__); + dev_dbg(dev, "%s\n", __func__); if (!pdata->regs) return -EIO; @@ -346,7 +347,7 @@ static int imx_tmu_bind(struct udevice *dev) const void *prop; int minc, maxc; - debug("%s dev name %s\n", __func__, dev->name); + dev_dbg(dev, "%s\n", __func__); prop = dev_read_prop(dev, "compatible", NULL); if (!prop) @@ -367,8 +368,7 @@ static int imx_tmu_bind(struct udevice *dev) dev->driver_data, offset, NULL); if (ret) - printf("Error binding driver '%s': %d\n", - dev->driver->name, ret); + dev_err(dev, "Error binding driver: %d\n", ret); } return 0; @@ -381,7 +381,7 @@ static int imx_tmu_parse_fdt(struct udevice *dev) ofnode trips_np; int ret; - debug("%s dev name %s\n", __func__, dev->name); + dev_dbg(dev, "%s\n", __func__); if (pdata->zone_node) { pdata->regs = (union tmu_regs *)dev_read_addr_ptr(dev); @@ -409,7 +409,7 @@ static int imx_tmu_parse_fdt(struct udevice *dev) else pdata->id = 0; - debug("args.args_count %d, id %d\n", args.args_count, pdata->id); + dev_dbg(dev, "args.args_count %d, id %d\n", args.args_count, pdata->id); pdata->polling_delay = dev_read_u32_default(dev, "polling-delay", 1000); @@ -428,8 +428,8 @@ static int imx_tmu_parse_fdt(struct udevice *dev) continue; } - debug("id %d polling_delay %d, critical %d, alert %d\n", - pdata->id, pdata->polling_delay, pdata->critical, pdata->alert); + dev_dbg(dev, "id %d polling_delay %d, critical %d, alert %d\n", + pdata->id, pdata->polling_delay, pdata->critical, pdata->alert); return 0; } @@ -441,7 +441,7 @@ static int imx_tmu_probe(struct udevice *dev) ret = imx_tmu_parse_fdt(dev); if (ret) { - printf("Error in parsing TMU FDT %d\n", ret); + dev_err(dev, "Error in parsing TMU FDT %d\n", ret); return ret; } -- 2.39.2