Re: [PATCH 6/6] m68k: upgrading all boards to dm i2c

Heiko Schocher
2023-04-11T08:00:01Z

Hello Angelo,

On 11.04.23 09:40, Angelo Dureghello wrote:
> Hi Helko,
>
> On 11/04/23 6:41 AM, Heiko Schocher wrote:
>> Hello Angelo,
>>
>> On 05.04.23 00:59, Angelo Dureghello wrote:
>>> Upgrading all board configs where i2c is involved to DM i2c.
>>>
>>> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>
>>> ---
>>>   configs/M5208EVBE_defconfig           | 5 +----
>>>   configs/M5235EVB_Flash32_defconfig    | 1 +
>>>   configs/M5235EVB_defconfig            | 1 +
>>>   configs/M5253DEMO_defconfig           | 5 +----
>>>   configs/M5275EVB_defconfig            | 5 +----
>>>   configs/M53017EVB_defconfig           | 6 ++----
>>>   configs/M5329AFEE_defconfig           | 6 ++----
>>>   configs/M5329BFEE_defconfig           | 6 ++----
>>>   configs/M5373EVB_defconfig            | 3 ++-
>>>   configs/astro_mcf5373l_defconfig      | 6 ++----
>>>   configs/eb_cpu5282_defconfig          | 5 ++---
>>>   configs/eb_cpu5282_internal_defconfig | 5 ++---
>>>   configs/stmark2_defconfig             | 4 ++++
>>>   13 files changed, 23 insertions(+), 35 deletions(-)
>>
>> Thanks for this series, I did not find a cover letter Email,
>> so I have here a common question:
>>
>> You rename in patch 1/6
>>
>> CONFIG_SYS_I2C_0 -> CFG_SYS_I2C_0
>>
>> but only add in patch 2/6 for the stmark2 this renamed define,
>> and add DTS nodes for other boards in patch 5/6 and here the
>> defconfig changes... may I oversee something obvious, but do
>> the other boards not also need some CFG_SYS_I2C_0 define?
>>
>
> CFG_SYS_I2C_0 (0 to 5) it's a define to setup pads pinmux to i2c,
> but only for coldfire mcf5441x family that requires this.

Ah!

> m68k/cpu/mcf5445x/cpu_init.c:#ifdef CFG_SYS_I2C_0
>
> Involved board is only stmark2, that is the board
> i am using here for test. I found this define to be set
> because i2c was not working, so i moved in the more proper
> CFG_ namespace.

Fine.

> I cannot test other boards actually, but i don't find any
> similar define/need in their start code, so i am supposing
> other cpu families are not needing it, or using other
> definitions for pinmux.
>
> I would like one day to add pinmux setup from fdt,

Nice to hear!

> but not trivial, linux does not have fdt implementation for
> coldfire, so need to invent it from scratch.

Yes, that would be preferred solution!

So, for me, your series is fine to me, Thanks!

bye,
Heiko
>
>
>> Thanks!
>>
>> bye,
>> Heiko
>
> Thanks,
> Regards,
> angelo