Re: [PATCH 6/6] m68k: upgrading all boards to dm i2c

Heiko Schocher
2023-04-11T04:41:47Z

Hello Angelo,

On 05.04.23 00:59, Angelo Dureghello wrote:
> Upgrading all board configs where i2c is involved to DM i2c.
>
> Signed-off-by: Angelo Dureghello <angelo@kernel-space.org>
> ---
> configs/M5208EVBE_defconfig | 5 +----
> configs/M5235EVB_Flash32_defconfig | 1 +
> configs/M5235EVB_defconfig | 1 +
> configs/M5253DEMO_defconfig | 5 +----
> configs/M5275EVB_defconfig | 5 +----
> configs/M53017EVB_defconfig | 6 ++----
> configs/M5329AFEE_defconfig | 6 ++----
> configs/M5329BFEE_defconfig | 6 ++----
> configs/M5373EVB_defconfig | 3 ++-
> configs/astro_mcf5373l_defconfig | 6 ++----
> configs/eb_cpu5282_defconfig | 5 ++---
> configs/eb_cpu5282_internal_defconfig | 5 ++---
> configs/stmark2_defconfig | 4 ++++
> 13 files changed, 23 insertions(+), 35 deletions(-)

Thanks for this series, I did not find a cover letter Email,
so I have here a common question:

You rename in patch 1/6

CONFIG_SYS_I2C_0 -> CFG_SYS_I2C_0

but only add in patch 2/6 for the stmark2 this renamed define,
and add DTS nodes for other boards in patch 5/6 and here the
defconfig changes... may I oversee something obvious, but do
the other boards not also need some CFG_SYS_I2C_0 define?

Thanks!