Re: [PATCH v2 2/3] net: dhcp6: pxe: Add DHCP/PXE commands for IPv6

Simon Glass
2023-04-19T01:51:34Z

Hi Sean,

On Mon, 10 Apr 2023 at 18:03, Sean Edmond
<seanedmond@linux.microsoft.com> wrote:
>
>
> On 2023-04-07 11:55 a.m., Simon Glass wrote:
> > Hi Sean,
> >
> > On Fri, 7 Apr 2023 at 18:56, <seanedmond@linux.microsoft.com> wrote:
> >> From: Sean Edmond <seanedmond@microsoft.com>
> >>
> >> Adds commands to support DHCP and PXE with IPv6.
> >>
> >> New configs added:
> >> - CMD_DHCP6
> >> - DHCP6_PXE_CLIENTARCH
> >> - DHCP6_PXE_DHCP_OPTION
> >> - DHCP6_ENTERPRISE_ID
> >>
> >> New commands added (when IPv6 is enabled):
> >> - dhcp6
> >> - pxe get -ipv6
> >> - pxe boot -ipv6
> >>
> >> Signed-off-by: Sean Edmond <seanedmond@microsoft.com>
> >> ---
> >> boot/bootmeth_distro.c | 2 +-
> >> boot/bootmeth_pxe.c | 4 +-
> >> boot/pxe_utils.c | 3 +-
> >> cmd/Kconfig | 26 +++++++++++++
> >> cmd/net.c | 23 +++++++++++
> >> cmd/pxe.c | 86 +++++++++++++++++++++++++++++++++++++-----
> >> cmd/sysboot.c | 2 +-
> >> include/pxe_utils.h | 10 ++++-
> >> 8 files changed, 140 insertions(+), 16 deletions(-)
> > With nits below:
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> >
> > [..]
> >
> >> +if CMD_DHCP6
> >> +
> >> +config DHCP6_PXE_CLIENTARCH
> >> + hex
> >> + default 0x16 if ARM64
> >> + default 0x15 if ARM
> >> + default 0xFF
> > Do we need a separate option or could we use BOOTP_PXE_CLIENTARCH ?
> I created a new option because I wanted to change the default to 0xFF
> ("undefined" Processor Architecture Types according to
> https://www.iana.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xml).
> I wanted to do this without changing BOOTP_PXE_CLIENTARCH , and
> potentially disrupting exisiting DHCPv4 implementations.

OK, I see.

Regards,
Simon