From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9595AC6FD1D for ; Fri, 7 Apr 2023 19:58:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B6CFD8619C; Fri, 7 Apr 2023 21:58:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1680897511; bh=MgW2gYL3HxQM/0iGfrCLSvmxE0xGFo9rwyMFrDIXal8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oLysGK8W5lUpc+yuuohQoKt+sdjmI9Po79PcSB95mKaU1FsuboOEOUnS97e6vEN3O 39KnCaWXL2sPonBu/HADvQWnwa6OqVWabt8c8PiZBxNQaPhxyaKarzCC7/EKX9QMpP qIMThdsCGL8STV/aWLlb+zyJugcdBppqoPVshoLSTCVbx5p+8nC5z+J8jbqIrlJGnw Ur/kuk1dn60zG3aia3Ix5Y/Aq260aNmKTVIRtR4Aqq76Es1Du+N+1RIz5uXEwhvrlG T/JpX8pqaKwKrnU/C8SIxn83KbK550MRP6l1qOlgOIVDdIkcAbPmrFO2mmdMWM9BNI rTV77TE/lfaGg== Received: from crub (p508b636f.dip0.t-ipconnect.de [80.139.99.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: agust@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6E49E85FEB; Fri, 7 Apr 2023 21:58:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1680897507; bh=MgW2gYL3HxQM/0iGfrCLSvmxE0xGFo9rwyMFrDIXal8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vmdexR4j2VzEQaMqgVtbj/LXQd4oVh07dU98buIeWutqYmXThGbmjnJJrXRDihr7F qyPBYvgrlGWWlQXCCu+XH2STtjBslb9cNOIEAHZg2uw8HFefIRXi5XV1ayirNOUWRv VNMzxObYtjDelcP348Sa0wh8CrGpUlKa2MfrpTB7Dqr6NKCgbUDnPWrAYgPOJjS/n5 qMVjXSVzICunLMPqPmJLwMVWe1YwvfLFFsvUtrpgHwfgpPgjuXkX2EzHwsDhO4E1dz t+O+Y4A7uBdNRPQMvT3BXF5PfReBqGn8TsyMUmjyuyuSqEzp/u0uBuUt+9Put+cJ6m Qb1jYY6sVePoQ== Date: Fri, 7 Apr 2023 21:58:26 +0200 From: Anatolij Gustschin To: Simon Glass Cc: U-Boot Mailing List , Heinrich Schuchardt , Pali =?UTF-8?B?Um9ow6Fy?= , Stefan Roese Subject: Re: [PATCH] sandbox: video: Fix building without SDL Message-ID: <20230407215826.65e6807b@crub> In-Reply-To: <20230217224547.1647994-1-sjg@chromium.org> References: <20230217224547.1647994-1-sjg@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, 17 Feb 2023 15:45:47 -0700 Simon Glass sjg@chromium.org wrote: > This is currently broken. If SDL is not installed, SANDBOX_SDL becomes > false and build errors are generated, e.g.: > > test/dm/video.c:424: undefined reference to `sandbox_sdl_set_bpp' > > Fix it by making the function return an error in this case. > > Signed-off-by: Simon Glass > --- > > arch/sandbox/include/asm/test.h | 8 ++++++++ > 1 file changed, 8 insertions(+) Applied to u-boot-video/master, thanks! -- Anatolij