From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6C16CC7619A for ; Wed, 12 Apr 2023 12:37:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7042385F66; Wed, 12 Apr 2023 14:37:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="OLorl/N+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5A43B85F77; Wed, 12 Apr 2023 14:37:17 +0200 (CEST) Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9254F85F46 for ; Wed, 12 Apr 2023 14:37:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-6a4124c8328so160681a34.1 for ; Wed, 12 Apr 2023 05:37:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681303032; x=1683895032; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XlPGOEtsm4yXWy2CRwfyz8yJm7chpphnSboTfMHJA74=; b=OLorl/N+9jp6RSU5Gg7aguqWbvrqrQZTED7sduhRg92DvcROPep2J69VvAGVY6r6Fh 5Il9WU8bN7F610S2urdQ3fXL5RBvoKHy2mY45yCMfMSqRBblEgE1KMS9fpBOg+o6C/6W v/uGISQ+5rxk9SK7mpRsmIc0MwusvI9+el8w5ASPqBXIAvyhQ9x0kWRKxvthSaIqvaPq U6fAp9P1BO0MLEUDEuw/WvllkEVfjezQXIaw9AzGtkVvN4TRSQZ9YJbNifM4P2GtNvcX dLAbt9r5Sl83j0siebQZlYJGDpkVa3z2VxH3FkG0U/87cy9Mx0rvRpegkkjFN2QZmusr yyBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681303032; x=1683895032; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XlPGOEtsm4yXWy2CRwfyz8yJm7chpphnSboTfMHJA74=; b=KAZj1uzZFTQs0Iz1T7RUX1C14WG5I69mI9UpykrbaHGaGa96TRZ1sY/zSOEI1SgVjX fgsSLXVLxS5q9e1KFESD9NKOmWp1A4aRxwPAl6igQQz06MFCgVNJSRiooJBjrINPTfHp 7S/3yt1EUeFlxlCgYJyog34QHK15r8A8JMJvcKmE6Te/JkX5NxxyxjRvblYRamxSC3Rv wJuA8HFAK5qv3JUw6mhoMsa6gQAanaNCf6lIjQKKu0qQbZNleGXGQvHCmLcJ75Sn1SKY XzgpY5TztHuawfesHGwBhuR1I1ZvjN4874Wnq0JMtnoGK2SfKzkHfEHPgsTh/agTXUeJ I2UA== X-Gm-Message-State: AAQBX9eHSK40fajZNDjcSynSgwsWousiek+HGiSf2MGkzN+MJfm2F49J NRTSumUOi6Ys3a7pO/RJngc= X-Google-Smtp-Source: AKy350b/FKsx7ymJxApYZSwxtD3dTUZkMdPQHQZgaKL9Oyg9tS/ejyYZjBsQSbJq+dIiL/2mMcVu6g== X-Received: by 2002:a05:6870:a40c:b0:16e:4fb6:707f with SMTP id m12-20020a056870a40c00b0016e4fb6707fmr1571245oal.3.1681303032048; Wed, 12 Apr 2023 05:37:12 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b69:9b67:19cc:485f:3268]) by smtp.gmail.com with ESMTPSA id w127-20020a4a5d85000000b00525398a1144sm7038012ooa.32.2023.04.12.05.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Apr 2023 05:37:11 -0700 (PDT) From: Fabio Estevam To: sbabic@denx.de Cc: uboot-imx@nxp.com, ye.li@nxp.com, u-boot@lists.denx.de, Fabio Estevam Subject: [PATCH v3] ARM: dts: imx7d-sdb-u-boot: Fix usdhc1 UHS operation Date: Wed, 12 Apr 2023 09:37:01 -0300 Message-Id: <20230412123701.2423563-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Fabio Estevam Commit 1a7904fdfa7d ("mmc: fsl_esdhc_imx: Use esdhc_soc_data flags to set host caps") exposed the following SD card error: U-Boot 2023.04-00652-g487e42f7bc5e (Apr 05 2023 - 22:14:21 -0300) CPU: Freescale i.MX7D rev1.0 1000 MHz (running at 792 MHz) CPU: Commercial temperature grade (0C to 95C) at 35C Reset cause: POR Model: Freescale i.MX7 SabreSD Board Board: i.MX7D SABRESD in non-secure mode DRAM: 1 GiB Core: 100 devices, 19 uclasses, devicetree: separate PMIC: PFUZE3000 DEV_ID=0x30 REV_ID=0x10 MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... Card did not respond to voltage select! : -110 *** Warning - No block device, using default environment The reason of the problem, as explained by Ye Li: "When UHS is enabled in defconfig, the usdhc1 node in imx7d-sdb.dts does not configure pad for VSELECT, also the data pad should be set to 100Mhz/200Mhz pin states." Apply these changes into u-boot.dtsi for now. When these changes reach the Linux mainline imx7d-sdb, they can be dropped from u-boot.dtsi. This fixes UHS mode on the imx7d-sdb board. Suggested-by: Ye Li Signed-off-by: Fabio Estevam --- Changes since v2: - Fixed the devicetree instead of the imx sdhci driver (Ye Li). arch/arm/dts/imx7d-sdb-u-boot.dtsi | 51 ++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/arch/arm/dts/imx7d-sdb-u-boot.dtsi b/arch/arm/dts/imx7d-sdb-u-boot.dtsi index b78358fa1397..913127b5e3c2 100644 --- a/arch/arm/dts/imx7d-sdb-u-boot.dtsi +++ b/arch/arm/dts/imx7d-sdb-u-boot.dtsi @@ -5,3 +5,54 @@ &usbotg1 { dr_mode = "peripheral"; }; + +&usdhc1 { + pinctrl-names = "default", "state_100mhz", "state_200mhz"; + pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_usdhc1_gpio>; + pinctrl-1 = <&pinctrl_usdhc1_100mhz>, <&pinctrl_usdhc1_gpio>; + pinctrl-2 = <&pinctrl_usdhc1_200mhz>, <&pinctrl_usdhc1_gpio>; +}; + +&pinctrl_uart1 { + fsl,pins = < + MX7D_PAD_SD1_CMD__SD1_CMD 0x59 + MX7D_PAD_SD1_CLK__SD1_CLK 0x19 + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x59 + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x59 + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x59 + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x59 + >; +}; + +&iomuxc { + pinctrl_usdhc1_gpio: usdhc1gpiogrp { + fsl,pins = < + MX7D_PAD_SD1_CD_B__GPIO5_IO0 0x59 /* CD */ + MX7D_PAD_SD1_WP__GPIO5_IO1 0x59 /* WP */ + MX7D_PAD_SD1_RESET_B__GPIO5_IO2 0x59 /* vmmc */ + MX7D_PAD_GPIO1_IO08__SD1_VSELECT 0x59 /* VSELECT */ + >; + }; + + pinctrl_usdhc1_100mhz: usdhc1100mhzgrp { + fsl,pins = < + MX7D_PAD_SD1_CMD__SD1_CMD 0x5a + MX7D_PAD_SD1_CLK__SD1_CLK 0x1a + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5a + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5a + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5a + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5a + >; + }; + + pinctrl_usdhc1_200mhz: usdhc1200mhzgrp { + fsl,pins = < + MX7D_PAD_SD1_CMD__SD1_CMD 0x5b + MX7D_PAD_SD1_CLK__SD1_CLK 0x1b + MX7D_PAD_SD1_DATA0__SD1_DATA0 0x5b + MX7D_PAD_SD1_DATA1__SD1_DATA1 0x5b + MX7D_PAD_SD1_DATA2__SD1_DATA2 0x5b + MX7D_PAD_SD1_DATA3__SD1_DATA3 0x5b + >; + }; +}; -- 2.34.1