From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3146BC77B76 for ; Mon, 17 Apr 2023 18:22:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9AE1385E55; Mon, 17 Apr 2023 20:22:35 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="efktkxEn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F2A5A85E55; Mon, 17 Apr 2023 20:22:33 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 57BF685746 for ; Mon, 17 Apr 2023 20:22:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ralph.siemsen@linaro.org Received: by mail-qv1-xf31.google.com with SMTP id o7so22701027qvs.0 for ; Mon, 17 Apr 2023 11:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681755749; x=1684347749; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ThDS4WMIvgAWVJ9xhdVrFjZupxaJCgCotvbAqaVuPQc=; b=efktkxEnh7nJIjo7Cq2rW1AUuZuH+U1rH0moqGxcpaGIoCIC5z/uAWZ6E9TOcBnvkL WsC9YdZDq4kTDBxBIG7RaVe+EXe7uU8izQkfXTMgCr3JTbns2GBbSvLfbhdVdka/EEYT 7kBTQKZzU101fxHgY8btm/HS5TAC0PynVEsap7gcNyHKzmEdrBC9datiW0J7xeTn1FIA E0nwPylQLtB05Tw1q/d/azCd/XU62lBbyw9thxcfo6fuMm+sxQ/fhCAZxCH2B9fQWWou kRT6V+rLm+rqrNcU8pQHJaR65nFr00z7htPRqlQmuDkixLAJCou/lDy3dVoeHlpRQCcY v3iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681755749; x=1684347749; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ThDS4WMIvgAWVJ9xhdVrFjZupxaJCgCotvbAqaVuPQc=; b=dXSDMi+rexYbrkqDQs7MtEplSkK70hZoRYbok1bPAzn31UZVR+DMqLfOX6rT3TngAR 0uyDgF0BOoMq+75hlRHaAezOrA0LkQkvuWA01pckaP1BEGhuU4Ot6UDat0naXiAvGHsd KjNRBC8G0d7tXge/Ed9r3ODDcfa/LLqEPSwJJIzIM7nDAQSra18TdhtTd3vmBjQ9h90v JRXUAMm0JTVlmhYAoCT0EHdS66u9sECzJ5QZ+DZM9YmHkSWFj7l9lBnjJa2tVrFwkcoI KUBBatOJwp/6N5gbxyuQFbkaYAVgPFymoU+zJoBMiCVzYj8ZMvTXS4+l2N9fu6X+HxEv CZmQ== X-Gm-Message-State: AAQBX9cFpoczKXRQCqYapuarUKjmfu3m04rbc3zxiN8yHKckgNDeXCXO 8183XnlTKzRg2ZZm632j0T99pw== X-Google-Smtp-Source: AKy350b49QdO0kZk3959lHitLuxDK4BDoJWA3YLHkiJdkK6Z4iELDDnmKJwGa0USgi8ti5OX8l30Pg== X-Received: by 2002:a05:6214:508d:b0:5d5:fd1d:6ef5 with SMTP id kk13-20020a056214508d00b005d5fd1d6ef5mr15988216qvb.12.1681755749144; Mon, 17 Apr 2023 11:22:29 -0700 (PDT) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id me10-20020a0562145d0a00b005dd8b9345b4sm3195240qvb.76.2023.04.17.11.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 11:22:28 -0700 (PDT) Date: Mon, 17 Apr 2023 14:22:28 -0400 From: Ralph Siemsen To: Marek Vasut Cc: u-boot@lists.denx.de, Sean Anderson , Hai Pham , Lukasz Majewski , Marek Vasut Subject: Re: [PATCH v4 02/10] clk: renesas: prepare for non-RCAR clock drivers Message-ID: <20230417182228.GA642444@maple.netwinder.org> References: <20230308202653.1926303-1-ralph.siemsen@linaro.org> <20230308202653.1926303-3-ralph.siemsen@linaro.org> <8dc5cc01-c451-cf1b-f90f-f5d269adbc4d@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <8dc5cc01-c451-cf1b-f90f-f5d269adbc4d@mailbox.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Marek, On Mon, Apr 17, 2023 at 07:02:34PM +0200, Marek Vasut wrote: >On 3/8/23 21:26, Ralph Siemsen wrote: >>diff --git a/drivers/clk/renesas/Makefile >>b/drivers/clk/renesas/Makefile >>index 8f82a7aa3e..a0d8c10bdb 100644 >>--- a/drivers/clk/renesas/Makefile >>+++ b/drivers/clk/renesas/Makefile >>@@ -1,6 +1,5 @@ >>-obj-$(CONFIG_CLK_RENESAS) += renesas-cpg-mssr.o >> obj-$(CONFIG_CLK_RCAR_CPG_LIB) += rcar-cpg-lib.o >>-obj-$(CONFIG_CLK_RCAR_GEN2) += clk-rcar-gen2.o >>+obj-$(CONFIG_CLK_RCAR_GEN2) += clk-rcar-gen2.o renesas-cpg-mssr.o > >Why not move the renesas-cpg-mssr.o into obj-$(CONFIG_CLK_RCAR_CPG_LIB) >line instead ? I think this would break the build for gen2 devices, because they make calls to CPG functions (eg. renesas_clk_endisable from clk-rcar-gen2.c), however Kconfig only selects CPG lib for gen3. Perhaps we could change Kconfig to select CPG also for gen2. I can make this patch, but how to test that this does not introduce any new problems? Might there be an autobuilder for R-Car somewhere? >I suspect RZN1 is not using the CPG lib anyway ? You are correct, RZN1 does not use the CPG lib. Regards Ralph