public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Ralph Siemsen <ralph.siemsen@linaro.org>
To: Marek Vasut <marek.vasut@mailbox.org>
Cc: u-boot@lists.denx.de, Hai Pham <hai.pham.ud@renesas.com>,
	Lukasz Majewski <lukma@denx.de>,
	Marek Vasut <marek.vasut+renesas@mailbox.org>,
	Sean Anderson <seanga2@gmail.com>
Subject: Re: [PATCH v4 03/10] clk: renesas: add R906G032 driver
Date: Mon, 17 Apr 2023 14:29:02 -0400	[thread overview]
Message-ID: <20230417182902.GC642444@maple.netwinder.org> (raw)
In-Reply-To: <9bd72218-55f7-ac32-2924-5ee128563a31@mailbox.org>

On Mon, Apr 17, 2023 at 07:07:57PM +0200, Marek Vasut wrote:
>
>R-Car , not RCAR .

Ack, will fix in next version (including in some commit msg)

>>+static int r9a06g032_clk_probe(struct udevice *dev)
>>+{
>>+	struct r9a06g032_priv *priv = dev_get_priv(dev);
>>+	int err;
>>+
>>+	priv->regmap = syscon_regmap_lookup_by_phandle(dev, "regmap");
>>+	if (IS_ERR(priv->regmap)) {
>>+		dev_dbg(dev, "unable to find regmap\n");
>>+		return PTR_ERR(priv->regmap);
>>+	}
>>+
>>+	/* Enable S/W reset */
>>+	regmap_write(priv->regmap, 0x120, 0x41);
>>+
>>+	/* Get master clock */
>>+	err = clk_get_by_name(dev, "mclk", &priv->mclk);
>>+	if (err)
>>+		return err;
>>+
>>+	return 0;
>
>You can use 'return clk_get_by_name(...)' here directly instead of the

Will do.

Ralph

  reply	other threads:[~2023-04-17 18:29 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-08 20:26 [PATCH v4 00/10] Renesas RZ/N1 SoC initial support Ralph Siemsen
2023-03-08 20:26 ` [PATCH v4 01/10] ARM: armv7: add non-SPL enable for Cortex SMPEN Ralph Siemsen
2023-04-17 17:04   ` Marek Vasut
2023-04-17 18:26     ` Ralph Siemsen
2023-04-17 20:21       ` Marek Vasut
2023-04-18 14:32         ` Ralph Siemsen
2023-04-18 19:35           ` Marek Vasut
2023-03-08 20:26 ` [PATCH v4 02/10] clk: renesas: prepare for non-RCAR clock drivers Ralph Siemsen
2023-04-17 17:02   ` Marek Vasut
2023-04-17 18:22     ` Ralph Siemsen
2023-04-17 20:33       ` Marek Vasut
2023-04-17 20:48         ` Ralph Siemsen
2023-04-17 22:24           ` Marek Vasut
2023-03-08 20:26 ` [PATCH v4 03/10] clk: renesas: add R906G032 driver Ralph Siemsen
2023-04-17 17:07   ` Marek Vasut
2023-04-17 18:29     ` Ralph Siemsen [this message]
2023-03-08 20:26 ` [PATCH v4 04/10] pinctrl: " Ralph Siemsen
2023-04-17 17:09   ` Marek Vasut
2023-03-08 20:26 ` [PATCH v4 05/10] ram: cadence: add driver for Cadence EDAC Ralph Siemsen
2023-04-17 17:32   ` Marek Vasut
2023-04-17 20:33     ` Ralph Siemsen
2023-03-08 20:26 ` [PATCH v4 06/10] dts: basic devicetree for Renesas RZ/N1 SoC Ralph Siemsen
2023-04-17 17:12   ` Marek Vasut
2023-04-17 18:33     ` Ralph Siemsen
2023-04-17 20:22       ` Marek Vasut
2023-03-08 20:26 ` [PATCH v4 07/10] ARM: rzn1: basic support " Ralph Siemsen
2023-04-17 17:15   ` Marek Vasut
2023-04-17 18:57     ` Ralph Siemsen
2023-04-17 20:30       ` Marek Vasut
2023-04-17 20:44         ` Ralph Siemsen
2023-04-17 22:23           ` Marek Vasut
2023-03-08 20:26 ` [PATCH v4 08/10] board: schneider: add RZN1 board support Ralph Siemsen
2023-04-17 17:18   ` Marek Vasut
2023-04-17 19:45     ` Ralph Siemsen
2023-04-17 20:27       ` Marek Vasut
2023-03-08 20:26 ` [PATCH v4 09/10] tools: spkgimage: add Renesas SPKG format Ralph Siemsen
2023-04-17 17:23   ` Marek Vasut
2023-04-17 20:17     ` Ralph Siemsen
2023-04-17 20:28       ` Marek Vasut
2023-03-08 20:26 ` [PATCH v4 10/10] doc: renesas: add Renesas board docs Ralph Siemsen
2023-04-17 17:28   ` Marek Vasut
2023-04-17 20:29     ` Ralph Siemsen
2023-04-17 20:34       ` Marek Vasut
2023-04-17 20:50         ` Ralph Siemsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230417182902.GC642444@maple.netwinder.org \
    --to=ralph.siemsen@linaro.org \
    --cc=hai.pham.ud@renesas.com \
    --cc=lukma@denx.de \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=marek.vasut@mailbox.org \
    --cc=seanga2@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox