From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E78EC77B7A for ; Mon, 17 Apr 2023 18:29:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 056C785FE5; Mon, 17 Apr 2023 20:29:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="UefMCznD"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4D18785FE5; Mon, 17 Apr 2023 20:29:09 +0200 (CEST) Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 100CC85746 for ; Mon, 17 Apr 2023 20:29:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ralph.siemsen@linaro.org Received: by mail-qt1-x82f.google.com with SMTP id bb13so2718599qtb.11 for ; Mon, 17 Apr 2023 11:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681756144; x=1684348144; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iHbPc9xuNqwigxhcSO3tsMmJzEcH97YHjUoFEeuEi6A=; b=UefMCznD70oPC8BwYoGu9Ba1zyGlbNR7UD5auSwb/fciNvWno1FFFMGNOEdU2CaoJt chwIDQKS7iKH3s7NudWQF8XXB3i2U1A6Nai9LahPUIiRL+6x8OXsCtmnKI1+4211yAXj RU5iIa8C+doH04bc/dJNdBoN9wfFzLvr7WLRibd4LIiYqp9RIXlCBZudq9xMY3L1ten4 C4XzE3GESHdu7iL0yqOpgC1mSBVi81oEcEU7hv5fkfV/oD6iGyX/U/SEi0Vt/1DhPF8B ChGmEtTq5VRD1OG5OnCTOg7oh15QDFv3KiBZ7p7C8J2YVNtS7Yjq0LQMTMiZ/hwuR89q iKSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681756144; x=1684348144; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iHbPc9xuNqwigxhcSO3tsMmJzEcH97YHjUoFEeuEi6A=; b=CvrsNlWz3zHRLh449yHtKa7HwMlTCefoaIGfgZrnHa+scd7Mv2A6iSCiHgsQrVjDkO ytEVvEai1jXss8FQ/pRhzz4ZO+JrlgBZ3UXFML/tF+NOL8LgEHcK0yVccoa6FUI9cbQz WU58CEGfgKal8+pIwYio0z3CP+kvHeookhQtEWSu+sG0chQAKTMLDTS8Qb35k6oCg35X r6a4iT/aptBXineZg2IFtyaD+4yiFn2/VS3616m9w8YRS/7a3uB5ctMOc5/D2O9gUN2K 9/1QDlze8OIchPdJp5IjKTqehCUbX7C7Zc4UU0pGH3bpHgBzkiecRhvc0Lln36U1CV0M LFpg== X-Gm-Message-State: AAQBX9fQdxzY4KjHYe/gmKMQGeYt1sEVpcKeH9Q87Q2y2fVdLUeB5dcx dPGqae/JRqxgVr8eI7S8GNzxsw== X-Google-Smtp-Source: AKy350YNXmNZrzlJhRMVqCKKqmcHg0l3/6uGcHonkTkRvzP1oQIsXtvTuwbnCKf7zxne5Eu6N9LgQA== X-Received: by 2002:a05:622a:102:b0:3ba:26a0:d0ee with SMTP id u2-20020a05622a010200b003ba26a0d0eemr20979503qtw.52.1681756143853; Mon, 17 Apr 2023 11:29:03 -0700 (PDT) Received: from localhost (rfs.netwinder.org. [206.248.184.2]) by smtp.gmail.com with ESMTPSA id d13-20020ac85acd000000b003edce7e34bfsm1723522qtd.81.2023.04.17.11.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Apr 2023 11:29:03 -0700 (PDT) Date: Mon, 17 Apr 2023 14:29:02 -0400 From: Ralph Siemsen To: Marek Vasut Cc: u-boot@lists.denx.de, Hai Pham , Lukasz Majewski , Marek Vasut , Sean Anderson Subject: Re: [PATCH v4 03/10] clk: renesas: add R906G032 driver Message-ID: <20230417182902.GC642444@maple.netwinder.org> References: <20230308202653.1926303-1-ralph.siemsen@linaro.org> <20230308202653.1926303-4-ralph.siemsen@linaro.org> <9bd72218-55f7-ac32-2924-5ee128563a31@mailbox.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <9bd72218-55f7-ac32-2924-5ee128563a31@mailbox.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Mon, Apr 17, 2023 at 07:07:57PM +0200, Marek Vasut wrote: > >R-Car , not RCAR . Ack, will fix in next version (including in some commit msg) >>+static int r9a06g032_clk_probe(struct udevice *dev) >>+{ >>+ struct r9a06g032_priv *priv = dev_get_priv(dev); >>+ int err; >>+ >>+ priv->regmap = syscon_regmap_lookup_by_phandle(dev, "regmap"); >>+ if (IS_ERR(priv->regmap)) { >>+ dev_dbg(dev, "unable to find regmap\n"); >>+ return PTR_ERR(priv->regmap); >>+ } >>+ >>+ /* Enable S/W reset */ >>+ regmap_write(priv->regmap, 0x120, 0x41); >>+ >>+ /* Get master clock */ >>+ err = clk_get_by_name(dev, "mclk", &priv->mclk); >>+ if (err) >>+ return err; >>+ >>+ return 0; > >You can use 'return clk_get_by_name(...)' here directly instead of the Will do. Ralph