Re: [PATCH v4 07/10] ARM: rzn1: basic support for Renesas RZ/N1 SoC

[Ralph Siemsen <ralph.siemsen@linaro.org>]

On Mon, Apr 17, 2023 at 10:30:26PM +0200, Marek Vasut wrote:
>I mean, if you drop 'CLK' and 'CLK_RENESAS' from this list, do they 
>still get selected because 'CLK_R8A06G032' is in this list ? If yes, 
>then drop them from this list, else keep them.

If I drop the first two, I get some kconfig warnings:

WARNING: unmet direct dependencies detected for CLK_R9A06G032
   Depends on [n]: CLK_RENESAS [=n]
   Selected by [y]:
   - ARCH_RZN1 [=y] && <choice>

And there is no output on the UART.

>>I don't have a strong preference, if moving to mach-rmobile makes 
>>sense, let me know and I can give it a go.
>
>I think it does make sense to keep all the renesas stuff in 
>mach-rmobile . We can rename that to mach-renesas in some subsequent 
>patch.

Okay, I will try moving it. Does this also then mean I should abandon 
ARCH_RZN1 in favour of ARCH_RMOBILE? This could be more challenging...

>>>Why not enable icache with icache_enable() too ?
>>
>>The I-cache is enabled quite early in arch/arm/cpu/armv7/start.S
>
>Add a comment please.

Done!

Ralph