Re: [PATCH V7 11/14] common: Enable splash functions at SPL

["Lothar Waßmann" <LW@KARO-electronics.de>]

Hi,

On Mon, 10 Apr 2023 12:58:40 +0530 Nikhil M Jain wrote:
> To support splash screen at both u-boot proper and SPL use
> CONFIG_IS_ENABLED and CONFIG_VAL to check for video related Kconfigs at
> respective stages.
> 
> Replace CONFIG_CMD_BMP with CONFIG_BMP to enable splash_display function
> at u-boot proper and SPL.
> 
> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
> Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> V7:
> - Add Reviewed-by tag.
> 
> V6:
> - Fix commit message.
> - Add Reviewed-by tag.
> 
> V5:
> - Replace CONFIG_CMD_BMP with CONFIG_BMP.
> 
> V4:
> - No change
> 
> V3 (patch introduced):
> - Enable splash functions at SPL
> 
>  common/bmp.c     | 12 ++++++------
>  common/splash.c  | 10 +++++-----
>  include/splash.h |  2 +-
>  3 files changed, 12 insertions(+), 12 deletions(-)
> 
[...]
> diff --git a/include/splash.h b/include/splash.h
> index 33e45e6941..083c978582 100644
> --- a/include/splash.h
> +++ b/include/splash.h
> @@ -78,4 +78,4 @@ static inline int splash_display(void)
>  
>  #define BMP_ALIGN_CENTER	0x7FFF
>  
> -#endif
> +#endif
> \ No newline at end of file

Your patch is removing the <LF> at the end of the file!


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@karo-electronics.de
___________________________________________________________