From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A091C77B71 for ; Tue, 18 Apr 2023 09:11:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8CEAC85BD0; Tue, 18 Apr 2023 11:10:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=KARO-electronics.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 1866185AEC; Tue, 18 Apr 2023 11:10:56 +0200 (CEST) Received: from smtprelay07.ispgateway.de (smtprelay07.ispgateway.de [134.119.228.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A720885D74 for ; Tue, 18 Apr 2023 11:10:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=KARO-electronics.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=LW@KARO-electronics.de Received: from [89.1.81.74] (helo=karo-electronics.de) by smtprelay07.ispgateway.de with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pohMS-0004v3-MJ; Tue, 18 Apr 2023 11:10:52 +0200 Date: Tue, 18 Apr 2023 11:10:51 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Nikhil M Jain Cc: , , , , , Subject: Re: [PATCH V7 11/14] common: Enable splash functions at SPL Message-ID: <20230418111051.32346ad0@karo-electronics.de> In-Reply-To: <20230410072843.97922-12-n-jain1@ti.com> References: <20230410072843.97922-1-n-jain1@ti.com> <20230410072843.97922-12-n-jain1@ti.com> Organization: Ka-Ro electronics GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Df-Sender: bHdAa2Fyby1lbGVjdHJvbmljcy5kb21haW5mYWN0b3J5LWt1bmRlLmRl X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, On Mon, 10 Apr 2023 12:58:40 +0530 Nikhil M Jain wrote: > To support splash screen at both u-boot proper and SPL use > CONFIG_IS_ENABLED and CONFIG_VAL to check for video related Kconfigs at > respective stages. >=20 > Replace CONFIG_CMD_BMP with CONFIG_BMP to enable splash_display function > at u-boot proper and SPL. >=20 > Signed-off-by: Nikhil M Jain > Reviewed-by: Devarsh Thakkar > Reviewed-by: Simon Glass > --- > V7: > - Add Reviewed-by tag. >=20 > V6: > - Fix commit message. > - Add Reviewed-by tag. >=20 > V5: > - Replace CONFIG_CMD_BMP with CONFIG_BMP. >=20 > V4: > - No change >=20 > V3 (patch introduced): > - Enable splash functions at SPL >=20 > common/bmp.c | 12 ++++++------ > common/splash.c | 10 +++++----- > include/splash.h | 2 +- > 3 files changed, 12 insertions(+), 12 deletions(-) >=20 [...] > diff --git a/include/splash.h b/include/splash.h > index 33e45e6941..083c978582 100644 > --- a/include/splash.h > +++ b/include/splash.h > @@ -78,4 +78,4 @@ static inline int splash_display(void) > =20 > #define BMP_ALIGN_CENTER 0x7FFF > =20 > -#endif > +#endif > \ No newline at end of file Your patch is removing the at the end of the file! Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________