Re: [PATCH 1/1] sandbox: enable CONFIG_EFI_CAPSULE_AUTHENTICATE

[AKASHI Takahiro <takahiro.akashi@linaro.org>]

On Thu, Apr 20, 2023 at 09:30:24AM +0300, Ilias Apalodimas wrote:
> Hi Simon,
> 
> On Thu, 20 Apr 2023 at 01:41, Simon Glass <sjg@chromium.org> wrote:
> >
> > Hi Ilias,
> >
> > On Wed, 19 Apr 2023 at 18:05, Ilias Apalodimas
> > <ilias.apalodimas@linaro.org> wrote:
> > >
> > > On Tue, Apr 18, 2023 at 10:47:24AM -0600, Simon Glass wrote:
> > > > Hi Heinrich,
> > > >
> > > > On Fri, 14 Apr 2023 at 02:39, Heinrich Schuchardt
> > > > <heinrich.schuchardt@canonical.com> wrote:
> > > > >
> > > > > Without CONFIG_EFI_CAPSULE_AUTHENTICATE=y the following tests are skipped:
> > > > >
> > > > > * test/py/tests/test_efi_capsule/test_capsule_firmware_signed_fit.py
> > > > > * test/py/tests/test_efi_capsule/test_capsule_firmware_signed_raw.py
> > > > >
> > > > > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > > > > ---
> > > > >  configs/sandbox_defconfig          | 1 +
> > > > >  configs/sandbox_flattree_defconfig | 1 +
> > > > >  2 files changed, 2 insertions(+)
> > > > >
> > > >
> > > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > >
> > > > This still has the problem that it reboots in the middle of the test.
> > > > Can we get that fixed? If someone at Linaro isn't interested I could
> > > > take a look at it.
> > >
> > > I think we discussed this in the past.  We *need* to reboot as that's what
> > > the EFI describes.  Why is it a problem?
> >
> > Would you like me to provide a patch that shows it not rebooting? It
> > is a simple matter of kicking off the update process, which we can do
> > directly, without a reboot.
> 
> I know it's a single efidebug command to trigger this without a
> reboot.  However it is not going to test the final code which is meant
> to run capsule updates on a reboot as the spec defines.  So again, why
> is rebooting a problem?

I guess that what we are looking for are different.
Simon's aim is to do, so called, an unit test first, using an internal function,
while what I, rather we?, intended to do a system test or standard-conformance test.

I believe that we need to have some consensus on test methodology to be
added to U-Boot repository.

-Takahiro Akashi

> Regards
> /Ilias
> >
> > Regards,
> > Simon