From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F1EFC77B72 for ; Thu, 20 Apr 2023 07:12:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5ED0686191; Thu, 20 Apr 2023 09:12:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="Sxs0aITg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7621D861A4; Thu, 20 Apr 2023 09:12:36 +0200 (CEST) Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 024E98564D for ; Thu, 20 Apr 2023 09:12:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-517f1d5645aso128203a12.0 for ; Thu, 20 Apr 2023 00:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681974751; x=1684566751; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=hk31BnU6l391ZiSmtcbYV1YDidyr7IiSrALt9+EsPUM=; b=Sxs0aITgwFoSmUTZ3LDyLmtaxXwu+0IFIRs0cHx7P8wsMqwGout74vfyb2EQP20/Rq zIPtrVEHbEgz511NGUjvgCmfc/Gw81EVs8b35xhC+kP5blm4wkBwGsM5w0STWPHRqodD +NnqXPvfqpYoLxvOlxx5PsTup16Lh2hmVo/pzfzgMmIQcZIFPmd5X2uxQA0bo5Ik3yeX ybWfuN15Uf96fqxVtP2Q7MMCt5Cj8jog9fx+mALmXL44u49mkYpg3x4VzZ4dU4b5mLZ0 CjIh8MORpXN4EKj2+VNsEKzfCvMMmfKWuvHMRSofsLfLdyCuuWx9JQa5WRLWXib89csy /gCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681974751; x=1684566751; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hk31BnU6l391ZiSmtcbYV1YDidyr7IiSrALt9+EsPUM=; b=eNDvALWUfw/3P6V7syQtTQA74f5XOKtHYDLrJjQ05kXlWU7FugPL10ZrRxiF20RD4O 81t/n+BFn7GikHdO+XypoJnT1182Gc7c318UmJKN+QqSnpfZX+R7r0VmnbyBgIFH/pcb G+BzKA5/hPTDx3TgxI363PeHLYCoOlovrDKoF9IbmQmqG0fxPahrbdMAVLthMLg+wNlV kcUB0N72gqxYNRNYhjcQdQ76tPibnNKo+gJoD2hFgE7tRRxysMSHdhYUX5L+Ms9cbfkx pKMU5s0McEBcJTsCc0mNQPY7eOtMdYs8r5p5j2MTkRdhcluq4HY8n60uf5Bw6O0Q5dr3 RG5A== X-Gm-Message-State: AAQBX9cmDRb4jtbJ0hr9oWlNSqvuR/ILT1m/Jx1y0CHCNSwgb5yujlsx 5aFSrob4G60RYr97Vs5Mvtje5Q== X-Google-Smtp-Source: AKy350amr6huSnPJ6yxpKZTnm60l11fwUB/jKXINUaz6Nq3zqc1AigwUGNDJEaT/pQNfZUFGZZ3dag== X-Received: by 2002:a05:6a00:311e:b0:627:fe88:a2e with SMTP id bi30-20020a056a00311e00b00627fe880a2emr379176pfb.0.1681974751240; Thu, 20 Apr 2023 00:12:31 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:8680:bb89:81b:e736]) by smtp.gmail.com with ESMTPSA id x30-20020a056a000bde00b0063b806b111csm533471pfu.169.2023.04.20.00.12.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Apr 2023 00:12:30 -0700 (PDT) Date: Thu, 20 Apr 2023 16:12:27 +0900 From: AKASHI Takahiro To: Ilias Apalodimas Cc: Simon Glass , Heinrich Schuchardt , u-boot@lists.denx.de, Sughosh Ganu Subject: Re: [PATCH 1/1] sandbox: enable CONFIG_EFI_CAPSULE_AUTHENTICATE Message-ID: <20230420071227.GA38118@laputa> Mail-Followup-To: AKASHI Takahiro , Ilias Apalodimas , Simon Glass , Heinrich Schuchardt , u-boot@lists.denx.de, Sughosh Ganu References: <20230414083918.288470-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, Apr 20, 2023 at 09:30:24AM +0300, Ilias Apalodimas wrote: > Hi Simon, > > On Thu, 20 Apr 2023 at 01:41, Simon Glass wrote: > > > > Hi Ilias, > > > > On Wed, 19 Apr 2023 at 18:05, Ilias Apalodimas > > wrote: > > > > > > On Tue, Apr 18, 2023 at 10:47:24AM -0600, Simon Glass wrote: > > > > Hi Heinrich, > > > > > > > > On Fri, 14 Apr 2023 at 02:39, Heinrich Schuchardt > > > > wrote: > > > > > > > > > > Without CONFIG_EFI_CAPSULE_AUTHENTICATE=y the following tests are skipped: > > > > > > > > > > * test/py/tests/test_efi_capsule/test_capsule_firmware_signed_fit.py > > > > > * test/py/tests/test_efi_capsule/test_capsule_firmware_signed_raw.py > > > > > > > > > > Signed-off-by: Heinrich Schuchardt > > > > > --- > > > > > configs/sandbox_defconfig | 1 + > > > > > configs/sandbox_flattree_defconfig | 1 + > > > > > 2 files changed, 2 insertions(+) > > > > > > > > > > > > > Reviewed-by: Simon Glass > > > > > > > > This still has the problem that it reboots in the middle of the test. > > > > Can we get that fixed? If someone at Linaro isn't interested I could > > > > take a look at it. > > > > > > I think we discussed this in the past. We *need* to reboot as that's what > > > the EFI describes. Why is it a problem? > > > > Would you like me to provide a patch that shows it not rebooting? It > > is a simple matter of kicking off the update process, which we can do > > directly, without a reboot. > > I know it's a single efidebug command to trigger this without a > reboot. However it is not going to test the final code which is meant > to run capsule updates on a reboot as the spec defines. So again, why > is rebooting a problem? I guess that what we are looking for are different. Simon's aim is to do, so called, an unit test first, using an internal function, while what I, rather we?, intended to do a system test or standard-conformance test. I believe that we need to have some consensus on test methodology to be added to U-Boot repository. -Takahiro Akashi > Regards > /Ilias > > > > Regards, > > Simon