public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Torsten Duwe <duwe@lst.de>
To: Leo Liang <ycliang@andestech.com>
Cc: Matthias Brugger <mbrugger@suse.com>,
	yanhong wang <yanhong.wang@starfivetech.com>,
	<u-boot@lists.denx.de>, Rick Chen <rick@andestech.com>,
	Lukasz Majewski <lukma@denx.de>,
	Sean Anderson <seanga2@gmail.com>,
	Lee Kuan Lim <kuanlim.lee@starfivetech.com>,
	Jianlong Huang <jianlong.huang@starfivetech.com>,
	Emil Renner Berthing <kernel@esmil.dk>
Subject: Re: [RFC] riscv: visionfive2: use OF_BOARD_SETUP
Date: Thu, 20 Apr 2023 09:43:50 +0200	[thread overview]
Message-ID: <20230420094350.6eec7571@blackhole.lan> (raw)
In-Reply-To: <ZEDc1Umt/8JvhoBc@ubuntu01>

Hi Leo, thanks for the quick reply!

On Thu, 20 Apr 2023 06:33:57 +0000
Leo Liang <ycliang@andestech.com> wrote:

> Hi, Torsten, Matthias,
> 
> On Wed, Apr 19, 2023 at 02:34:03PM +0200, Matthias Brugger wrote:
> > 
> > 
> > On 19/04/2023 13:28, Torsten Duwe wrote:

> > > This is only a proof of concept; let me know if you like it and I
> > > can add the other 12 DT patches to adjust_for_rev13b(), or maybe
> > > start with 1.3b as the default and go the other way, or something
> > > in between.

> LGTM as well!

Thank you very much! Again, this is only a PoC; if you agree with the
concept, I clean it up and fill in the complete DT patching.

Questions: shall I default to 1.3B and patch older 1.2A, or vice versa,
or do it like your (starfive) patch set and start with something
"neutral" and then patch both ways? And, more important, what is the
correct interpretation of the board revision byte -- I assume it's
offset 0x76 in the EEPROM? Is it always? Is ">= 0xB2" the correct
discriminator?

	Torsten

  reply	other threads:[~2023-04-20  7:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19 11:28 [RFC] riscv: visionfive2: use OF_BOARD_SETUP Torsten Duwe
2023-04-19 12:34 ` Matthias Brugger
2023-04-20  6:33   ` Leo Liang
2023-04-20  7:43     ` Torsten Duwe [this message]
2023-04-20  8:48       ` yanhong wang
2023-04-20 12:19       ` Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230420094350.6eec7571@blackhole.lan \
    --to=duwe@lst.de \
    --cc=jianlong.huang@starfivetech.com \
    --cc=kernel@esmil.dk \
    --cc=kuanlim.lee@starfivetech.com \
    --cc=lukma@denx.de \
    --cc=mbrugger@suse.com \
    --cc=rick@andestech.com \
    --cc=seanga2@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=yanhong.wang@starfivetech.com \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox