From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B146DC77B73 for ; Thu, 20 Apr 2023 07:44:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2BA8185DFC; Thu, 20 Apr 2023 09:44:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id DCAA285DFC; Thu, 20 Apr 2023 09:44:15 +0200 (CEST) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ACF6585E51 for ; Thu, 20 Apr 2023 09:44:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=duwe@lst.de Received: by verein.lst.de (Postfix, from userid 107) id 1499C68B05; Thu, 20 Apr 2023 09:44:12 +0200 (CEST) Received: from blackhole.lan (p5b2ecf4b.dip0.t-ipconnect.de [91.46.207.75]) by verein.lst.de (Postfix) with ESMTPSA id 7263967328; Thu, 20 Apr 2023 09:43:56 +0200 (CEST) Date: Thu, 20 Apr 2023 09:43:50 +0200 From: Torsten Duwe To: Leo Liang Cc: Matthias Brugger , yanhong wang , , Rick Chen , Lukasz Majewski , Sean Anderson , Lee Kuan Lim , Jianlong Huang , Emil Renner Berthing Subject: Re: [RFC] riscv: visionfive2: use OF_BOARD_SETUP Message-ID: <20230420094350.6eec7571@blackhole.lan> In-Reply-To: References: <20230419112801.GA1907@lst.de> Organization: LST e.V. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.34; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Leo, thanks for the quick reply! On Thu, 20 Apr 2023 06:33:57 +0000 Leo Liang wrote: > Hi, Torsten, Matthias, > > On Wed, Apr 19, 2023 at 02:34:03PM +0200, Matthias Brugger wrote: > > > > > > On 19/04/2023 13:28, Torsten Duwe wrote: > > > This is only a proof of concept; let me know if you like it and I > > > can add the other 12 DT patches to adjust_for_rev13b(), or maybe > > > start with 1.3b as the default and go the other way, or something > > > in between. > LGTM as well! Thank you very much! Again, this is only a PoC; if you agree with the concept, I clean it up and fill in the complete DT patching. Questions: shall I default to 1.3B and patch older 1.2A, or vice versa, or do it like your (starfive) patch set and start with something "neutral" and then patch both ways? And, more important, what is the correct interpretation of the board revision byte -- I assume it's offset 0x76 in the EEPROM? Is it always? Is ">= 0xB2" the correct discriminator? Torsten