* [PATCH 1/3] configs: rockchip: rock-3a: make usb host work
@ 2023-04-20 9:56 FUKAUMI Naoki
2023-04-20 9:56 ` [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: FUKAUMI Naoki @ 2023-04-20 9:56 UTC (permalink / raw)
To: u-boot; +Cc: sjg, philipp.tomsich, kever.yang, FUKAUMI Naoki
add support for USB host function on ROCK 3A
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
configs/rock-3a-rk3568_defconfig | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
index e753832183..d24563a504 100644
--- a/configs/rock-3a-rk3568_defconfig
+++ b/configs/rock-3a-rk3568_defconfig
@@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
CONFIG_CMD_GPT=y
CONFIG_CMD_I2C=y
CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
# CONFIG_CMD_SETEXPR is not set
# CONFIG_SPL_DOS_PARTITION is not set
CONFIG_SPL_OF_CONTROL=y
@@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
CONFIG_MMC_SDHCI_ROCKCHIP=y
CONFIG_ETH_DESIGNWARE=y
CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
CONFIG_DM_PMIC=y
CONFIG_PMIC_RK8XX=y
CONFIG_SPL_PMIC_RK8XX=y
@@ -69,5 +72,14 @@ CONFIG_BAUDRATE=1500000
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYS_NS16550_MEM32=y
CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
+CONFIG_USB_DWC3_GENERIC=y
# CONFIG_BINMAN_FDT is not set
CONFIG_ERRNO_STR=y
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator
2023-04-20 9:56 [PATCH 1/3] configs: rockchip: rock-3a: make usb host work FUKAUMI Naoki
@ 2023-04-20 9:56 ` FUKAUMI Naoki
2023-04-20 10:08 ` Kever Yang
2023-04-20 9:56 ` [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb FUKAUMI Naoki
` (3 subsequent siblings)
4 siblings, 1 reply; 14+ messages in thread
From: FUKAUMI Naoki @ 2023-04-20 9:56 UTC (permalink / raw)
To: u-boot; +Cc: sjg, philipp.tomsich, kever.yang, FUKAUMI Naoki
enable commands for i2c/pmic/regulator and relevant configs.
also drop configs for unused regulators.
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
configs/radxa-cm3-io-rk3566_defconfig | 8 ++++++--
configs/rock-3a-rk3568_defconfig | 3 ++-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/configs/radxa-cm3-io-rk3566_defconfig b/configs/radxa-cm3-io-rk3566_defconfig
index 2100cf2cb2..9b99181714 100644
--- a/configs/radxa-cm3-io-rk3566_defconfig
+++ b/configs/radxa-cm3-io-rk3566_defconfig
@@ -37,9 +37,12 @@ CONFIG_SPL_BSS_MAX_SIZE=0x4000
CONFIG_SPL_STACK_R=y
CONFIG_SPL_ATF=y
CONFIG_CMD_GPT=y
+CONFIG_CMD_I2C=y
CONFIG_CMD_MMC=y
CONFIG_CMD_USB=y
# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
# CONFIG_SPL_DOS_PARTITION is not set
CONFIG_SPL_OF_CONTROL=y
CONFIG_OF_LIVE=y
@@ -60,8 +63,9 @@ CONFIG_ETH_DESIGNWARE=y
CONFIG_GMAC_ROCKCHIP=y
CONFIG_PHY_ROCKCHIP_INNO_USB2=y
CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
-CONFIG_REGULATOR_PWM=y
-CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_RK8XX=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_SPL_RAM=y
CONFIG_BAUDRATE=1500000
diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
index d24563a504..c03aa2a4c1 100644
--- a/configs/rock-3a-rk3568_defconfig
+++ b/configs/rock-3a-rk3568_defconfig
@@ -41,6 +41,8 @@ CONFIG_CMD_I2C=y
CONFIG_CMD_MMC=y
CONFIG_CMD_USB=y
# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
# CONFIG_SPL_DOS_PARTITION is not set
CONFIG_SPL_OF_CONTROL=y
CONFIG_OF_LIVE=y
@@ -64,7 +66,6 @@ CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
CONFIG_DM_PMIC=y
CONFIG_PMIC_RK8XX=y
CONFIG_SPL_PMIC_RK8XX=y
-CONFIG_REGULATOR_PWM=y
CONFIG_REGULATOR_RK8XX=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_SPL_RAM=y
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb
2023-04-20 9:56 [PATCH 1/3] configs: rockchip: rock-3a: make usb host work FUKAUMI Naoki
2023-04-20 9:56 ` [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
@ 2023-04-20 9:56 ` FUKAUMI Naoki
2023-04-20 10:08 ` Kever Yang
2023-04-20 10:43 ` Jonas Karlman
2023-04-20 10:07 ` [PATCH 1/3] configs: rockchip: rock-3a: make usb host work Kever Yang
` (2 subsequent siblings)
4 siblings, 2 replies; 14+ messages in thread
From: FUKAUMI Naoki @ 2023-04-20 9:56 UTC (permalink / raw)
To: u-boot; +Cc: sjg, philipp.tomsich, kever.yang, FUKAUMI Naoki
enable regulators for usb host function
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ++++
arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 ++++++++
2 files changed, 12 insertions(+)
diff --git a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
index 4e79173833..d183e93575 100644
--- a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
+++ b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
@@ -16,3 +16,7 @@
bootph-all;
status = "okay";
};
+
+&vcc5v0_usb30 {
+ regulator-boot-on;
+};
diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
index 9ef1e84770..b7b18e131a 100644
--- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
+++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
@@ -26,3 +26,11 @@
bootph-all;
status = "okay";
};
+
+&vcc5v0_usb_host {
+ regulator-boot-on;
+};
+
+&vcc5v0_usb_hub {
+ regulator-boot-on;
+};
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] configs: rockchip: rock-3a: make usb host work
2023-04-20 9:56 [PATCH 1/3] configs: rockchip: rock-3a: make usb host work FUKAUMI Naoki
2023-04-20 9:56 ` [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
2023-04-20 9:56 ` [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb FUKAUMI Naoki
@ 2023-04-20 10:07 ` Kever Yang
2023-04-20 10:37 ` Jonas Karlman
2023-04-20 12:00 ` [PATCH v2 1/4] " FUKAUMI Naoki
4 siblings, 0 replies; 14+ messages in thread
From: Kever Yang @ 2023-04-20 10:07 UTC (permalink / raw)
To: FUKAUMI Naoki, u-boot; +Cc: sjg, philipp.tomsich
On 2023/4/20 17:56, FUKAUMI Naoki wrote:
> add support for USB host function on ROCK 3A
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> configs/rock-3a-rk3568_defconfig | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
> index e753832183..d24563a504 100644
> --- a/configs/rock-3a-rk3568_defconfig
> +++ b/configs/rock-3a-rk3568_defconfig
> @@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
> CONFIG_CMD_GPT=y
> CONFIG_CMD_I2C=y
> CONFIG_CMD_MMC=y
> +CONFIG_CMD_USB=y
> # CONFIG_CMD_SETEXPR is not set
> # CONFIG_SPL_DOS_PARTITION is not set
> CONFIG_SPL_OF_CONTROL=y
> @@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
> CONFIG_MMC_SDHCI_ROCKCHIP=y
> CONFIG_ETH_DESIGNWARE=y
> CONFIG_GMAC_ROCKCHIP=y
> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
> CONFIG_DM_PMIC=y
> CONFIG_PMIC_RK8XX=y
> CONFIG_SPL_PMIC_RK8XX=y
> @@ -69,5 +72,14 @@ CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> +CONFIG_USB=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_XHCI_DWC3=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_EHCI_GENERIC=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_GENERIC=y
> +CONFIG_USB_DWC3=y
> +CONFIG_USB_DWC3_GENERIC=y
> # CONFIG_BINMAN_FDT is not set
> CONFIG_ERRNO_STR=y
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator
2023-04-20 9:56 ` [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
@ 2023-04-20 10:08 ` Kever Yang
0 siblings, 0 replies; 14+ messages in thread
From: Kever Yang @ 2023-04-20 10:08 UTC (permalink / raw)
To: FUKAUMI Naoki, u-boot; +Cc: sjg, philipp.tomsich
On 2023/4/20 17:56, FUKAUMI Naoki wrote:
> enable commands for i2c/pmic/regulator and relevant configs.
> also drop configs for unused regulators.
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> configs/radxa-cm3-io-rk3566_defconfig | 8 ++++++--
> configs/rock-3a-rk3568_defconfig | 3 ++-
> 2 files changed, 8 insertions(+), 3 deletions(-)
>
> diff --git a/configs/radxa-cm3-io-rk3566_defconfig b/configs/radxa-cm3-io-rk3566_defconfig
> index 2100cf2cb2..9b99181714 100644
> --- a/configs/radxa-cm3-io-rk3566_defconfig
> +++ b/configs/radxa-cm3-io-rk3566_defconfig
> @@ -37,9 +37,12 @@ CONFIG_SPL_BSS_MAX_SIZE=0x4000
> CONFIG_SPL_STACK_R=y
> CONFIG_SPL_ATF=y
> CONFIG_CMD_GPT=y
> +CONFIG_CMD_I2C=y
> CONFIG_CMD_MMC=y
> CONFIG_CMD_USB=y
> # CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_PMIC=y
> +CONFIG_CMD_REGULATOR=y
> # CONFIG_SPL_DOS_PARTITION is not set
> CONFIG_SPL_OF_CONTROL=y
> CONFIG_OF_LIVE=y
> @@ -60,8 +63,9 @@ CONFIG_ETH_DESIGNWARE=y
> CONFIG_GMAC_ROCKCHIP=y
> CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
> -CONFIG_REGULATOR_PWM=y
> -CONFIG_DM_REGULATOR_GPIO=y
> +CONFIG_DM_PMIC=y
> +CONFIG_PMIC_RK8XX=y
> +CONFIG_REGULATOR_RK8XX=y
> CONFIG_PWM_ROCKCHIP=y
> CONFIG_SPL_RAM=y
> CONFIG_BAUDRATE=1500000
> diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
> index d24563a504..c03aa2a4c1 100644
> --- a/configs/rock-3a-rk3568_defconfig
> +++ b/configs/rock-3a-rk3568_defconfig
> @@ -41,6 +41,8 @@ CONFIG_CMD_I2C=y
> CONFIG_CMD_MMC=y
> CONFIG_CMD_USB=y
> # CONFIG_CMD_SETEXPR is not set
> +CONFIG_CMD_PMIC=y
> +CONFIG_CMD_REGULATOR=y
> # CONFIG_SPL_DOS_PARTITION is not set
> CONFIG_SPL_OF_CONTROL=y
> CONFIG_OF_LIVE=y
> @@ -64,7 +66,6 @@ CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
> CONFIG_DM_PMIC=y
> CONFIG_PMIC_RK8XX=y
> CONFIG_SPL_PMIC_RK8XX=y
> -CONFIG_REGULATOR_PWM=y
> CONFIG_REGULATOR_RK8XX=y
> CONFIG_PWM_ROCKCHIP=y
> CONFIG_SPL_RAM=y
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb
2023-04-20 9:56 ` [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb FUKAUMI Naoki
@ 2023-04-20 10:08 ` Kever Yang
2023-04-20 10:43 ` Jonas Karlman
1 sibling, 0 replies; 14+ messages in thread
From: Kever Yang @ 2023-04-20 10:08 UTC (permalink / raw)
To: FUKAUMI Naoki, u-boot; +Cc: sjg, philipp.tomsich
On 2023/4/20 17:56, FUKAUMI Naoki wrote:
> enable regulators for usb host function
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ++++
> arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 ++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> index 4e79173833..d183e93575 100644
> --- a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> +++ b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> @@ -16,3 +16,7 @@
> bootph-all;
> status = "okay";
> };
> +
> +&vcc5v0_usb30 {
> + regulator-boot-on;
> +};
> diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> index 9ef1e84770..b7b18e131a 100644
> --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> @@ -26,3 +26,11 @@
> bootph-all;
> status = "okay";
> };
> +
> +&vcc5v0_usb_host {
> + regulator-boot-on;
> +};
> +
> +&vcc5v0_usb_hub {
> + regulator-boot-on;
> +};
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 1/3] configs: rockchip: rock-3a: make usb host work
2023-04-20 9:56 [PATCH 1/3] configs: rockchip: rock-3a: make usb host work FUKAUMI Naoki
` (2 preceding siblings ...)
2023-04-20 10:07 ` [PATCH 1/3] configs: rockchip: rock-3a: make usb host work Kever Yang
@ 2023-04-20 10:37 ` Jonas Karlman
2023-04-20 12:00 ` [PATCH v2 1/4] " FUKAUMI Naoki
4 siblings, 0 replies; 14+ messages in thread
From: Jonas Karlman @ 2023-04-20 10:37 UTC (permalink / raw)
To: FUKAUMI Naoki, kever.yang; +Cc: sjg, philipp.tomsich, u-boot
On 2023-04-20 11:56, FUKAUMI Naoki wrote:
> add support for USB host function on ROCK 3A
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> configs/rock-3a-rk3568_defconfig | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
> index e753832183..d24563a504 100644
> --- a/configs/rock-3a-rk3568_defconfig
> +++ b/configs/rock-3a-rk3568_defconfig
> @@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
> CONFIG_CMD_GPT=y
> CONFIG_CMD_I2C=y
> CONFIG_CMD_MMC=y
> +CONFIG_CMD_USB=y
> # CONFIG_CMD_SETEXPR is not set
> # CONFIG_SPL_DOS_PARTITION is not set
> CONFIG_SPL_OF_CONTROL=y
> @@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
> CONFIG_MMC_SDHCI_ROCKCHIP=y
> CONFIG_ETH_DESIGNWARE=y
> CONFIG_GMAC_ROCKCHIP=y
> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
> CONFIG_DM_PMIC=y
> CONFIG_PMIC_RK8XX=y
> CONFIG_SPL_PMIC_RK8XX=y
> @@ -69,5 +72,14 @@ CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> +CONFIG_USB=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_XHCI_DWC3=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_EHCI_GENERIC=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_GENERIC=y
> +CONFIG_USB_DWC3=y
> +CONFIG_USB_DWC3_GENERIC=y
The generic dwc3 driver is not used by rk35xx and does not need to be enabled.
Regards,
Jonas
> # CONFIG_BINMAN_FDT is not set
> CONFIG_ERRNO_STR=y
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb
2023-04-20 9:56 ` [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb FUKAUMI Naoki
2023-04-20 10:08 ` Kever Yang
@ 2023-04-20 10:43 ` Jonas Karlman
1 sibling, 0 replies; 14+ messages in thread
From: Jonas Karlman @ 2023-04-20 10:43 UTC (permalink / raw)
To: FUKAUMI Naoki, kever.yang; +Cc: sjg, philipp.tomsich, u-boot
On 2023-04-20 11:56, FUKAUMI Naoki wrote:
> enable regulators for usb host function
This is not needed once [1] and related pending patches lands.
Will adjust my pending usb+spinor series at [2], on top of your series
before sending it :-)
[1] https://patchwork.ozlabs.org/project/uboot/patch/20230419134014.128461-3-eugen.hristev@collabora.com/
[2] https://github.com/Kwiboo/u-boot-rockchip/commits/rk3568-usb-spi-v1
Regards,
Jonas
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
> arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ++++
> arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 ++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> index 4e79173833..d183e93575 100644
> --- a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> +++ b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
> @@ -16,3 +16,7 @@
> bootph-all;
> status = "okay";
> };
> +
> +&vcc5v0_usb30 {
> + regulator-boot-on;
> +};
> diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> index 9ef1e84770..b7b18e131a 100644
> --- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> +++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
> @@ -26,3 +26,11 @@
> bootph-all;
> status = "okay";
> };
> +
> +&vcc5v0_usb_host {
> + regulator-boot-on;
> +};
> +
> +&vcc5v0_usb_hub {
> + regulator-boot-on;
> +};
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v2 1/4] configs: rockchip: rock-3a: make usb host work
2023-04-20 9:56 [PATCH 1/3] configs: rockchip: rock-3a: make usb host work FUKAUMI Naoki
` (3 preceding siblings ...)
2023-04-20 10:37 ` Jonas Karlman
@ 2023-04-20 12:00 ` FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 2/4] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
` (3 more replies)
4 siblings, 4 replies; 14+ messages in thread
From: FUKAUMI Naoki @ 2023-04-20 12:00 UTC (permalink / raw)
To: sjg, philipp.tomsich, kever.yang, gajjar04akash, jagan, jonas
Cc: u-boot, FUKAUMI Naoki
add support for USB host function on ROCK 3A
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
v2:
- drop CONFIG_USB_DWC3_GENERIC
configs/rock-3a-rk3568_defconfig | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
index e753832183..16a8b6092c 100644
--- a/configs/rock-3a-rk3568_defconfig
+++ b/configs/rock-3a-rk3568_defconfig
@@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
CONFIG_CMD_GPT=y
CONFIG_CMD_I2C=y
CONFIG_CMD_MMC=y
+CONFIG_CMD_USB=y
# CONFIG_CMD_SETEXPR is not set
# CONFIG_SPL_DOS_PARTITION is not set
CONFIG_SPL_OF_CONTROL=y
@@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
CONFIG_MMC_SDHCI_ROCKCHIP=y
CONFIG_ETH_DESIGNWARE=y
CONFIG_GMAC_ROCKCHIP=y
+CONFIG_PHY_ROCKCHIP_INNO_USB2=y
+CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
CONFIG_DM_PMIC=y
CONFIG_PMIC_RK8XX=y
CONFIG_SPL_PMIC_RK8XX=y
@@ -69,5 +72,13 @@ CONFIG_BAUDRATE=1500000
CONFIG_DEBUG_UART_SHIFT=2
CONFIG_SYS_NS16550_MEM32=y
CONFIG_SYSRESET=y
+CONFIG_USB=y
+CONFIG_USB_XHCI_HCD=y
+CONFIG_USB_XHCI_DWC3=y
+CONFIG_USB_EHCI_HCD=y
+CONFIG_USB_EHCI_GENERIC=y
+CONFIG_USB_OHCI_HCD=y
+CONFIG_USB_OHCI_GENERIC=y
+CONFIG_USB_DWC3=y
# CONFIG_BINMAN_FDT is not set
CONFIG_ERRNO_STR=y
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 2/4] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator
2023-04-20 12:00 ` [PATCH v2 1/4] " FUKAUMI Naoki
@ 2023-04-20 12:00 ` FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 3/4] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb FUKAUMI Naoki
` (2 subsequent siblings)
3 siblings, 0 replies; 14+ messages in thread
From: FUKAUMI Naoki @ 2023-04-20 12:00 UTC (permalink / raw)
To: sjg, philipp.tomsich, kever.yang, gajjar04akash, jagan, jonas
Cc: u-boot, FUKAUMI Naoki
enable commands for i2c/pmic/regulator and relevant configs.
also drop configs for unused regulators.
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
---
v2:
- collect R-b
configs/radxa-cm3-io-rk3566_defconfig | 8 ++++++--
configs/rock-3a-rk3568_defconfig | 3 ++-
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/configs/radxa-cm3-io-rk3566_defconfig b/configs/radxa-cm3-io-rk3566_defconfig
index 2100cf2cb2..9b99181714 100644
--- a/configs/radxa-cm3-io-rk3566_defconfig
+++ b/configs/radxa-cm3-io-rk3566_defconfig
@@ -37,9 +37,12 @@ CONFIG_SPL_BSS_MAX_SIZE=0x4000
CONFIG_SPL_STACK_R=y
CONFIG_SPL_ATF=y
CONFIG_CMD_GPT=y
+CONFIG_CMD_I2C=y
CONFIG_CMD_MMC=y
CONFIG_CMD_USB=y
# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
# CONFIG_SPL_DOS_PARTITION is not set
CONFIG_SPL_OF_CONTROL=y
CONFIG_OF_LIVE=y
@@ -60,8 +63,9 @@ CONFIG_ETH_DESIGNWARE=y
CONFIG_GMAC_ROCKCHIP=y
CONFIG_PHY_ROCKCHIP_INNO_USB2=y
CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
-CONFIG_REGULATOR_PWM=y
-CONFIG_DM_REGULATOR_GPIO=y
+CONFIG_DM_PMIC=y
+CONFIG_PMIC_RK8XX=y
+CONFIG_REGULATOR_RK8XX=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_SPL_RAM=y
CONFIG_BAUDRATE=1500000
diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
index 16a8b6092c..92562026a7 100644
--- a/configs/rock-3a-rk3568_defconfig
+++ b/configs/rock-3a-rk3568_defconfig
@@ -41,6 +41,8 @@ CONFIG_CMD_I2C=y
CONFIG_CMD_MMC=y
CONFIG_CMD_USB=y
# CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_PMIC=y
+CONFIG_CMD_REGULATOR=y
# CONFIG_SPL_DOS_PARTITION is not set
CONFIG_SPL_OF_CONTROL=y
CONFIG_OF_LIVE=y
@@ -64,7 +66,6 @@ CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
CONFIG_DM_PMIC=y
CONFIG_PMIC_RK8XX=y
CONFIG_SPL_PMIC_RK8XX=y
-CONFIG_REGULATOR_PWM=y
CONFIG_REGULATOR_RK8XX=y
CONFIG_PWM_ROCKCHIP=y
CONFIG_SPL_RAM=y
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 3/4] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb
2023-04-20 12:00 ` [PATCH v2 1/4] " FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 2/4] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
@ 2023-04-20 12:00 ` FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC FUKAUMI Naoki
2023-04-21 8:02 ` [PATCH v2 1/4] configs: rockchip: rock-3a: make usb host work Kever Yang
3 siblings, 0 replies; 14+ messages in thread
From: FUKAUMI Naoki @ 2023-04-20 12:00 UTC (permalink / raw)
To: sjg, philipp.tomsich, kever.yang, gajjar04akash, jagan, jonas
Cc: u-boot, FUKAUMI Naoki
enable regulators for usb host function
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
---
v2:
- collect R-b
arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi | 4 ++++
arch/arm/dts/rk3568-rock-3a-u-boot.dtsi | 8 ++++++++
2 files changed, 12 insertions(+)
diff --git a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
index 4e79173833..d183e93575 100644
--- a/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
+++ b/arch/arm/dts/rk3566-radxa-cm3-io-u-boot.dtsi
@@ -16,3 +16,7 @@
bootph-all;
status = "okay";
};
+
+&vcc5v0_usb30 {
+ regulator-boot-on;
+};
diff --git a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
index 9ef1e84770..b7b18e131a 100644
--- a/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
+++ b/arch/arm/dts/rk3568-rock-3a-u-boot.dtsi
@@ -26,3 +26,11 @@
bootph-all;
status = "okay";
};
+
+&vcc5v0_usb_host {
+ regulator-boot-on;
+};
+
+&vcc5v0_usb_hub {
+ regulator-boot-on;
+};
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC
2023-04-20 12:00 ` [PATCH v2 1/4] " FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 2/4] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 3/4] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb FUKAUMI Naoki
@ 2023-04-20 12:00 ` FUKAUMI Naoki
2023-04-21 8:03 ` Kever Yang
2023-04-21 8:02 ` [PATCH v2 1/4] configs: rockchip: rock-3a: make usb host work Kever Yang
3 siblings, 1 reply; 14+ messages in thread
From: FUKAUMI Naoki @ 2023-04-20 12:00 UTC (permalink / raw)
To: sjg, philipp.tomsich, kever.yang, gajjar04akash, jagan, jonas
Cc: u-boot, FUKAUMI Naoki
it's not used by rk35xx
Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
v2:
- new patch
configs/radxa-cm3-io-rk3566_defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/configs/radxa-cm3-io-rk3566_defconfig b/configs/radxa-cm3-io-rk3566_defconfig
index 9b99181714..1df9cab79d 100644
--- a/configs/radxa-cm3-io-rk3566_defconfig
+++ b/configs/radxa-cm3-io-rk3566_defconfig
@@ -77,5 +77,4 @@ CONFIG_USB_XHCI_DWC3=y
CONFIG_USB_EHCI_HCD=y
CONFIG_USB_EHCI_GENERIC=y
CONFIG_USB_DWC3=y
-CONFIG_USB_DWC3_GENERIC=y
CONFIG_ERRNO_STR=y
--
2.39.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v2 1/4] configs: rockchip: rock-3a: make usb host work
2023-04-20 12:00 ` [PATCH v2 1/4] " FUKAUMI Naoki
` (2 preceding siblings ...)
2023-04-20 12:00 ` [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC FUKAUMI Naoki
@ 2023-04-21 8:02 ` Kever Yang
3 siblings, 0 replies; 14+ messages in thread
From: Kever Yang @ 2023-04-21 8:02 UTC (permalink / raw)
To: FUKAUMI Naoki, sjg, philipp.tomsich, gajjar04akash, jagan, jonas; +Cc: u-boot
On 2023/4/20 20:00, FUKAUMI Naoki wrote:
> add support for USB host function on ROCK 3A
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> v2:
> - drop CONFIG_USB_DWC3_GENERIC
>
> configs/rock-3a-rk3568_defconfig | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/configs/rock-3a-rk3568_defconfig b/configs/rock-3a-rk3568_defconfig
> index e753832183..16a8b6092c 100644
> --- a/configs/rock-3a-rk3568_defconfig
> +++ b/configs/rock-3a-rk3568_defconfig
> @@ -39,6 +39,7 @@ CONFIG_SPL_ATF=y
> CONFIG_CMD_GPT=y
> CONFIG_CMD_I2C=y
> CONFIG_CMD_MMC=y
> +CONFIG_CMD_USB=y
> # CONFIG_CMD_SETEXPR is not set
> # CONFIG_SPL_DOS_PARTITION is not set
> CONFIG_SPL_OF_CONTROL=y
> @@ -58,6 +59,8 @@ CONFIG_MMC_SDHCI_SDMA=y
> CONFIG_MMC_SDHCI_ROCKCHIP=y
> CONFIG_ETH_DESIGNWARE=y
> CONFIG_GMAC_ROCKCHIP=y
> +CONFIG_PHY_ROCKCHIP_INNO_USB2=y
> +CONFIG_PHY_ROCKCHIP_NANENG_COMBOPHY=y
> CONFIG_DM_PMIC=y
> CONFIG_PMIC_RK8XX=y
> CONFIG_SPL_PMIC_RK8XX=y
> @@ -69,5 +72,13 @@ CONFIG_BAUDRATE=1500000
> CONFIG_DEBUG_UART_SHIFT=2
> CONFIG_SYS_NS16550_MEM32=y
> CONFIG_SYSRESET=y
> +CONFIG_USB=y
> +CONFIG_USB_XHCI_HCD=y
> +CONFIG_USB_XHCI_DWC3=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_EHCI_GENERIC=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_GENERIC=y
> +CONFIG_USB_DWC3=y
> # CONFIG_BINMAN_FDT is not set
> CONFIG_ERRNO_STR=y
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC
2023-04-20 12:00 ` [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC FUKAUMI Naoki
@ 2023-04-21 8:03 ` Kever Yang
0 siblings, 0 replies; 14+ messages in thread
From: Kever Yang @ 2023-04-21 8:03 UTC (permalink / raw)
To: FUKAUMI Naoki, sjg, philipp.tomsich, gajjar04akash, jagan, jonas; +Cc: u-boot
On 2023/4/20 20:00, FUKAUMI Naoki wrote:
> it's not used by rk35xx
>
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
> v2:
> - new patch
>
> configs/radxa-cm3-io-rk3566_defconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/configs/radxa-cm3-io-rk3566_defconfig b/configs/radxa-cm3-io-rk3566_defconfig
> index 9b99181714..1df9cab79d 100644
> --- a/configs/radxa-cm3-io-rk3566_defconfig
> +++ b/configs/radxa-cm3-io-rk3566_defconfig
> @@ -77,5 +77,4 @@ CONFIG_USB_XHCI_DWC3=y
> CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_EHCI_GENERIC=y
> CONFIG_USB_DWC3=y
> -CONFIG_USB_DWC3_GENERIC=y
> CONFIG_ERRNO_STR=y
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2023-04-21 8:03 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-20 9:56 [PATCH 1/3] configs: rockchip: rock-3a: make usb host work FUKAUMI Naoki
2023-04-20 9:56 ` [PATCH 2/3] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
2023-04-20 10:08 ` Kever Yang
2023-04-20 9:56 ` [PATCH 3/3] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb FUKAUMI Naoki
2023-04-20 10:08 ` Kever Yang
2023-04-20 10:43 ` Jonas Karlman
2023-04-20 10:07 ` [PATCH 1/3] configs: rockchip: rock-3a: make usb host work Kever Yang
2023-04-20 10:37 ` Jonas Karlman
2023-04-20 12:00 ` [PATCH v2 1/4] " FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 2/4] configs: rockchip: radxa-cm3-io, rock-3a: enable commands for i2c/pmic/regulator FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 3/4] arm: dts: rockchip: radxa-cm3-io, rock-3a: enable regulators for usb FUKAUMI Naoki
2023-04-20 12:00 ` [PATCH v2 4/4] configs: rockchip: radxa-cm3-io: drop CONFIG_USB_DWC3_GENERIC FUKAUMI Naoki
2023-04-21 8:03 ` Kever Yang
2023-04-21 8:02 ` [PATCH v2 1/4] configs: rockchip: rock-3a: make usb host work Kever Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox