From: Fabio Estevam <festevam@gmail.com>
To: sbabic@denx.de
Cc: eduard@lionizers.com, u-boot@lists.denx.de,
Fabio Estevam <festevam@denx.de>, Tom Rini <trini@konsulko.com>
Subject: [PATCH v5 14/14] smegw01: Convert CFG_EXTRA_ENV_SETTINGS to an env file
Date: Wed, 26 Apr 2023 13:05:01 -0300 [thread overview]
Message-ID: <20230426160501.1199085-14-festevam@gmail.com> (raw)
In-Reply-To: <20230426160501.1199085-1-festevam@gmail.com>
From: Fabio Estevam <festevam@denx.de>
Currently, it is recommended to move from CFG_EXTRA_ENV_SETTINGS to
an env file, so do the conversion.
Suggested-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
Changes since v4:
- Also add SETUP_BOOT_MENU into the .env file (Tom).
Cc: Tom Rini <trini@konsulko.com>
board/storopack/smegw01/smegw01.env | 89 +++++++++++++++++++++++++++++
include/configs/smegw01.h | 68 ----------------------
2 files changed, 89 insertions(+), 68 deletions(-)
create mode 100644 board/storopack/smegw01/smegw01.env
diff --git a/board/storopack/smegw01/smegw01.env b/board/storopack/smegw01/smegw01.env
new file mode 100644
index 000000000000..25bc7cdbd28b
--- /dev/null
+++ b/board/storopack/smegw01/smegw01.env
@@ -0,0 +1,89 @@
+// SPDX-License-Identifier: GPL-2.0+
+#ifdef CONFIG_SYS_BOOT_LOCKED
+#define SETUP_BOOT_MENU setup_boot_menu=setenv bootmenu_0 eMMC=run bootcmd
+#else
+#define SETUP_BOOT_MENU setup_boot_menu= \
+ if test "${mmcdev}" = 1; then \
+ setenv emmc_priority 0; \
+ setenv sd_priority 1; \
+ else setenv emmc_priority 1; \
+ setenv sd_priority 0; \
+ fi; \
+ setenv bootmenu_${emmc_priority} eMMC=run boot_emmc; \
+ setenv bootmenu_${sd_priority} SD=run boot_sd;
+#endif
+
+altbootcmd=
+ echo Performing rollback...;
+ if test "${mmcpart_committed}" = 1; then
+ setenv mmcpart 2;
+ setenv mmcpart_committed 2;
+ else
+ setenv mmcpart 1;
+ setenv mmcpart_committed 1;
+ fi;
+ setenv bootcount 0;
+ setenv upgrade_available;
+ setenv ustate 3;
+ saveenv;
+ run bootcmd;
+boot_emmc=setenv mmcdev_wanted 1; run persist_mmcdev; run bootcmd;
+boot_sd=setenv mmcdev_wanted 0; run persist_mmcdev; run bootcmd;
+bootcmd=run finduuid; run distro_bootcmd
+bootdelay=2
+bootlimit=3
+bootm_size=0x10000000
+commit_mmc=
+ if test "${ustate}" = 1 -a "${mmcpart}" != "${mmcpart_committed}"; then
+ setenv mmcpart_committed ${mmcpart};
+ saveenv;
+ fi;
+console=ttymxc0
+fdt_addr=0x83000000
+fdtfile=imx7d-smegw01.dtb
+fit_addr=0x88000000
+image=fitImage
+loadaddr=0x80800000
+loadbootpart=mmc partconf 1 boot_part
+loadimage=load mmc ${mmcdev}:${gpt_partition_entry} ${fit_addr} boot/${image}
+loadpart=gpt setenv mmc ${mmcdev} rootfs-${mmcpart_committed}
+mmcargs=
+ setenv bootargs console=${console},${baudrate} root=/dev/mmcblk${mmcdev}p${gpt_partition_entry} rootwait rw SM_ROOT_DEV=${mmcdev} SM_ROOT_PART=${gpt_partition_entry} SM_BOOT_PART=${boot_part}
+mmcboot=
+ echo Booting...;
+ echo mmcdev: ${mmcdev};
+ run commit_mmc;
+ echo mmcpart: ${mmcpart_committed};
+ run loadpart;
+ echo gptpart: ${gpt_partition_entry};
+ run loadbootpart;
+ if run loadimage; then
+ ;
+ else
+ run altbootcmd;
+ fi;
+ run mmcargs;
+ if bootm ${fit_addr}; then
+ ;
+ else
+ run altbootcmd;
+ fi;
+mmcdev=1
+mmcpart=1
+mmcpart_committed=1
+persist_mmcdev=
+ if test "${mmcdev}" != "${mmcdev_wanted}"; then
+ setenv mmcdev "${mmcdev_wanted}";
+ saveenv;
+ fi;
+setup_boot_menu=
+ if test "${mmcdev}" = 1; then
+ setenv emmc_priority 0;
+ setenv sd_priority 1;
+ else
+ setenv emmc_priority 1;
+ setenv sd_priority 0;
+ fi;
+ setenv bootmenu_${emmc_priority} eMMC=run boot_emmc;
+ setenv bootmenu_${sd_priority} SD=run boot_sd;
+SETUP_BOOT_MENU
diff --git a/include/configs/smegw01.h b/include/configs/smegw01.h
index 6f373973ab84..0aa25f9e2eaa 100644
--- a/include/configs/smegw01.h
+++ b/include/configs/smegw01.h
@@ -24,19 +24,8 @@
#ifdef CONFIG_SYS_BOOT_LOCKED
#define EXTRA_ENV_FLAGS
-#define SETUP_BOOT_MENU "setup_boot_menu=setenv bootmenu_0 eMMC=run bootcmd\0"
#else
#define EXTRA_ENV_FLAGS "mmcdev:dw,"
-#define SETUP_BOOT_MENU "setup_boot_menu=" \
- "if test \"${mmcdev}\" = 1; then " \
- "setenv emmc_priority 0;" \
- "setenv sd_priority 1;" \
- "else " \
- "setenv emmc_priority 1;" \
- "setenv sd_priority 0;" \
- "fi;" \
- "setenv bootmenu_${emmc_priority} eMMC=run boot_emmc;" \
- "setenv bootmenu_${sd_priority} SD=run boot_sd;\0"
#endif
#define CFG_ENV_FLAGS_LIST_STATIC \
@@ -48,63 +37,6 @@
"upgrade_available:dw," \
EXTRA_ENV_FLAGS
-#define CFG_EXTRA_ENV_SETTINGS \
- "image=fitImage\0" \
- "console=ttymxc0\0" \
- "fdtfile=imx7d-smegw01.dtb\0" \
- "fdt_addr=0x83000000\0" \
- "bootm_size=0x10000000\0" \
- "mmcdev=1\0" \
- "mmcpart=1\0" \
- "mmcpart_committed=1\0" \
- "mmcargs=setenv bootargs console=${console},${baudrate} " \
- "root=/dev/mmcblk${mmcdev}p${gpt_partition_entry} rootwait rw " \
- __stringify(EXTRA_BOOTPARAMS) " SM_ROOT_DEV=${mmcdev} SM_ROOT_PART=${gpt_partition_entry} SM_BOOT_PART=${boot_part}\0" \
- "commit_mmc=if test \"${ustate}\" = 1 -a \"${mmcpart}\" != \"${mmcpart_committed}\"; then " \
- "setenv mmcpart_committed ${mmcpart};" \
- "saveenv;" \
- "fi;\0" \
- "bootlimit=3\0" \
- "fit_addr=0x88000000\0" \
- "loadimage=load mmc ${mmcdev}:${gpt_partition_entry} ${fit_addr} boot/${image}\0" \
- "loadpart=gpt setenv mmc ${mmcdev} rootfs-${mmcpart_committed}\0" \
- "loadbootpart=mmc partconf 1 boot_part\0" \
- "boot_sd=setenv mmcdev_wanted 0; run persist_mmcdev; run bootcmd;\0" \
- "boot_emmc=setenv mmcdev_wanted 1; run persist_mmcdev; run bootcmd;\0" \
- "persist_mmcdev=" \
- "if test \"${mmcdev}\" != \"${mmcdev_wanted}\"; then " \
- "setenv mmcdev \"${mmcdev_wanted}\";" \
- "saveenv;" \
- "fi;\0" \
- "mmcboot=echo Booting...; " \
- "echo mmcdev: ${mmcdev}; " \
- "run commit_mmc; " \
- "echo mmcpart: ${mmcpart_committed}; " \
- "run loadpart; " \
- "echo gptpart: ${gpt_partition_entry}; " \
- "run loadbootpart; " \
- "if run loadimage; then " \
- "; " \
- "else " \
- "run altbootcmd; " \
- "fi; " \
- "run mmcargs; " \
- "if bootm ${fit_addr}; then " \
- "; " \
- "else " \
- "run altbootcmd; " \
- "fi;\0" \
- "altbootcmd=echo Performing rollback...; " \
- "if test \"${mmcpart_committed}\" = 1; then " \
- "setenv mmcpart 2; " \
- "setenv mmcpart_committed 2;" \
- "else " \
- "setenv mmcpart 1; " \
- "setenv mmcpart_committed 1;" \
- "fi; setenv bootcount 0; setenv upgrade_available; setenv ustate 3; saveenv; " \
- "run bootcmd;\0" \
- SETUP_BOOT_MENU
-
/* Physical Memory Map */
#define PHYS_SDRAM MMDC0_ARB_BASE_ADDR
--
2.34.1
next prev parent reply other threads:[~2023-04-26 16:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 16:04 [PATCH v5 01/14] smegw01: Enable setting additional boot params Fabio Estevam
2023-04-26 16:04 ` [PATCH v5 02/14] smegw01: Select CONFIG_CMD_SQUASHFS Fabio Estevam
2023-05-02 12:46 ` sbabic
2023-04-26 16:04 ` [PATCH v5 03/14] smegw01: Select bootcount support Fabio Estevam
2023-05-02 12:46 ` sbabic
2023-04-26 16:04 ` [PATCH v5 04/14] smegw01: Add altbootcmd Fabio Estevam
2023-05-02 12:47 ` sbabic
2023-04-26 16:04 ` [PATCH v5 05/14] smegw01: Run altbootcmd in the case of failure Fabio Estevam
2023-05-02 12:47 ` sbabic
2023-04-26 16:04 ` [PATCH v5 06/14] smegw01: Only commit to new partition if update was successful Fabio Estevam
2023-05-02 12:47 ` sbabic
2023-04-26 16:04 ` [PATCH v5 07/14] smegw01: Enable EMMC boot from multiple partitions Fabio Estevam
2023-05-02 12:47 ` sbabic
2023-04-26 16:04 ` [PATCH v5 08/14] smegw01: Change default boot device to eMMC Fabio Estevam
2023-05-02 12:46 ` sbabic
2023-04-26 16:04 ` [PATCH v5 09/14] smegw01: Switch to fitImage Fabio Estevam
2023-05-02 12:47 ` sbabic
2023-04-26 16:04 ` [PATCH v5 10/14] smegw01: Add lockdown U-Boot env support Fabio Estevam
2023-05-02 12:47 ` sbabic
2023-04-26 16:04 ` [PATCH v5 11/14] smegw01: Read the second MAC address Fabio Estevam
2023-05-02 12:46 ` sbabic
2023-04-26 16:04 ` [PATCH v5 12/14] smegw01: Disable additional boot menu options Fabio Estevam
2023-05-02 12:47 ` sbabic
2023-04-26 16:05 ` [PATCH v5 13/14] smegw01: Fix fallback to altbootcmd Fabio Estevam
2023-05-02 12:46 ` sbabic
2023-04-26 16:05 ` Fabio Estevam [this message]
2023-04-26 17:31 ` [PATCH v5 14/14] smegw01: Convert CFG_EXTRA_ENV_SETTINGS to an env file Tom Rini
2023-05-02 12:47 ` sbabic
2023-05-02 12:47 ` [PATCH v5 01/14] smegw01: Enable setting additional boot params sbabic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230426160501.1199085-14-festevam@gmail.com \
--to=festevam@gmail.com \
--cc=eduard@lionizers.com \
--cc=festevam@denx.de \
--cc=sbabic@denx.de \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox