From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DBCC4C77B73 for ; Thu, 27 Apr 2023 15:23:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6C590862A7; Thu, 27 Apr 2023 17:23:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1682609000; bh=GgEMq5Gaz82mcEdsZuawLTO5MGKQWod15D3tWA3st3s=; h=Date:From:To:Cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=V5JouWsXcvov1wyXds2aRZQCg9blHzly6t/GIbVVAapWrr++CZgmMylZvZan2vn1C hjTWijmHFmMOvdqTXyTx/bqFjSQSU2+3e8FcTrbe6Z450Q292eqxE3oWvUaBrd75YC IS5+7rkvnrpIngO+ZXRgbM0W0owLmEVMqP8FEsw6Y3QIxURydfiu38UyVkFm3DOn2/ mXxCh5NZrhpg1C7KmEgk7Fli1XSZ57UGcvMR2Af3I0ndGjYK7/SwKI6mDunGp/i/t9 1287x8aJUuwRG5jN2xOgNYC8oGfZRbah184JTOqIz6uF1MrUwyqrfE8+j3H/r3wJEz SCbgH2VBMMKsA== Received: from wsk (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 6C5C286290; Thu, 27 Apr 2023 17:23:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1682608998; bh=GgEMq5Gaz82mcEdsZuawLTO5MGKQWod15D3tWA3st3s=; h=Date:From:To:Cc:Subject:From; b=nrjfx1aOKCNMKcQ8Dge0xq4cIlWn6NlDhGXgpAzJ9sWMdGahhQCgFxr/l3pe+qgVi TipvdMg+tTL1xWaUY0NCU8olalWKQhxlnJ+UZw48UmRiEZMc1rkpOIixhJMJxlmxTC UWsDR+6z6VTMdo8/nHr/+reMzM2E2bMUPUljaGv+bkLAGPfjKIkEuDNdJzsJ5ApwaL XRvAw0JZVvHAf/F8KhZ1Eirscjgpudh4KeSIbvZiR7YS7Wqw4nG59xXADGYPF7+SLN 0nrNvWjTHzXSnaKyvYqdeP2gfqXHweoWP+LaVmB/Qk2UHfa41WPV9ntwD0WJ/ufeoj womiRDWOTj1pQ== Date: Thu, 27 Apr 2023 17:23:11 +0200 From: Lukasz Majewski To: Simon Glass Cc: , Tom Rini , Fabio Estevam , Stefano Babic Subject: Question regarding CONFIG_SPL_OF_PLATDATA_INST usage Message-ID: <20230427172311.0c78f13f@wsk> Organization: denx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/2917V+PrKtphjmJOzknh.U_"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --Sig_/2917V+PrKtphjmJOzknh.U_ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Simon, I'm trying to convert imx28 based XEA board to use CONFIG_DM_SERIAL. This board uses SPL_OF_PLATDATA to have as small SPL as possible. It looks like the 'duart' description/driver is properly instantiated, but serial console is configured too early -> apparently serial_find_console_or_panic() from serial_init() at serial-uclass.c is called before DM is setup in SPL. To fix this problem - in the commit (SHA1: 5a1b25c2011) the CONFIG_SPL_OF_PLATDATA_INST has been introduced; without it (after commit SHA1: 1e9ced28f18ed75bef96df08e47baad27dd51829) uclass_get() returns -EDEADLOCK. Grepping the sources show that only two "boards" use it: 1. arch/x86/cpu/apollolake/Kconfig -> TPL_OF_PLATDATA_INST=20 (configs/chromebook_coral_defconfig and corresponding ./arch/x86/dts/chromebook_coral.dts) 2. configs/sandbox_spl_defconfig -> CONFIG_SPL_OF_PLATDATA_INST=3Dy I would like to ask if: - Anybody managed to use CONFIG_SPL_OF_PLATDATA_INST=3Dy on real HW? - Is it on purpose, that dtoc tool is not extracting structures definitions from *.c files ?=20 - Is the "coral" board (from point 1 above) using any extra coral*-u-boot.dtsi to specify which parts of dts shall be included to the in-TPL DTS? Or is it just using full-blown DTS support ins TPL? I'm using cutting-edge mainline u-boot - SHA1: 6a11fdf0536e02ac9cd4a3da0535a271c694715f Thanks in advance for any help. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/2917V+PrKtphjmJOzknh.U_ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmRKk18ACgkQAR8vZIA0 zr19yAgA2SHNV04LM9WDeah5IxwAZTAzsshgzT3ErsjYfvMIWiWucCxJ6t6HcPhe RA+E7+Zd4hNQ7sFjNOONx7I/9tigmL/wDW8+T8wQhda2jim19vICplhMp4VoMcEi rTrQF3oEk5rlzxoz76BdwgulwrN5RrCjGKotynhDHFom+W71Yzd7VdR54mrhAGrI duJGO0IC54O+LNIw69J20ePGZMxOLoiVl+Z7O5iLBuQfgsDSEx7TqO2xHaD9/Gel web1Wx7Q0I+c+Hj8BHYGf8RWu55HxzLM8w1VUVUMotiWpOYicL9XMoM6hK5Ixe+M NmjimkKjpJGcp9V7IWdQOf8Gzj5MbA== =w8qn -----END PGP SIGNATURE----- --Sig_/2917V+PrKtphjmJOzknh.U_--