From: Andre Przywara <andre.przywara@arm.com>
To: Samuel Holland <samuel@sholland.org>
Cc: u-boot@lists.denx.de, Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH] Kconfig: Remove an impossible condition
Date: Fri, 28 Apr 2023 01:31:54 +0100 [thread overview]
Message-ID: <20230428013154.66d486e5@slackpad.lan> (raw)
In-Reply-To: <20230122172352.1029-1-samuel@sholland.org>
On Sun, 22 Jan 2023 11:23:51 -0600
Samuel Holland <samuel@sholland.org> wrote:
> ARCH_SUNXI selects BINMAN, so the condition "!BINMAN && ARCH_SUNXI"
> is impossible to satisfy.
Indeed the generic ARCH_SUNXI entry in arch/arm/Kconfig selects
BINMAN, so that looks fine. The same seems to be true for
ARCH_ROCKCHIP, btw. Anyway, for that patch:
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Andre Przywara <andre.przywara@arm.com>
Queued for sunxi/master.
Cheers,
Andre
> ---
>
> Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Kconfig b/Kconfig
> index a75cce7e28..f810646e8a 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -459,7 +459,7 @@ config BUILD_TARGET
> default "u-boot-with-spl.kwb" if ARMADA_32BIT && SPL
> default "u-boot-elf.srec" if RCAR_GEN3
> default "u-boot.itb" if !BINMAN && SPL_LOAD_FIT && (ARCH_ROCKCHIP || \
> - ARCH_SUNXI || RISCV || ARCH_ZYNQMP)
> + RISCV || ARCH_ZYNQMP)
> default "u-boot.kwb" if (ARCH_KIRKWOOD || ARMADA_32BIT) && !SPL
> default "u-boot-with-spl.bin" if MPC85xx && !E500MC && !E5500 && !E6500 && SPL
> default "u-boot-with-spl.bin" if ARCH_AT91 && SPL_NAND_SUPPORT
prev parent reply other threads:[~2023-04-28 0:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-22 17:23 [PATCH] Kconfig: Remove an impossible condition Samuel Holland
2023-04-28 0:31 ` Andre Przywara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428013154.66d486e5@slackpad.lan \
--to=andre.przywara@arm.com \
--cc=samuel@sholland.org \
--cc=u-boot@lists.denx.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox