From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A31AC77B73 for ; Fri, 28 Apr 2023 00:34:30 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 982BA862C3; Fri, 28 Apr 2023 02:33:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id BE20C86175; Fri, 28 Apr 2023 02:33:46 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 98BE384D05 for ; Fri, 28 Apr 2023 02:33:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0B28F2F4; Thu, 27 Apr 2023 17:34:28 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4E7823F587; Thu, 27 Apr 2023 17:33:43 -0700 (PDT) Date: Fri, 28 Apr 2023 01:31:54 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Masahiro Yamada Subject: Re: [PATCH] Kconfig: Remove an impossible condition Message-ID: <20230428013154.66d486e5@slackpad.lan> In-Reply-To: <20230122172352.1029-1-samuel@sholland.org> References: <20230122172352.1029-1-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, 22 Jan 2023 11:23:51 -0600 Samuel Holland wrote: > ARCH_SUNXI selects BINMAN, so the condition "!BINMAN && ARCH_SUNXI" > is impossible to satisfy. Indeed the generic ARCH_SUNXI entry in arch/arm/Kconfig selects BINMAN, so that looks fine. The same seems to be true for ARCH_ROCKCHIP, btw. Anyway, for that patch: > Signed-off-by: Samuel Holland Acked-by: Andre Przywara Queued for sunxi/master. Cheers, Andre > --- > > Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Kconfig b/Kconfig > index a75cce7e28..f810646e8a 100644 > --- a/Kconfig > +++ b/Kconfig > @@ -459,7 +459,7 @@ config BUILD_TARGET > default "u-boot-with-spl.kwb" if ARMADA_32BIT && SPL > default "u-boot-elf.srec" if RCAR_GEN3 > default "u-boot.itb" if !BINMAN && SPL_LOAD_FIT && (ARCH_ROCKCHIP || \ > - ARCH_SUNXI || RISCV || ARCH_ZYNQMP) > + RISCV || ARCH_ZYNQMP) > default "u-boot.kwb" if (ARCH_KIRKWOOD || ARMADA_32BIT) && !SPL > default "u-boot-with-spl.bin" if MPC85xx && !E500MC && !E5500 && !E6500 && SPL > default "u-boot-with-spl.bin" if ARCH_AT91 && SPL_NAND_SUPPORT