* [PATCH] Kconfig: Remove an impossible condition
@ 2023-01-22 17:23 Samuel Holland
2023-04-28 0:31 ` Andre Przywara
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2023-01-22 17:23 UTC (permalink / raw)
To: Andre Przywara; +Cc: u-boot, Samuel Holland, Masahiro Yamada
ARCH_SUNXI selects BINMAN, so the condition "!BINMAN && ARCH_SUNXI"
is impossible to satisfy.
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Kconfig b/Kconfig
index a75cce7e28..f810646e8a 100644
--- a/Kconfig
+++ b/Kconfig
@@ -459,7 +459,7 @@ config BUILD_TARGET
default "u-boot-with-spl.kwb" if ARMADA_32BIT && SPL
default "u-boot-elf.srec" if RCAR_GEN3
default "u-boot.itb" if !BINMAN && SPL_LOAD_FIT && (ARCH_ROCKCHIP || \
- ARCH_SUNXI || RISCV || ARCH_ZYNQMP)
+ RISCV || ARCH_ZYNQMP)
default "u-boot.kwb" if (ARCH_KIRKWOOD || ARMADA_32BIT) && !SPL
default "u-boot-with-spl.bin" if MPC85xx && !E500MC && !E5500 && !E6500 && SPL
default "u-boot-with-spl.bin" if ARCH_AT91 && SPL_NAND_SUPPORT
--
2.37.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Kconfig: Remove an impossible condition
2023-01-22 17:23 [PATCH] Kconfig: Remove an impossible condition Samuel Holland
@ 2023-04-28 0:31 ` Andre Przywara
0 siblings, 0 replies; 2+ messages in thread
From: Andre Przywara @ 2023-04-28 0:31 UTC (permalink / raw)
To: Samuel Holland; +Cc: u-boot, Masahiro Yamada
On Sun, 22 Jan 2023 11:23:51 -0600
Samuel Holland <samuel@sholland.org> wrote:
> ARCH_SUNXI selects BINMAN, so the condition "!BINMAN && ARCH_SUNXI"
> is impossible to satisfy.
Indeed the generic ARCH_SUNXI entry in arch/arm/Kconfig selects
BINMAN, so that looks fine. The same seems to be true for
ARCH_ROCKCHIP, btw. Anyway, for that patch:
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Acked-by: Andre Przywara <andre.przywara@arm.com>
Queued for sunxi/master.
Cheers,
Andre
> ---
>
> Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Kconfig b/Kconfig
> index a75cce7e28..f810646e8a 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -459,7 +459,7 @@ config BUILD_TARGET
> default "u-boot-with-spl.kwb" if ARMADA_32BIT && SPL
> default "u-boot-elf.srec" if RCAR_GEN3
> default "u-boot.itb" if !BINMAN && SPL_LOAD_FIT && (ARCH_ROCKCHIP || \
> - ARCH_SUNXI || RISCV || ARCH_ZYNQMP)
> + RISCV || ARCH_ZYNQMP)
> default "u-boot.kwb" if (ARCH_KIRKWOOD || ARMADA_32BIT) && !SPL
> default "u-boot-with-spl.bin" if MPC85xx && !E500MC && !E5500 && !E6500 && SPL
> default "u-boot-with-spl.bin" if ARCH_AT91 && SPL_NAND_SUPPORT
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-28 0:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-22 17:23 [PATCH] Kconfig: Remove an impossible condition Samuel Holland
2023-04-28 0:31 ` Andre Przywara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox