From: "Marek Behún" <kabel@kernel.org>
To: Tom Rini <trini@konsulko.com>
Cc: "Simon Glass" <sjg@chromium.org>, "Pali Rohár" <pali@kernel.org>,
"U-Boot Mailing List" <u-boot@lists.denx.de>,
"Bin Meng" <bmeng.cn@gmail.com>,
"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Quentin Schulz" <quentin.schulz@theobroma-systems.com>
Subject: Re: [PATCH 27/31] Makefile: Disable LTO when building with MSYS2
Date: Fri, 28 Apr 2023 09:37:57 +0200 [thread overview]
Message-ID: <20230428093757.04f61ff7@dellmb> (raw)
In-Reply-To: <20230427173453.GH1134230@bill-the-cat>
On Thu, 27 Apr 2023 13:34:53 -0400
Tom Rini <trini@konsulko.com> wrote:
> On Thu, Apr 27, 2023 at 10:25:13AM -0600, Simon Glass wrote:
> > Hi Pali,
> >
> > On Wed, 26 Apr 2023 at 01:07, Pali Rohár <pali@kernel.org> wrote:
> > >
> > > On Tuesday 25 April 2023 19:04:10 Simon Glass wrote:
> > > > Hi Pali,
> > > >
> > > > On Tue, 25 Apr 2023 at 10:28, Pali Rohár <pali@kernel.org> wrote:
> > > > >
> > > > > On Monday 24 April 2023 17:08:32 Simon Glass wrote:
> > > > > > This creates a lot of errors of the form:
> > > > > >
> > > > > > `__stack_chk_fail' referenced in section `.text' of ...ltrans.o: defined
> > > > > > in discarded section `.text' of common/stackprot.o (symbol from plugin)
> > > > >
> > > > > This issue should be rather fixed...
> > > > >
> > > > > > Drop LTO for now.
> > > > >
> > > > > ... and until it happens is not CONFIG_LTO for disabling enough?
> > > > >
> > > > > LTO does not work for more other boards / platforms and it is just _not_
> > > > > enabled via CONFIG_LTO in those cases...
> > > >
> > > > The thing is, LTO is enabled for sandbox normally (clang and gcc). It
> > > > is just the MSYS2 platform where there are problems.
> > >
> > > So what about having CONFIG_LTO by default 'n' for CONFIG_MSYS2?
> >
> > But that would require creating a new board. I am trying to use the
> > same board, just building it in a different environment.
>
> I think we need to make CONFIG_LTO depend on CC_IS_GCC for now as it
> also doesn't work (but could be addressed) for CC_IS_CLANG.
>
It got broken? It should work at least for sandbox...
Marek
next prev parent reply other threads:[~2023-04-28 7:38 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 23:08 [PATCH 00/31] Allow building sandbox with MSYS2 Simon Glass
2023-04-24 23:08 ` [PATCH 01/31] patman: Declare the future Series memory Simon Glass
2023-04-24 23:08 ` [PATCH 02/31] u_boot_pylib: Correct name of readme Simon Glass
2023-04-24 23:08 ` [PATCH 03/31] u_boot_pylib: Make pty optional Simon Glass
2023-04-25 15:57 ` Tom Rini
2023-04-24 23:08 ` [PATCH 04/31] binman: Avoid using a symlink Simon Glass
2023-04-24 23:08 ` [PATCH 05/31] binman: Don't require a HOME directory Simon Glass
2023-04-24 23:08 ` [PATCH 06/31] pylibfdt: Allow building on Windows Simon Glass
2023-04-25 16:18 ` Pali Rohár
2023-04-24 23:08 ` [PATCH 07/31] Fix Makefile warning about parallel targets Simon Glass
2023-04-24 23:08 ` [PATCH 08/31] mkimage: Correct checking of configuration node Simon Glass
2023-04-24 23:08 ` [PATCH 09/31] Kbuild: Detect including an MSYS2 path Simon Glass
2023-04-24 23:08 ` [PATCH 10/31] sandbox: Provide a linker script for MSYS2 Simon Glass
2023-04-25 16:21 ` Pali Rohár
2023-04-25 18:01 ` Simon Glass
2023-04-25 18:11 ` Pali Rohár
2023-04-25 19:23 ` Simon Glass
2023-04-25 19:33 ` Pali Rohár
2023-04-26 0:50 ` Simon Glass
2023-04-26 7:13 ` Pali Rohár
2023-04-26 7:22 ` Pali Rohár
2023-04-24 23:08 ` [PATCH 11/31] sandbox: Provide an EFI link script for PE Simon Glass
2023-04-24 23:08 ` [PATCH 12/31] sandbox: Drop dead code from Makefile Simon Glass
2023-04-24 23:08 ` [PATCH 13/31] sandbox: Disable raw Ethernet on MSYS2 Simon Glass
2023-04-24 23:08 ` [PATCH 14/31] sandbox: Drop signal handling for MSYS2 Simon Glass
2023-04-25 1:57 ` Heinrich Schuchardt
2023-04-24 23:08 ` [PATCH 15/31] sandbox: Correct SDL.h header inclusion Simon Glass
2023-04-24 23:08 ` [PATCH 16/31] sandbox: Include errno.h in the test header Simon Glass
2023-04-24 23:08 ` [PATCH 17/31] sandbox: Allow weak symbols to be dropped Simon Glass
2023-04-25 2:33 ` Heinrich Schuchardt
2023-04-29 18:41 ` Simon Glass
2023-04-25 2:44 ` Bin Meng
2023-04-25 16:31 ` Pali Rohár
2023-04-29 18:41 ` Simon Glass
2023-04-30 9:43 ` Pali Rohár
2023-04-29 18:41 ` Simon Glass
2023-04-30 15:10 ` Bin Meng
2023-04-24 23:08 ` [PATCH 18/31] sections: Drop use of linux/types.h Simon Glass
2023-04-24 23:08 ` [PATCH 19/31] sandbox: Drop incorrect inclusion " Simon Glass
2023-04-24 23:08 ` [PATCH 20/31] sandbox: Drop inclusion of os.h in sscanf.c Simon Glass
2023-04-24 23:08 ` [PATCH 21/31] test: Avoid strange symbols in the assembler file Simon Glass
2023-04-25 2:29 ` Heinrich Schuchardt
2023-04-24 23:08 ` [PATCH 22/31] sandbox: Fix up setting of monitor_len on MSYS2 Simon Glass
2023-04-24 23:08 ` [PATCH 23/31] ctype: Avoid using a symlink Simon Glass
2023-04-24 23:08 ` [PATCH 24/31] build: Disable weak symbols for MSYS2 Simon Glass
2023-04-25 16:21 ` Pali Rohár
2023-04-29 18:41 ` Simon Glass
2023-04-24 23:08 ` [PATCH 25/31] Makefile: Disable unsupported compiler options with PE Simon Glass
2023-04-25 15:59 ` Tom Rini
2023-04-25 16:22 ` Pali Rohár
2023-04-24 23:08 ` [PATCH 26/31] Makefile: Correct the ans1_compiler rule for MSYS2 Simon Glass
2023-04-25 16:23 ` Pali Rohár
2023-04-24 23:08 ` [PATCH 27/31] Makefile: Disable LTO when building with MSYS2 Simon Glass
2023-04-25 16:27 ` Pali Rohár
2023-04-26 1:04 ` Simon Glass
2023-04-26 7:07 ` Pali Rohár
2023-04-27 16:25 ` Simon Glass
2023-04-27 16:48 ` Pali Rohár
2023-04-27 17:34 ` Tom Rini
2023-04-28 7:37 ` Marek Behún [this message]
2023-04-28 13:03 ` Tom Rini
2023-04-24 23:08 ` [PATCH 28/31] doc: Update the MSYS2 packages and versions Simon Glass
2023-04-24 23:08 ` [PATCH 29/31] doc: Show how to build sandbox for MSYS2 Simon Glass
2023-04-25 2:20 ` Heinrich Schuchardt
2023-04-25 2:54 ` Heinrich Schuchardt
2023-04-25 3:01 ` Bin Meng
2023-04-25 3:12 ` Heinrich Schuchardt
2023-04-24 23:08 ` [PATCH 30/31] Makefile: Drop unwind tables Simon Glass
2023-04-24 23:08 ` [PATCH 31/31] CI: Enable sandbox build for Windows Simon Glass
2023-04-25 2:59 ` [PATCH 00/31] Allow building sandbox with MSYS2 Heinrich Schuchardt
2023-04-25 16:04 ` Tom Rini
2023-04-25 18:01 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428093757.04f61ff7@dellmb \
--to=kabel@kernel.org \
--cc=bmeng.cn@gmail.com \
--cc=pali@kernel.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox