From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E894C77B61 for ; Fri, 28 Apr 2023 07:38:10 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5019D85FEF; Fri, 28 Apr 2023 09:38:08 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="SZnSviil"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3A7558615C; Fri, 28 Apr 2023 09:38:07 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8C33985E3D for ; Fri, 28 Apr 2023 09:38:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1D5F60AF1; Fri, 28 Apr 2023 07:38:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7915FC433D2; Fri, 28 Apr 2023 07:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682667482; bh=5EppkG46Ns9KubmzKpT5MXyVXyuSZi6zaGz2qGANMK0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=SZnSviil7IhB1pusZ03sVmr6lcyLWZiZSo9WaUVsN82STvLLyC0ng7xa4yPu5zH/e r0nn4EW1oCVsdcJVmrm4NE6JKb7IJELyqC/b02/2LIhcPpY+REKDDeJFsd6o4cPiHt W8w9Gco19Bri3U/KitVIb+zsqEtlrBFyq2Dd/BHm/Mcotjj/DTq9sYwATjmH/TJkHB 3hf/TLO2Wjrs3Y3nqr5W578xtyIuW1+dBdls8wN4GMx5Q69R4nHdar1/7vN1ceMWKS 08r116RQvYZptN3veqs+9+Wjo3Eq6KYaMCgln+T/UszsWuMYsufDvmMEV2gRkh85oN BAazsfRVYHW8Q== Date: Fri, 28 Apr 2023 09:37:57 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Tom Rini Cc: Simon Glass , Pali =?UTF-8?B?Um9ow6Fy?= , U-Boot Mailing List , Bin Meng , Heinrich Schuchardt , Masahiro Yamada , Quentin Schulz Subject: Re: [PATCH 27/31] Makefile: Disable LTO when building with MSYS2 Message-ID: <20230428093757.04f61ff7@dellmb> In-Reply-To: <20230427173453.GH1134230@bill-the-cat> References: <20230424230836.630907-1-sjg@chromium.org> <20230424230836.630907-28-sjg@chromium.org> <20230425162755.uedwxlccco7lcj3n@pali> <20230426070747.sbr3mvwwr7gw3ro7@pali> <20230427173453.GH1134230@bill-the-cat> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, 27 Apr 2023 13:34:53 -0400 Tom Rini wrote: > On Thu, Apr 27, 2023 at 10:25:13AM -0600, Simon Glass wrote: > > Hi Pali, > >=20 > > On Wed, 26 Apr 2023 at 01:07, Pali Roh=C3=A1r wrote: = =20 > > > > > > On Tuesday 25 April 2023 19:04:10 Simon Glass wrote: =20 > > > > Hi Pali, > > > > > > > > On Tue, 25 Apr 2023 at 10:28, Pali Roh=C3=A1r wro= te: =20 > > > > > > > > > > On Monday 24 April 2023 17:08:32 Simon Glass wrote: =20 > > > > > > This creates a lot of errors of the form: > > > > > > > > > > > > `__stack_chk_fail' referenced in section `.text' of ...ltrans.o= : defined > > > > > > in discarded section `.text' of common/stackprot.o (symbol f= rom plugin) =20 > > > > > > > > > > This issue should be rather fixed... > > > > > =20 > > > > > > Drop LTO for now. =20 > > > > > > > > > > ... and until it happens is not CONFIG_LTO for disabling enough? > > > > > > > > > > LTO does not work for more other boards / platforms and it is jus= t _not_ > > > > > enabled via CONFIG_LTO in those cases... =20 > > > > > > > > The thing is, LTO is enabled for sandbox normally (clang and gcc). = It > > > > is just the MSYS2 platform where there are problems. =20 > > > > > > So what about having CONFIG_LTO by default 'n' for CONFIG_MSYS2? =20 > >=20 > > But that would require creating a new board. I am trying to use the > > same board, just building it in a different environment. =20 >=20 > I think we need to make CONFIG_LTO depend on CC_IS_GCC for now as it > also doesn't work (but could be addressed) for CC_IS_CLANG. >=20 It got broken? It should work at least for sandbox... Marek