public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: sbabic@denx.de
To: Hugo Villeneuve <hugo@hugovil.com>,u-boot@lists.denx.de
Subject: [PATCH] arm: imx8m: remove unused and obsolete board_fix_fdt() in SOC context
Date: Tue,  2 May 2023 14:46:34 +0200 (CEST)	[thread overview]
Message-ID: <20230502124636.9CE3584696@phobos.denx.de> (raw)
In-Reply-To: <20230425141935.2324406-1-hugo@hugovil.com>

> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> It doesn't seem appropriate for arch/SOC to use a board-level
> functionality (CONFIG_OF_BOARD_FIXUP), because this prevents boards
> that need to do FDT fixup from using that feature.
> Also, this code is completely dead and useless (from comments by
> Rasmus Villemoes on the mailing list):
>   - No in-tree imx8m-based board seems to set CONFIG_OF_BOARD_FIXUP
>   - The nodes which that function wants to disable don't even exist in
>     the U-Boot copy of imx8mp.dtsi.
> This code was introduced in commit 35bb60787b88. It seems to be some
> random import of code from downstream NXP U-Boot, with a commit
> message that makes no sense in upstream context.
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> Acked-by: Peng Fan <peng.fan@nxp.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

      parent reply	other threads:[~2023-05-02 12:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25 14:19 [PATCH] arm: imx8m: remove unused and obsolete board_fix_fdt() in SOC context Hugo Villeneuve
2023-04-26  1:30 ` Peng Fan
2023-04-27 18:37 ` Fabio Estevam
2023-05-02 12:46 ` sbabic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230502124636.9CE3584696@phobos.denx.de \
    --to=sbabic@denx.de \
    --cc=hugo@hugovil.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox