public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Mayuresh Chitale <mchitale@ventanamicro.com>
Cc: u-boot@lists.denx.de
Subject: Re: [PATCH] pci: ecm generic: use dev_read_() interface
Date: Wed, 3 May 2023 16:34:41 -0400	[thread overview]
Message-ID: <20230503203441.GA824307@bill-the-cat> (raw)
In-Reply-To: <20230218122525.3815554-1-mchitale@ventanamicro.com>

[-- Attachment #1: Type: text/plain, Size: 789 bytes --]

On Sat, Feb 18, 2023 at 05:55:25PM +0530, Mayuresh Chitale wrote:

> Use dev_read_() api instead of the fdtdec API to fetch the host
> controller's reg property value. This is similar to the other host
> controller drivers such as Sifive, Rockchip etc. Without this change,
> enabling CONFIG_OF_LIVE breaks the PCIe enumeration on Qemu Risc-V virt
> machine. The issue is described in the link below:
> 
> Link: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/1
> Signed-off-by: Mayuresh Chitale <mchitale@ventanamicro.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
>  drivers/pci/pcie_ecam_generic.c | 21 ++++++++-------------
>  1 file changed, 8 insertions(+), 13 deletions(-)

This breaks some platforms such as qemu_arm at a minimum.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  parent reply	other threads:[~2023-05-03 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-18 12:25 [PATCH] pci: ecm generic: use dev_read_() interface Mayuresh Chitale
2023-02-20 16:21 ` Simon Glass
2023-05-03 20:34 ` Tom Rini [this message]
2023-05-08 15:00   ` Mayuresh Chitale
2023-05-08 15:08     ` Tom Rini
2023-11-10 11:50       ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230503203441.GA824307@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=mchitale@ventanamicro.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox