From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47DCFC77B78 for ; Wed, 3 May 2023 20:34:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E9A6C84763; Wed, 3 May 2023 22:34:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qmf4TC9P"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 044FA8475D; Wed, 3 May 2023 22:34:48 +0200 (CEST) Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3B1CB84784 for ; Wed, 3 May 2023 22:34:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2f.google.com with SMTP id 3f1490d57ef6-b9d881ad689so8140813276.2 for ; Wed, 03 May 2023 13:34:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1683146084; x=1685738084; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=75YsCzoM86Luh38VFod1GMBpKD2ggGVwvH89K6tqqiA=; b=qmf4TC9PvjNJMsS+DrZIluJE9ZKzmPgLavH8dgkRiBBIZ0EefBmXYJjdSLzHm2Ybb+ IkQPkz1NHGjNJTEtvCc8v59euXe1928D+kzB1hVeymIwRjJqfpZI/WZCaCKV6nItD9Vc LJauBZSVo23vzCfkoNJ149UZ3TMFoENr5XAzw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683146084; x=1685738084; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=75YsCzoM86Luh38VFod1GMBpKD2ggGVwvH89K6tqqiA=; b=NSSxbjQCxPfaTLyIrz48+pO1oTta80bg9++8yGZhyB+O7eoPTrOxp9uipxUrqxxCL0 1aHMzgIjihJRZc6zVmPBUEjadbbzF7ZVj+9kz9zdshY2mAd/ohueRjEN6V8w0bfoZYpt I3rkr9Vx8jhd9oV5Qi/mXanBo4YtFRCwD4bjcYJYFLZiNhaxB5gCYR2ISSooYxV3bEUp ocgHQQ62rwWKjXu9l5i4RWvwo5bgIuamXDuCNj5LU1UDh44yMEM84U4bdBfG6uEtEE1y RzVrszTVcgIF+hF2AqOSpYrzwcxn+r/PTLpUGJ/d0lVgoZ6FgswvrgWLjSMgBnmtA0jP 7bow== X-Gm-Message-State: AC+VfDzd5/A2l0snLP3kSe21z5hg6eTgk64DMBzlkf5nDXPSnoP1c8ke DKG9AB2nHFuPfChVJYusmAyZdy+DBd+5vA01jKAnUg== X-Google-Smtp-Source: ACHHUZ5AlAJ8yVct2EfcF+KTYiA9pH9ZPFnsNGt49ipA0wzmqgJoyAV6YdqQ1wcSAHymVjWT9diatg== X-Received: by 2002:a25:1e03:0:b0:b9e:45e1:2081 with SMTP id e3-20020a251e03000000b00b9e45e12081mr10425728ybe.45.1683146083871; Wed, 03 May 2023 13:34:43 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-ba0c-869b-261a-b526.res6.spectrum.com. [2603:6081:7b00:6400:ba0c:869b:261a:b526]) by smtp.gmail.com with ESMTPSA id c82-20020a251c55000000b00b9a7f23c2b8sm3198812ybc.24.2023.05.03.13.34.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 13:34:43 -0700 (PDT) Date: Wed, 3 May 2023 16:34:41 -0400 From: Tom Rini To: Mayuresh Chitale Cc: u-boot@lists.denx.de Subject: Re: [PATCH] pci: ecm generic: use dev_read_() interface Message-ID: <20230503203441.GA824307@bill-the-cat> References: <20230218122525.3815554-1-mchitale@ventanamicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B61sUVdGvQ7lUH9a" Content-Disposition: inline In-Reply-To: <20230218122525.3815554-1-mchitale@ventanamicro.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --B61sUVdGvQ7lUH9a Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Feb 18, 2023 at 05:55:25PM +0530, Mayuresh Chitale wrote: > Use dev_read_() api instead of the fdtdec API to fetch the host > controller's reg property value. This is similar to the other host > controller drivers such as Sifive, Rockchip etc. Without this change, > enabling CONFIG_OF_LIVE breaks the PCIe enumeration on Qemu Risc-V virt > machine. The issue is described in the link below: >=20 > Link: https://source.denx.de/u-boot/custodians/u-boot-dm/-/issues/1 > Signed-off-by: Mayuresh Chitale > Reviewed-by: Simon Glass > --- > drivers/pci/pcie_ecam_generic.c | 21 ++++++++------------- > 1 file changed, 8 insertions(+), 13 deletions(-) This breaks some platforms such as qemu_arm at a minimum. --=20 Tom --B61sUVdGvQ7lUH9a Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmRSxV8ACgkQFHw5/5Y0 tyy0hwv/WDHv5BctCyylfpQ7LOAX8wU6LrYpF6ZpHnfa5wjGjA0VCT26fdrqFSVS sKATQSnd8Qo2lup9JpuijKukvNrLgW3mIS0hlkMk91ca52EwH1TjTKkF/oKpvLyM KkD6HP2732J60S0a6S7/5Lu2yOXcN/OR7A7RLkXnGAuG9Hl3FDlHXC5vaEQ7AW4B zl+POhuQu+lsoSEks7NlTNK4Ca5isW4oWGDd3XYHD0MykLrHtihlVk9v73dSzrx2 Yu0G4YiN8pPEzo0/9gPXzPlMDljkNj/2dgiL5kR6cYjOv5yjiIxKbKvoEap92keQ GHwvilify4A/K0fuVSeBC0dDJFx701FyMMT4GjkIYHxKf78Qa2V9uOKIcYcbpkDf TmeM5WXchkNJaUXbSlqyk4E2rfOYjH9i0FjyGUXIta5dmVw8a3yGtA3YUPbKU43i vn1rNpOYc1ZK1rvmk7Ui0ejQ6qVSvwGSyqbj7x62TWUGqmpnNycI5zsSOure+XmL XezNczRg =P3wc -----END PGP SIGNATURE----- --B61sUVdGvQ7lUH9a--