From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CA66CC77B75 for ; Fri, 5 May 2023 08:21:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 73D2F846A8; Fri, 5 May 2023 10:21:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=solid-run.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=solidrn.onmicrosoft.com header.i=@solidrn.onmicrosoft.com header.b="BDGgI+sU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2976C846AC; Fri, 5 May 2023 10:21:13 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on060b.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe0e::60b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 22F91846A4 for ; Fri, 5 May 2023 10:21:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=solid-run.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=josua@solid-run.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J9NaRCLqBbi5T84rybK1+kd3me2hgrp8bCINccLYT2VWwPPk3DqZ4jkWqx0QaeupgqP+ue5cCu7l9ZCEhHiLhhJYf53ze1OdxaT7+bzVGivBonI4Hi1cEBiJshaDSoykyji2iylYqDiXIdhGUbX/Rlgb/nRIhkNxgaZ5j/Rpv/JqM7aZOz5c5luRifOVwga99zA2Pos/BZHpa1PmaWTL99CsY9LY1AhOaqAheNp8otylujY50UutFvDUGrSfYrgfQtfambCP8HFMFS8MUCBHAmSsKt83V0uG57zlKAVOvmqU/ZLtllf62a3fmfXaTzrXxOyZEOvDi3kWuTRMaJjpuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sZ2u60O9zbEp/WuKZTJK46ymJG5QgiZHQ0igItC5Sdo=; b=J8tAvWkyKGIBHifn2j+WFWuIadAm/0vqCe3roeu79z9uZ1Td/e6V4lotvFffIBJpo7QHU/OAZGU2m5Tb0XyAPlZzB6eUpOwBKvzVhD01PMdcO8I8wxsy62C5jHsG5FU0KB5KHnAyiUFQNiReJ7UBIteGrRgt0SAjNHE4X7L0dd0pw3uyCTWL9GKpTam1yBEe+bGOjpfUwTh6VWgPoXMPrgTBIDK4XCevAfFp53DAXQPtzFfsLXPkyZIOv0eRaKvhLH2ZVM6sbNULUtsYPXDGl0hILoC/Dg6DKhilJIRWGNGVt1u8QR8AmkLk//PsS22Rh5angG0SfsAKUXsaSNivVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=solid-run.com; dmarc=pass action=none header.from=solid-run.com; dkim=pass header.d=solid-run.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=solidrn.onmicrosoft.com; s=selector1-solidrn-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sZ2u60O9zbEp/WuKZTJK46ymJG5QgiZHQ0igItC5Sdo=; b=BDGgI+sUt675Uh1K25oN2p8p6vIXQnZeNu+vI6ykLDdknlhl0Vf6JkmZa3KBailL5aVmzosH6p8GpmlpwmJej/INI/oLNw/2dXcReeviNeNUHbgcZ4x//MVMN51lT1DSFT/XVtdjGVAqqbJWV3YaBqOHNYePrP9eNsksCf/AF6s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=solid-run.com; Received: from AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) by AS8PR04MB7926.eurprd04.prod.outlook.com (2603:10a6:20b:2ab::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.27; Fri, 5 May 2023 08:21:08 +0000 Received: from AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::9e27:8c41:a8d:938e]) by AS8PR04MB8963.eurprd04.prod.outlook.com ([fe80::9e27:8c41:a8d:938e%3]) with mapi id 15.20.6363.027; Fri, 5 May 2023 08:21:08 +0000 From: Josua Mayer To: u-boot@lists.denx.de Cc: Josua Mayer Subject: [[PATCH v2] 0/4] cmd: tlv_eeprom: global variables and error cleanup Date: Fri, 5 May 2023 11:20:45 +0300 Message-Id: <20230505082049.9768-1-josua@solid-run.com> X-Mailer: git-send-email 2.35.3 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: VI1PR0401CA0013.eurprd04.prod.outlook.com (2603:10a6:800:4a::23) To AS8PR04MB8963.eurprd04.prod.outlook.com (2603:10a6:20b:42e::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8PR04MB8963:EE_|AS8PR04MB7926:EE_ X-MS-Office365-Filtering-Correlation-Id: 35008dad-2bec-4c3d-77f5-08db4d41adc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NjyuTt00KU8277HYgCUyDbUaViUOOCMFwd9boG5cNWBkR1umUDbVC8jKaSghpcSzx4o8Xk2RmfYFnHgz+gJLwzBgHlSu4vppXLTloXjq4XFbjdt7+qyOiMw66scIqS+ylJCq8yqySK98PrvmHVAsI9N3luP0DTJxmfmt4xeGdjzAYnneGKAwZqCP13wX6EWwKpeDIDGpLKLXSJQkndAmb6ZIR0SbEVqiCECTIEO4i/uJkhh8CBoxXRMDCDRElFs+PHDRBRi9WLffGPIrKGDN30lJ2/TB61Mbo30r9eSF+l1VzSlf6gUyhPtc3EZFnXh/8nLKsYbHdXYhi1m2K3ph9O2Jb1vXJj2dqTHMNsJ0vIrzRO5rgYq4AJ7Y/2e4V7GGlwLVU7MwIX/qHLOX9G2ye00e1azPelkx7FglLAqRBWICVWMeEOfNaWWPABh8BpoQHyD4QkSnCj1HMML8+eXbel+W+GcYvk3JD5/0CkG+mzjT1DO48VbcplSPGHos7UfubIz4Z2yXIOrPWAZVKUMY/eumZDyILCsLiZjDJuHo0s7ecGfTPhBe0iS5sez9Jtkf X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8963.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39840400004)(366004)(136003)(396003)(346002)(376002)(451199021)(52116002)(478600001)(6916009)(4326008)(66946007)(66556008)(66476007)(6486002)(316002)(6666004)(86362001)(36756003)(83380400001)(2616005)(107886003)(6506007)(1076003)(6512007)(8936002)(5660300002)(8676002)(4744005)(41300700001)(2906002)(186003)(38100700002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1Zsu3xj65KSAMNFV2dmiLSatPk0Wfbmz+6gMMnNqyG4ztkCK7Cz1951/Z+tO?= =?us-ascii?Q?SPY/ZourcbB9E/m5JEfAKCNOheezRjMAtKYyRwm3aZ8GCc1K3V9pNZ1vubzU?= =?us-ascii?Q?VW7hbOhsYf9jpzeI8Og4tlSTYaO3LNqfi8M2Z19BVnx7JSouR2K+Qu6tpPCH?= =?us-ascii?Q?maA7mo2tJbHopu+Lnf0416E1DmIX5z0y6R6p00y61lv8pbONQ0a1GoS4+ckA?= =?us-ascii?Q?OGDQAglzQ9b5PLhx9PdpwhCh24wrXEzaqemX/Sz+05bjcjntTY6z9RTvh6XV?= =?us-ascii?Q?GirdiQ4YtGRgoPvRax4uotE9LKfd0H3JsFOOBKfy/IaAHvuIbMEOIs5WIEpj?= =?us-ascii?Q?1V7go0l0fHTXgamLxsju7q+QoSSeoTefCMynh/fGDfaKVSezoPFINn9E2pAc?= =?us-ascii?Q?uk7v95lZSGDVmxpzCp/dhxYbyvgMk8lnjtmxY1MA8gocxz+1HOGyUULL97ld?= =?us-ascii?Q?v08Yp1s6B2yyAq8lzaqQIv2W81kusyH/JzRBLIlMLRu4x8WpWnUrsTpzGdL2?= =?us-ascii?Q?tYHU4noNc7yr5n4CsPffUDUMUkF7KF/y75Efou7I74apfRk8f6NcHLQmGILY?= =?us-ascii?Q?3qfeePN3Hlfe3OQvzDALVMOOL1bEya8RHo68GBvQGAVfAjdKydUZ4zJb9cuo?= =?us-ascii?Q?uttl65ESVbLoJc3If+Elf73giTA3hGpR/tn5jft7s+NZN2VtwlXYO2c8OHNe?= =?us-ascii?Q?TpQCWbp0l0iYsQJm6IfK5fN3JQ8dhXZ3lSnT2eWKyJGLzRO2RScH7QH/k5lf?= =?us-ascii?Q?gr5onxx/ncj45roByaAujHiy/xwvsZkA6TGBnWPt9dD1itbJ9bXr9LFAOh3Z?= =?us-ascii?Q?iY4WvPmYMExotMtGuS1aXM1qynPiEmEmT7tT5/RhClQ5IYMqyCTEs9UJm7K5?= =?us-ascii?Q?TOULbbX/uApaxlMG8S+iXxcunKgNBVR+A0Q3uZPSBvn6FLKjAmBI7gNWjhY0?= =?us-ascii?Q?LxHzS4M5jRROnJqSUcTixHaRus+Tz26Vm0ZMNUvTKiVH7Y1j424p4/dlfFuj?= =?us-ascii?Q?PPaxjnQ7Fnqud+K+QVGZ38K4hFS/6m6/QRwULpSIu5Q0rCNQSSdsZi9efVNh?= =?us-ascii?Q?oR9ETijoSCm/fCI08bVwbmd13o8JhiE2BB/VUvB4B2zx861268p6lyMpeaMt?= =?us-ascii?Q?dnDjrDBRksQTiGT3KsfolhX0BoGAUfALMiaV03pYXgjZ8jfAi4VHr3f5Aq8G?= =?us-ascii?Q?/AKXyca7x5y6+iOJ5iftvD39FQDVycF07iO2BlaWBQTUHuwUlK0zOvbQZJEY?= =?us-ascii?Q?Lns6HaG0iVnlizmqJxd9yfpk+XfUv/EwmRmQxZnlwBMm3qoXe2w2gKpr9v3w?= =?us-ascii?Q?T58TBXUq/S07qSlNkTb5jzAPYDTObxwekbqPk9ID2cyn2H+C7az6tchUoyWw?= =?us-ascii?Q?KCPmeMrxqqHdWzRNt/2nDnR4cnqNPTQvzDHrzutqQ+BM3+3efTAe2/u0qRaV?= =?us-ascii?Q?E+0ePn3KUKJEBrYlH9D5usBwoZ+AY745PSJhSiu/Ar42Rjma0ZnA0tabctFU?= =?us-ascii?Q?caKiZsUzff4jAjduJP0L42InQJLDclhbDDpoeG7gbPDBBu7cVji1cp/86hnG?= =?us-ascii?Q?fTKcchOgzVsrd2HJ5hPGS9jfb16Wgv72AZB6FpI+8GQtSDVtek0Hvmqlk2eS?= =?us-ascii?Q?tQaaaX4RvYKVgCIQKzGqZGA=3D?= X-OriginatorOrg: solid-run.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35008dad-2bec-4c3d-77f5-08db4d41adc1 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8963.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2023 08:21:08.8106 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a4a8aaf3-fd27-4e27-add2-604707ce5b82 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: O3RwNmZh3G8B6s5RKmiPUL1QFW4Q0QTh9jYSmfjdaIM6/zIliJ9aI1gwG2+0AWZGua+ZLMvh+0DFcZjOmTT2sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7926 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This patch-set removes some uses of global variables, and improves error reporting for the "read" command. It is intended to help switching to a split tlv library eventually, but general enough to apply independently. Changes since v1: - rebased on master 0160d58 - added first patch!!! I had forgotten to send in v1 - added reviewed-tags by Stefan for patches 2-4 Josua Mayer (4): cmd: tlv_eeprom: remove use of global variable current_dev cmd: tlv_eeprom: remove use of global variable has_been_read cmd: tlv_eeprom: handle -ENODEV error from read_eeprom function cmd: tlv_eeprom: enable 'dev' subcommand before 'read' cmd/tlv_eeprom.c | 107 +++++++++++++++++++++++++------------------ include/tlv_eeprom.h | 3 +- 2 files changed, 64 insertions(+), 46 deletions(-) -- 2.35.3