From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48BFDC77B75 for ; Sat, 6 May 2023 16:14:16 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5DBBF85E44; Sat, 6 May 2023 18:14:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="dX0Z9Fec"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8C32985CD8; Sat, 6 May 2023 18:14:13 +0200 (CEST) Received: from mail-oa1-x36.google.com (mail-oa1-x36.google.com [IPv6:2001:4860:4864:20::36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DA9F685E44 for ; Sat, 6 May 2023 18:14:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-oa1-x36.google.com with SMTP id 586e51a60fabf-19292e65c49so623807fac.0 for ; Sat, 06 May 2023 09:14:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683389649; x=1685981649; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PPctvSsficTy5C0626dQ6kKiRzXtRaA8LnrfMmBzX68=; b=dX0Z9FecHmon/4RcGfi2EHQWasZRO+Xb5VGyT8mKAVa24QRXZVq5+5HOSHwH47Dnsr C47dFZI2j5jfz1ZNoAf0AExLVymDwEQjf5dxqyfGAUaWmXaKGZjPRS8xgmsyZmRiuVzh a4ceeMTTIqsw/is/E0z+PuyiPzuJCIYoMAzc/VXnZ347DpFj9TB5DCq6uIQL4S6KCiUi T+QhHO1p4MxwqPyMww1/Uf/DqVI8v2qe0IgSBG8w6HnPYCXA92xd2B4mkhHu8KuQZUd6 FGMHNkmb9G8IkGbfPOLRkrQjNX259gpq1rPokEgmVlM+i721PpdyzfaSpjQ0863ntLcM zVaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683389649; x=1685981649; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PPctvSsficTy5C0626dQ6kKiRzXtRaA8LnrfMmBzX68=; b=O63WHkbxkuDm9Jkfijg6LfdNZYUUrYnbb4b5TWbPLxg64x/LZowDJmagqv0TkwpXQK 1zBgObrHw8fk7wGl13/nmIbebLTZa0eu0oxN69SCLMPPH16voWHKNlYURArsar03v2fd ReHACI61AGrdOkYj9AtHrzeryn/UOUOI6XOxpMOXysxCNu5DAurvFHCaliZrOtfK4jjV 9qX6jTYXyO04LYxd3Tca6y2ntqVCqKNRIcVQQDQBcDbYSMgUEKQUkeAGZ4S/+LBuqjYQ cLG4NyTvBdWn3beE8IipXUyYxTVtqqQlKcaUPBbbM4WlVT7bj3971I4kPbN0QnDBNzWt 4Zxw== X-Gm-Message-State: AC+VfDziL82CPm/SSMTUGQZG0yICK12apjlqZ5OPROAD9IR9gVEByg8C esaaC2hAJdBNr1lXboPiazQ= X-Google-Smtp-Source: ACHHUZ4CO92Og+E8U1Er0CFPRdTjTQtVdhjxFxsBbjw6a9tGYA69uUpJjFkRW9GWqvJcRhDcFidlEA== X-Received: by 2002:a05:6870:d629:b0:171:a749:bc0c with SMTP id a41-20020a056870d62900b00171a749bc0cmr3421054oaq.3.1683389649351; Sat, 06 May 2023 09:14:09 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b69:184f:7f0b:5232:6de9]) by smtp.gmail.com with ESMTPSA id p17-20020a4ae151000000b005462a25c4f9sm2318303oot.9.2023.05.06.09.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 09:14:08 -0700 (PDT) From: Fabio Estevam To: jh80.chung@samsung.com Cc: u-boot@lists.denx.de, sbabic@denx.de, tharvey@gateworks.com, marex@denx.de, aford173@gmail.com, ye.li@nxp.com, peng.fan@nxp.com, Fabio Estevam Subject: [PATCH] power: imx8m-power-domain: Add delay to align with kernel driver Date: Sat, 6 May 2023 13:14:02 -0300 Message-Id: <20230506161402.2711105-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Fabio Estevam In the imx8m power domain kernel driver, there is an extra udelay(5) prior to requesting the domain to power up: https://github.com/torvalds/linux/blob/v6.3/drivers/soc/imx/gpcv2.c#L347-L375 Haven't observed any issues due to the lack of this delay in U-Boot yet, but better to align it with the kernel driver implementation. Signed-off-by: Fabio Estevam Reviewed-by: Marek Vasut --- Changes since RFC: - Added Marek's Reviewed-by tag. drivers/power/domain/imx8m-power-domain.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/power/domain/imx8m-power-domain.c b/drivers/power/domain/imx8m-power-domain.c index 145f6ec0cd32..df5d7d695621 100644 --- a/drivers/power/domain/imx8m-power-domain.c +++ b/drivers/power/domain/imx8m-power-domain.c @@ -338,6 +338,9 @@ static int imx8m_power_domain_on(struct power_domain *power_domain) } } + /* delay for reset to propagate */ + udelay(5); + if (domain->bits.pxx) { /* request the domain to power up */ setbits_le32(base + regs->pup, domain->bits.pxx); -- 2.34.1