public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: Marek Vasut <marex@denx.de>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
	Stefano Babic <sbabic@denx.de>, Peng Fan <peng.fan@oss.nxp.com>,
	Peng Fan <peng.fan@nxp.com>, Fabio Estevam <festevam@gmail.com>,
	"'NXP i . MX U-Boot Team'" <uboot-imx@nxp.com>
Subject: Re: [PATCH 1/5] arm: mxs: Provide Kconfig option to to not use VDD5V as IMX28 PMU source
Date: Tue, 9 May 2023 17:04:05 +0200	[thread overview]
Message-ID: <20230509170405.3bd74a16@wsk> (raw)
In-Reply-To: <df58d7c8-597a-b3b8-058c-95a80116f615@denx.de>

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Hi Marek,

> On 5/9/23 16:46, Lukasz Majewski wrote:
> > Hi Marek,  
> 
> Hi,
> 
> >> On 5/9/23 16:32, Lukasz Majewski wrote:  
> >>> This option sets the current limit for 5V source to zero, so all
> >>> the PMU outputs are primarily powered from battery source
> >>> (DCDC_BAT).
> >>>
> >>> This option may be set on systems, where the 5V is NOT supposed to
> >>> be in any scenario powering the system - for example on systems
> >>> where DCDC_BAT is connected to fixed and regulated 4.2V source (so
> >>> the "battery" is not present).  
> >>
> >> Is it possible to dig this information out of DT or is the DT not
> >> available in SPL for this platform ?  
> > 
> > This platform uses only SPL_OF_PLATDATA to keep the SPL size < 40
> > KiB.
> > 
> > I would prefer to keep this as Kconfig as the PMU driver is not
> > supporting DT and in fact now ARCH_MX28 only has two boards
> > supported - XEA and imx28evk.  
> 
> Why not use the platdata then ?
> This makes it far better, as the code is actually always compiled and 
> doesn't start to bitrot.

As fair as I can tell - the MX28 PMU driver in SPL is not supporting
OF_PLATDATA. Or have I overlooked something?

I would like to investigate the PMU issue, and avoid extra work to
provide platdata support for two supported imx287 based boards.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-05-09 15:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 14:32 [PATCH 1/5] arm: mxs: Provide Kconfig option to to not use VDD5V as IMX28 PMU source Lukasz Majewski
2023-05-09 14:32 ` [PATCH 2/5] arm: mxs: Provide Kconfig option to disable battery charging at IMX28 PMU Lukasz Majewski
2023-07-11 19:42   ` sbabic
2023-05-09 14:32 ` [PATCH 3/5] arm: mxs: Provide Kconfig option to not enable 4P2 regulator in " Lukasz Majewski
2023-07-11 19:43   ` sbabic
2023-05-09 14:32 ` [PATCH 4/5] arm: mxs: Add function to dump PMU registers Lukasz Majewski
2023-07-11 19:46   ` sbabic
2023-05-09 14:32 ` [PATCH 5/5] arm: config: Adjust imx287 based XEA board PMU configuration Lukasz Majewski
2023-07-11 19:46   ` sbabic
2023-05-09 14:40 ` [PATCH 1/5] arm: mxs: Provide Kconfig option to to not use VDD5V as IMX28 PMU source Marek Vasut
2023-05-09 14:46   ` Lukasz Majewski
2023-05-09 14:48     ` Marek Vasut
2023-05-09 15:04       ` Lukasz Majewski [this message]
2023-05-09 15:51         ` Marek Vasut
2023-05-19  8:41           ` Lukasz Majewski
2023-05-19 12:43             ` Marek Vasut
2023-05-10 14:28 ` Fabio Estevam
2023-07-11 19:44 ` sbabic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230509170405.3bd74a16@wsk \
    --to=lukma@denx.de \
    --cc=festevam@gmail.com \
    --cc=marex@denx.de \
    --cc=peng.fan@nxp.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox