From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B148C7EE22 for ; Thu, 11 May 2023 13:51:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0ECB685DC9; Thu, 11 May 2023 15:51:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="bsavHzF/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 031F4860CB; Thu, 11 May 2023 15:51:40 +0200 (CEST) Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9A4EB85CD8 for ; Thu, 11 May 2023 15:51:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-55aa1da9d4aso154527407b3.2 for ; Thu, 11 May 2023 06:51:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1683813096; x=1686405096; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uUKsp1Exq8aYllu7+CKCMwMD6FJ4i/zFKXAIA4c2KQg=; b=bsavHzF/syWmGAi9E/lKHSJ0HoLx7ljsMI79tcmed95/c9k7Fy7AsoYk5LxR8R2oQu Gek4zFOUOBEIhnzWJVTVS4pN17onWVlopvnL8b7V29EboEGKwJmyWbIi12omn3nqea0R f8gGaZ9uvaf49e8NMQxRAbBjmgOegByllVTpg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683813096; x=1686405096; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uUKsp1Exq8aYllu7+CKCMwMD6FJ4i/zFKXAIA4c2KQg=; b=QJVv15LCkK+wmhOQuODATCofanG05cIKMqDyy8lQo2+cFjxWn8qCI7Lt83CCFXWC31 NibRmUxLqcGwYV118UQZkIepaZRzLupgWPfi6vcsdzPOuy2PDnw2xOa8MJ67stzmNzq0 Y+dZuomKKSti+sykUDYD72yzKuo0m2e091Ew+uZYliOURxfGEwOAXNR+90oMSXfZkGfp MoV/AuUyMeyinIFy2TVngJgNLypZvcIoQl81RSqt4T3b8BzDUJFr5H4gTpv+9f73HFQT UPP+QxKk55GKBkcDICJ6J6fLXA8A8/oggl+XJV23EptdLRHuIgrJDCp6kCfUjr/8DaIS l9Ww== X-Gm-Message-State: AC+VfDzy38zSFX7hfL1CC0O79ByOOcWkF2iz27VBdnWnGSwnr+tsnln3 +MErzMWWVa3lUDFnSNHJO+wNoA== X-Google-Smtp-Source: ACHHUZ7GKmFLWup7j6OpW2xBtpS6MaelgwPmDo9VPnC/myjW1Upyi8BW2pDQyQZzjpv0OEGzQyE2uQ== X-Received: by 2002:a0d:cc4b:0:b0:55a:3420:5adc with SMTP id o72-20020a0dcc4b000000b0055a34205adcmr22065621ywd.51.1683813096349; Thu, 11 May 2023 06:51:36 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-238a-0d17-77d4-33aa.res6.spectrum.com. [2603:6081:7b00:6400:238a:d17:77d4:33aa]) by smtp.gmail.com with ESMTPSA id g138-20020a815290000000b0054629ed8300sm4894858ywb.80.2023.05.11.06.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 May 2023 06:51:35 -0700 (PDT) Date: Thu, 11 May 2023 09:51:34 -0400 From: Tom Rini To: Peter Robinson Cc: Ilias Apalodimas , Simon Glass , Maxim Uvarov , u-boot@lists.denx.de, pbrobinson@redhat.com, joe.hershberger@ni.com, rfried.dev@gmail.com Subject: Re: [RFC PATCH 1/5] add lwip-external submodule Message-ID: <20230511135134.GS2398826@bill-the-cat> References: <20230505102529.1254445-1-maxim.uvarov@linaro.org> <20230505102529.1254445-2-maxim.uvarov@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vBkjs8p7qHwdn7kI" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --vBkjs8p7qHwdn7kI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 10, 2023 at 03:46:31PM +0100, Peter Robinson wrote: > On Wed, May 10, 2023 at 8:40=E2=80=AFAM Ilias Apalodimas > wrote: > > > > Hi Simon, > > > > On Mon, May 08, 2023 at 08:43:14AM -0600, Simon Glass wrote: > > > Hi Maxim, > > > > > > On Fri, 5 May 2023 at 04:50, Maxim Uvarov w= rote: > > > > > > > > Signed-off-by: Maxim Uvarov > > > > --- > > > > .gitmodules | 3 +++ > > > > lib/lwip/lwip-external | 1 + > > > > 2 files changed, 4 insertions(+) > > > > create mode 100644 .gitmodules > > > > create mode 160000 lib/lwip/lwip-external > > > > > > > > > > Please no submodules. They are such a pain. If we want the code in > > > U-Boot, let's put it in U-Boot and upstream our changes as needed. > > > > Can you explain a bit more the pain points you are seeing in u-boot with > > submodules? EDK2 does submodules for openSSL and it's quite convenient, > > since you dont have to maintain any code, do backports etc. Instead we= can > > just use upstream projects as-is. >=20 > I feel there's pros and cons for both, similarly different projects > have different projects have different policies. Tom may have a more > definite opinion. >=20 > > IMHO we should work on having it as an experimental feature in parallel > > with the current TCP efforts for a while and have a Kconfig switch. If= we > > are happy in the long run and the code increase isn't prohibitive, we c= an > > consider switching permanently >=20 > At least for initial review of the prototype I don't see it as > blocking for people to get a general idea what is going on. Yeah, I also don't like submodules. But for the purpose of this RFC, at this stage in the RFC, it's fine. May or may not be easier to review. --=20 Tom --vBkjs8p7qHwdn7kI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmRc8t8ACgkQFHw5/5Y0 tyzD3Av/cQZNtX6ziAxvmVO0E0846U/5gwBh0Dn5S9QX8AUBSkHtNY6MrXG+fJ5e LbXahWHYWGzKsYPlqQr4h+YutIKA3fnW9PH2dNo/t4+YMqDQ6WBYWVMYpBoPJ8/z kt1F1zUTwj2z5CnLzzomRN4PuLIrAsTCFTVNnzSZbJnw/P7KFggbeNXCa91c1Oxt /IRj1Ic8yY3onKiTQmc3FrwNdEhWGVm5vF76/lqZ2RXtqK6pwFwFdakbNgZJPhmP zkWfr4WlhsZt1wuET/PGEOfD4EY1fNQ/p73nM+nj0zi8PYtzgTcI5UdBEbku5+bJ pi+wIsgT898ioGR2aS1eqEE/I8YXMbRT4FRogMv90a5mlLIcVAZjaYgzaAdGyLtd pr5PxuAYv1Qr1cf7luOlEMQ06VOZ45/8fj0XWHW/7hLMIrXbPk4lBuw9bKEwyLaB njWj/nxmd/m43DsedGRP0RKxYAbJpbjmLRBuvF2fU0rgn8VsaK17lfIw2uTS62e8 1vAsU7S8 =sxry -----END PGP SIGNATURE----- --vBkjs8p7qHwdn7kI--