public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Francis Laniel <francis.laniel@amarulasolutions.com>
To: u-boot@lists.denx.de
Cc: Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>,
	Harald Seiler <hws@denx.de>,
	Francis Laniel <francis.laniel@amarulasolutions.com>
Subject: [RFC PATCH v8 06/23] test: hush: Test hush loops
Date: Fri, 12 May 2023 21:03:14 +0100	[thread overview]
Message-ID: <20230512200331.51457-7-francis.laniel@amarulasolutions.com> (raw)
In-Reply-To: <20230512200331.51457-1-francis.laniel@amarulasolutions.com>

The added tests verifies correct behavior of for, while and until loops.

Signed-off-by: Francis Laniel <francis.laniel@amarulasolutions.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
 test/hush/Makefile |  1 +
 test/hush/loop.c   | 65 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 66 insertions(+)
 create mode 100644 test/hush/loop.c

diff --git a/test/hush/Makefile b/test/hush/Makefile
index ff4fe7700b..a2d98815e5 100644
--- a/test/hush/Makefile
+++ b/test/hush/Makefile
@@ -7,3 +7,4 @@ obj-y += cmd_ut_hush.o
 obj-y += if.o
 obj-y += dollar.o
 obj-y += list.o
+obj-y += loop.o
diff --git a/test/hush/loop.c b/test/hush/loop.c
new file mode 100644
index 0000000000..ca777e38fe
--- /dev/null
+++ b/test/hush/loop.c
@@ -0,0 +1,65 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * (C) Copyright 2021
+ * Francis Laniel, Amarula Solutions, francis.laniel@amarulasolutions.com
+ */
+
+#include <common.h>
+#include <command.h>
+#include <env_attr.h>
+#include <test/hush.h>
+#include <test/ut.h>
+
+static int hush_test_for(struct unit_test_state *uts)
+{
+	console_record_reset_enable();
+
+	ut_assertok(run_command("for loop_i in foo bar quux quux; do echo $loop_i; done", 0));
+	ut_assert_nextline("foo");
+	ut_assert_nextline("bar");
+	ut_assert_nextline("quux");
+	ut_assert_nextline("quux");
+	ut_assert_console_end();
+
+	puts("Beware: this test set local variable loop_i and it cannot be unset!");
+
+	return 0;
+}
+HUSH_TEST(hush_test_for, 0);
+
+static int hush_test_while(struct unit_test_state *uts)
+{
+	console_record_reset_enable();
+
+	/* Exit status is that of test, so 1 since test is false to quit the loop. */
+	ut_asserteq(1, run_command("while test -z \"$loop_foo\"; do echo bar; loop_foo=quux; done", 0));
+	ut_assert_nextline("bar");
+	ut_assert_console_end();
+
+	puts("Beware: this test set local variable loop_foo and it cannot be unset!");
+
+	return 0;
+}
+HUSH_TEST(hush_test_while, 0);
+
+static int hush_test_until(struct unit_test_state *uts)
+{
+	console_record_reset_enable();
+	env_set("loop_bar", "bar");
+
+	/*
+	 * WARNING We have to use environment variable because it is not possible
+	 * resetting local variable.
+	 */
+	ut_assertok(run_command("until test -z \"$loop_bar\"; do echo quux; setenv loop_bar; done", 0));
+	ut_assert_nextline("quux");
+	ut_assert_console_end();
+
+	/*
+	 * Loop normally resets foo environment variable, but we reset it here in
+	 * case the test failed.
+	 */
+	env_set("loop_bar", NULL);
+	return 0;
+}
+HUSH_TEST(hush_test_until, 0);
-- 
2.34.1


  parent reply	other threads:[~2023-05-12 20:06 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-12 20:03 [RFC PATCH v8 00/23] Modernize U-Boot shell Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 01/23] test: Add framework to test hush behavior Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 02/23] test: hush: Test hush if/else Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 03/23] test/py: hush_if_test: Remove the test file Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 04/23] test: hush: Test hush variable expansion Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 05/23] test: hush: Test hush commands list Francis Laniel
2023-05-12 20:03 ` Francis Laniel [this message]
2023-05-12 20:03 ` [RFC PATCH v8 07/23] cli: Add Busybox upstream hush.c file Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 08/23] cli: Port Busybox 2021 hush to U-Boot Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 09/23] cli: Add menu for hush parser Francis Laniel
2023-05-13  1:03   ` Heinrich Schuchardt
2023-05-13 20:32     ` Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 10/23] global_data.h: add GD_FLG_HUSH_OLD_PARSER flag Francis Laniel
2023-05-13  1:07   ` Heinrich Schuchardt
2023-05-13 20:29     ` Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 11/23] cmd: Add new cli command Francis Laniel
2023-05-13  1:18   ` Heinrich Schuchardt
2023-05-13 20:17     ` Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 12/23] cli: Enables using hush 2021 parser as command line parser Francis Laniel
2023-05-13  1:19   ` Heinrich Schuchardt
2023-05-25  8:19     ` Patrick DELAUNAY
2023-05-12 20:03 ` [RFC PATCH v8 13/23] cli: hush_2021: Enable variables expansion for hush 2021 Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 14/23] cli: hush_2021: Add functions to be called from run_command() Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 15/23] cli: add hush 2021 as parser for run_command*() Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 16/23] test: hush: Fix instructions list tests for hush 2021 Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 17/23] test: hush: Fix variable expansion " Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 18/23] cli: hush_2021: Enable using < and > as string compare operators Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 19/23] cli: hush_2021: Enable if keyword Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 20/23] cli: hush_2021: Enable loops Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 21/23] test: hush: Fix loop tests for hush 2021 Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 22/23] cli: hush_2021: Add upstream commits up to 9th May 2023 Francis Laniel
2023-05-12 20:03 ` [RFC PATCH v8 23/23] DO NOT MERGE: only to make CI happy Francis Laniel
2023-05-12 20:44   ` Tony Dinh
2023-05-13  9:54 ` [RFC PATCH v8 00/23] Modernize U-Boot shell Peter Robinson
2023-05-13 21:42   ` Francis Laniel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230512200331.51457-7-francis.laniel@amarulasolutions.com \
    --to=francis.laniel@amarulasolutions.com \
    --cc=hws@denx.de \
    --cc=michael@amarulasolutions.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox