From: Sam Edwards <cfsworks@gmail.com>
To: u-boot@lists.denx.de
Cc: Tom Rini <trini@konsulko.com>, Sam Edwards <CFSworks@gmail.com>
Subject: [PATCH 1/3] makefile: Fix symbol typo in binary_size_check
Date: Fri, 12 May 2023 17:01:33 -0600 [thread overview]
Message-ID: <20230512230135.133162-1-CFSworks@gmail.com> (raw)
The start-of-image marker symbol is `__image_copy_start`; by
searching for `_image_copy_start` instead, this check can
accidentally match `_image_copy_start_ofs`.
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index fb02bba08f..22bdc30109 100644
--- a/Makefile
+++ b/Makefile
@@ -1262,7 +1262,7 @@ OBJCOPYFLAGS_u-boot-nodtb.bin := -O binary \
binary_size_check: u-boot-nodtb.bin FORCE
@file_size=$(shell wc -c u-boot-nodtb.bin | awk '{print $$1}') ; \
map_size=$(shell cat u-boot.map | \
- awk '/_image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \
+ awk '/__image_copy_start/ {start = $$1} /_image_binary_end/ {end = $$1} END {if (start != "" && end != "") print "ibase=16; " toupper(end) " - " toupper(start)}' \
| sed 's/0X//g' \
| bc); \
if [ "" != "$$map_size" ]; then \
--
2.39.2
next reply other threads:[~2023-05-13 9:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 23:01 Sam Edwards [this message]
2023-05-12 23:01 ` [PATCH 2/3] makefile: Consider "no relocs" to be "no unexpected relocs" Sam Edwards
2023-05-12 23:01 ` [PATCH 3/3] clang: Link with --no-pie instead of --apply-dynamic-relocs Sam Edwards
2023-05-14 15:28 ` Tom Rini
2023-05-16 2:08 ` Sam Edwards
2023-05-14 15:28 ` [PATCH 1/3] makefile: Fix symbol typo in binary_size_check Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512230135.133162-1-CFSworks@gmail.com \
--to=cfsworks@gmail.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox