* [PATCH v3] environment: ti: rproc: fix remoteproc environment variables
@ 2023-05-15 6:52 Manorit Chawdhry
2023-05-16 15:19 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Manorit Chawdhry @ 2023-05-15 6:52 UTC (permalink / raw)
To: Neha Malcom Francis, Tom Rini; +Cc: u-boot, Apurva Nandan, Manorit Chawdhry
During refactor this seemed to have been missed.
Fixes: 65dbb128fb45 ("include: environment: ti: Use .env for environment variables")
Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
---
Changes in v3:
- fix broken fixes tag
- fix broken link to v1
- Link to v2: https://lore.kernel.org/r/20230512-b4-upstream-rproc-semicolon-v2-1-751b0896359f@ti.com
- Link to v1: https://lore.kernel.org/u-boot/20230512-b4-upstream-rproc-semicolon-v1-1-f450e266d3e9@ti.com/
---
include/environment/ti/k3_rproc.env | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/environment/ti/k3_rproc.env b/include/environment/ti/k3_rproc.env
index 21dad7b24121..87d9d76eba46 100644
--- a/include/environment/ti/k3_rproc.env
+++ b/include/environment/ti/k3_rproc.env
@@ -7,14 +7,14 @@ boot_rprocs=
rproc_load_and_boot_one=
if load mmc ${bootpart} $loadaddr ${rproc_fw}; then
if rproc load ${rproc_id} ${loadaddr} ${filesize}; then
- rproc start ${rproc_id}
+ rproc start ${rproc_id};
fi;
fi
boot_rprocs_mmc=
env set rproc_id;
env set rproc_fw;
for i in ${rproc_fw_binaries} ; do
- if test -z ${rproc_id} ; then
+ if test -z "${rproc_id}" ; then
env set rproc_id $i;
else
env set rproc_fw $i;
---
base-commit: 0a9a4384c1483a88776bca38e28f09be51161034
change-id: 20230512-b4-upstream-rproc-semicolon-9afdb6101c13
Best regards,
--
Manorit Chawdhry <m-chawdhry@ti.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] environment: ti: rproc: fix remoteproc environment variables
2023-05-15 6:52 [PATCH v3] environment: ti: rproc: fix remoteproc environment variables Manorit Chawdhry
@ 2023-05-16 15:19 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2023-05-16 15:19 UTC (permalink / raw)
To: Manorit Chawdhry; +Cc: Neha Malcom Francis, u-boot, Apurva Nandan
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
On Mon, May 15, 2023 at 12:22:42PM +0530, Manorit Chawdhry wrote:
> During refactor this seemed to have been missed.
>
> Fixes: 65dbb128fb45 ("include: environment: ti: Use .env for environment variables")
>
> Signed-off-by: Manorit Chawdhry <m-chawdhry@ti.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-16 15:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-15 6:52 [PATCH v3] environment: ti: rproc: fix remoteproc environment variables Manorit Chawdhry
2023-05-16 15:19 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox