From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41933C7EE29 for ; Thu, 18 May 2023 22:22:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3A433846BF; Fri, 19 May 2023 00:22:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="DheNX5SG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0465C846BF; Fri, 19 May 2023 00:22:52 +0200 (CEST) Received: from mail-ot1-x336.google.com (mail-ot1-x336.google.com [IPv6:2607:f8b0:4864:20::336]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 96BD184680 for ; Fri, 19 May 2023 00:22:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=festevam@gmail.com Received: by mail-ot1-x336.google.com with SMTP id 46e09a7af769-6af42332efdso128399a34.0 for ; Thu, 18 May 2023 15:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684448567; x=1687040567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gLp6UxJ8xD9NgLzIUqD02UAp4Nf7zFxYm3qMdCLdfP0=; b=DheNX5SGARr+6e7V8kkCkC9zdLuVxi5SbWiqi3T4GlJLqcb5CAtkxuxOEtZUQCyVFC p8Ii2ZbM0JC0XymJ4BEeG2e9dAdhoe5MxV15AgsdojVqLn+PvxnOCsC40KMGiUe1D+q8 1qmMdt7dCZfwyAFre9vmW1UoG5ad0aBtutcTM7KzVpgEwdc4gKfgyIUeoHOoyZhf1w5i 91LCytA1rYBqJJ35YOoRMPFldlU8TZLdrJSC+ywu+cPLFHd7rSt/BcPG2mtK83Js22/K m100MyWNSHxvwhYO65zuiltawfVlR5GLDjgX+gv4uV1i7XGYXMEC4uhMIRzj/Qng7zqo k3eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684448567; x=1687040567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gLp6UxJ8xD9NgLzIUqD02UAp4Nf7zFxYm3qMdCLdfP0=; b=KuQzFkO5zKf2PlyD331lsAOXmLIOyZvnXuP5XY0Zyxglg7R+sGZvyopKcOmDzmW50C Qo8mk8WQUGDM4/qjE1zZXiP6OQa0GhHIwx4mzcLa0WZmFsdNyH0LMaVSrluzCbD18gdO aVXq/67PNbMfeRSJ+gWAyOVb35OLxEIj6C0g07XI9GuUfEb/y/jQQmq3q/R3O0LvR2rh /I5nt0CXFrLY/nGI0K53fsc9o3lN1tnOkRMaTPw6/dRraXLNa0lgDeeK9WPCUVciZ209 5g9GDf3B+DM//BL+OcoLoH9WYuOusYapKpW0bbGCgNJyj+PSJ+Ya/RQksosu5aVuu6RF Qi8A== X-Gm-Message-State: AC+VfDyjMmnX2qPGKK2fUhU3Ogi8VtK1/n1c0SW1LymUu8+ieOKl/mx2 mrudu4JfStzRsJ5rutG0wRc= X-Google-Smtp-Source: ACHHUZ606jjeX37ypVq0prRalvmoGOUrl3NK77AItw6vncVX5UaNzrw3dkuiTYYpsoUv0lYBPcs1vg== X-Received: by 2002:a05:6830:1008:b0:6ab:106a:c76f with SMTP id a8-20020a056830100800b006ab106ac76fmr36764otp.2.1684448566946; Thu, 18 May 2023 15:22:46 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:14c:485:4b69:e366:77e8:4ae8:a240]) by smtp.gmail.com with ESMTPSA id p23-20020a0568301d5700b006a42e87aee4sm1100940oth.32.2023.05.18.15.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 15:22:46 -0700 (PDT) From: Fabio Estevam To: jagan@amarulasolutions.com Cc: u-boot@lists.denx.de, Fabio Estevam Subject: [PATCH 1/2] spi: soft_spi: Support the recommended soft spi properties Date: Thu, 18 May 2023 19:22:40 -0300 Message-Id: <20230518222241.193887-1-festevam@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Fabio Estevam According to Documentation/devicetree/bindings/spi/spi-gpio.yaml from Linux, the recommended spio-gpio properties are: sck-gpios, miso-gpios and mosi-gpios. gpio-sck, gpio-mosi and gpio-miso are considered deprecated. Currently, U-Boot only supports the deprecated properties. Allow the soft_spi driver to support both the new and old properties. Signed-off-by: Fabio Estevam --- drivers/spi/soft_spi.c | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/spi/soft_spi.c b/drivers/spi/soft_spi.c index f3602a25ba30..0fa14339bdcd 100644 --- a/drivers/spi/soft_spi.c +++ b/drivers/spi/soft_spi.c @@ -248,19 +248,32 @@ static int soft_spi_probe(struct udevice *dev) cs_flags = (slave && slave->mode & SPI_CS_HIGH) ? 0 : GPIOD_ACTIVE_LOW; clk_flags = (slave && slave->mode & SPI_CPOL) ? GPIOD_ACTIVE_LOW : 0; - if (gpio_request_by_name(dev, "cs-gpios", 0, &plat->cs, - GPIOD_IS_OUT | cs_flags) || - gpio_request_by_name(dev, "gpio-sck", 0, &plat->sclk, - GPIOD_IS_OUT | clk_flags)) + ret = gpio_request_by_name(dev, "cs-gpios", 0, &plat->cs, + GPIOD_IS_OUT | cs_flags); + if (ret) + return -EINVAL; + + ret = gpio_request_by_name(dev, "gpio-sck", 0, &plat->sclk, + GPIOD_IS_OUT | clk_flags); + if (ret) + ret = gpio_request_by_name(dev, "sck-gpios", 0, &plat->sclk, + GPIOD_IS_OUT | clk_flags); + if (ret) return -EINVAL; ret = gpio_request_by_name(dev, "gpio-mosi", 0, &plat->mosi, GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); + if (ret) + ret = gpio_request_by_name(dev, "mosi-gpios", 0, &plat->mosi, + GPIOD_IS_OUT | GPIOD_IS_OUT_ACTIVE); if (ret) plat->flags |= SPI_MASTER_NO_TX; ret = gpio_request_by_name(dev, "gpio-miso", 0, &plat->miso, GPIOD_IS_IN); + if (ret) + ret = gpio_request_by_name(dev, "gpio-miso", 0, &plat->miso, + GPIOD_IS_IN); if (ret) plat->flags |= SPI_MASTER_NO_RX; -- 2.34.1