Re: [PATCH v4 00/11] Add ethernet driver for StarFive JH7110 SoC

Torsten Duwe
2023-05-26T07:41:14Z

On Thu, 25 May 2023 17:36:26 +0800
Yanhong Wang <yanhong.wang@starfivetech.com> wrote:
[...]
> The main difference between StarFive VisionFive 2 1.2A and 1.3B is
> gmac, but the difference in gmac is not defined in DT, but reads the
> PCB version from EEPROM, and then dynamically configures the
> difference of gmac according to different PCB versions, which is
> compatible with 1.2A and 1.3B versions, which is more user-friendly.

Big ACK from me so far, it is overdue to clean the duplication mess that
is currently in master.

> The PHY and MAC driver has been tested on the StarFive VisionFive 2
> 1.2A and 1.3B boards and works normally.

But for a complete test I'd like to see the respectively correct DTB
passed to the OS, and that requires the other issue (base / clock
support and single DT) to be resolved first.

Thanks!

Torsten