From: Torsten Duwe <duwe@lst.de>
To: Yanhong Wang <yanhong.wang@starfivetech.com>
Cc: <u-boot@lists.denx.de>, Rick Chen <rick@andestech.com>,
Leo <ycliang@andestech.com>,
Joe Hershberger <joe.hershberger@ni.com>,
"Ramon Fried" <rfried.dev@gmail.com>,
Leyfoon Tan <leyfoon.tan@starfivetech.com>,
"samin . guo" <samin.guo@starfivetech.com>,
Walker Chen <walker.chen@starfivetech.com>
Subject: Re: [PATCH v4 00/11] Add ethernet driver for StarFive JH7110 SoC
Date: Fri, 26 May 2023 09:40:57 +0200 [thread overview]
Message-ID: <20230526094057.7cab96fc@blackhole.lan> (raw)
In-Reply-To: <20230525093637.31364-1-yanhong.wang@starfivetech.com>
On Thu, 25 May 2023 17:36:26 +0800
Yanhong Wang <yanhong.wang@starfivetech.com> wrote:
[...]
> The main difference between StarFive VisionFive 2 1.2A and 1.3B is
> gmac, but the difference in gmac is not defined in DT, but reads the
> PCB version from EEPROM, and then dynamically configures the
> difference of gmac according to different PCB versions, which is
> compatible with 1.2A and 1.3B versions, which is more user-friendly.
Big ACK from me so far, it is overdue to clean the duplication mess that
is currently in master.
> The PHY and MAC driver has been tested on the StarFive VisionFive 2
> 1.2A and 1.3B boards and works normally.
But for a complete test I'd like to see the respectively correct DTB
passed to the OS, and that requires the other issue (base / clock
support and single DT) to be resolved first.
Thanks!
Torsten
next prev parent reply other threads:[~2023-05-26 7:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 9:36 [PATCH v4 00/11] Add ethernet driver for StarFive JH7110 SoC Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 01/11] net: phy: Add driver for Motorcomm yt8531 gigabit ethernet phy Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 02/11] net: dwc_eth_qos: Add StarFive ethernet driver glue layer Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 03/11] eeprom: starfive: Enable ID EEPROM configuration Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 04/11] ram: starfive: Read memory size information from EEPROM Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 05/11] board: starfive: Dynamic configuration of DT for 1.2A and 1.3B Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 06/11] riscv: dts: jh7110: Add ethernet device tree nodes Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 07/11] riscv: dts: jh7110: Combine the board device tree files of 1.2A and 1.3B Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 08/11] riscv: dts: starfive: Add support eeprom device tree node Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 09/11] doc: board: starfive: Reword the make defconfig information Yanhong Wang
2023-05-25 9:36 ` [PATCH v4 10/11] configs: starfive: Enable ethernet configuration for StarFive VisionFive2 Yanhong Wang
2023-06-04 18:53 ` Jan Kiszka
2023-06-06 7:43 ` yanhong wang
2023-05-25 9:36 ` [PATCH v4 11/11] configs: starfive: Enable ID EEPROM configuration Yanhong Wang
2023-06-04 19:23 ` Jan Kiszka
2023-06-07 2:19 ` yanhong wang
2023-06-07 12:30 ` Jan Kiszka
2023-05-26 7:40 ` Torsten Duwe [this message]
2023-06-01 17:44 ` [PATCH v4 00/11] Add ethernet driver for StarFive JH7110 SoC Torsten Duwe
2023-06-02 3:14 ` yanhong wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526094057.7cab96fc@blackhole.lan \
--to=duwe@lst.de \
--cc=joe.hershberger@ni.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=rfried.dev@gmail.com \
--cc=rick@andestech.com \
--cc=samin.guo@starfivetech.com \
--cc=u-boot@lists.denx.de \
--cc=walker.chen@starfivetech.com \
--cc=yanhong.wang@starfivetech.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox