From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B010C77B7A for ; Fri, 26 May 2023 07:41:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 67A0984718; Fri, 26 May 2023 09:41:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 039F88531D; Fri, 26 May 2023 09:41:09 +0200 (CEST) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 51B8C846BD for ; Fri, 26 May 2023 09:41:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=duwe@lst.de Received: by verein.lst.de (Postfix, from userid 107) id 96D7868D0A; Fri, 26 May 2023 09:41:04 +0200 (CEST) Received: from blackhole.lan (p5b33fa9c.dip0.t-ipconnect.de [91.51.250.156]) by verein.lst.de (Postfix) with ESMTPSA id 381E068D07; Fri, 26 May 2023 09:40:57 +0200 (CEST) Date: Fri, 26 May 2023 09:40:57 +0200 From: Torsten Duwe To: Yanhong Wang Cc: , Rick Chen , Leo , Joe Hershberger , "Ramon Fried" , Leyfoon Tan , "samin . guo" , Walker Chen Subject: Re: [PATCH v4 00/11] Add ethernet driver for StarFive JH7110 SoC Message-ID: <20230526094057.7cab96fc@blackhole.lan> In-Reply-To: <20230525093637.31364-1-yanhong.wang@starfivetech.com> References: <20230525093637.31364-1-yanhong.wang@starfivetech.com> Organization: LST e.V. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.34; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, 25 May 2023 17:36:26 +0800 Yanhong Wang wrote: [...] > The main difference between StarFive VisionFive 2 1.2A and 1.3B is > gmac, but the difference in gmac is not defined in DT, but reads the > PCB version from EEPROM, and then dynamically configures the > difference of gmac according to different PCB versions, which is > compatible with 1.2A and 1.3B versions, which is more user-friendly. Big ACK from me so far, it is overdue to clean the duplication mess that is currently in master. > The PHY and MAC driver has been tested on the StarFive VisionFive 2 > 1.2A and 1.3B boards and works normally. But for a complete test I'd like to see the respectively correct DTB passed to the OS, and that requires the other issue (base / clock support and single DT) to be resolved first. Thanks! Torsten