From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 37F1BC7EE23 for ; Fri, 26 May 2023 11:05:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E71CE84780; Fri, 26 May 2023 13:05:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 57D4A84794; Fri, 26 May 2023 13:05:30 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 056F484706 for ; Fri, 26 May 2023 13:05:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 635CFD75; Fri, 26 May 2023 04:06:12 -0700 (PDT) Received: from slackpad.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E325D3F762; Fri, 26 May 2023 04:05:25 -0700 (PDT) Date: Fri, 26 May 2023 12:05:03 +0100 From: Andre Przywara To: Maksim Kiselev Cc: Sam Edwards , Samuel Holland , Jagan Teki , u-boot@lists.denx.de, Icenowy Zheng , Jernej Skrabec Subject: Re: [RFC PATCH 08/17] sunxi: introduce NCAT2 generation model Message-ID: <20230526120503.2871d7e3@slackpad.lan> In-Reply-To: References: <20221206004549.29015-1-andre.przywara@arm.com> <20221206004549.29015-9-andre.przywara@arm.com> <20230516220850.7ab973b1@slackpad.lan> <2d8c3fce-dfbf-37ec-f7f1-21684c5d1da6@gmail.com> <20230517014312.01986aa6@slackpad.lan> <20230517095646.3f8a7f03@donnerap.cambridge.arm.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.1.1 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Thu, 25 May 2023 21:25:57 +0300 Maksim Kiselev wrote: Hi Maksim, > Could you please include this fix for i2c in the next version of this=20 > series. >=20 > diff --git a/drivers/i2c/mvtwsi.c b/drivers/i2c/mvtwsi.c > index 93bbc6916e..d088ea75b9 100644 > --- a/drivers/i2c/mvtwsi.c > +++ b/drivers/i2c/mvtwsi.c > @@ -124,7 +124,7 @@ enum mvtwsi_ctrl_register_fields { > =C2=A0 * on other platforms, it is a normal r/w bit, which is cleared by= =20 > writing 0. > =C2=A0 */ >=20 > -#if defined(CONFIG_SUNXI_GEN_SUN6I) || defined(CONFIG_SUN50I_GEN_H6) > +#if defined(CONFIG_SUNXI_GEN_SUN6I) || defined(CONFIG_SUN50I_GEN_H6) ||= =20 > defined(CONFIG_SUNXI_GEN_NCAT2) Ah, thanks for pointing this out, I never really tried I2C, I think. So those code lines are of course hideous to begin with, but it's a nightmare to fix this properly (by looking at the DT compatible string), and we might need it for the SPL anyway, so would need something like this anyway. So I will just go ahead and add this to this patch. Thanks for the report! Cheers, Andre > =C2=A0#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MVTWSI_CONTROL_C= LEAR_IFLG=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0x00000008 > =C2=A0#else > =C2=A0#define=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MVTWSI_CONTROL_C= LEAR_IFLG=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0x00000000 >=20