Re: [RFC PATCH 00/17] sunxi: rework pinctrl and add T113s support

Maxim Kiselev
2023-06-17T08:26:55Z

Hi Andre,

пт, 16 июн. 2023 г. в 19:36, Andre Przywara <andre.przywara@arm.com>:
[..]
>
> thanks for the reply! If you have anything that is missing or broken in
> the new version of the patchset I put on github, please let me know.

I tried the new version and everything looks pretty good for me. Great job!
Just one note. Could you please add SUNXI_R_CPUCFG_BASE 0x07000400
to cpu_sunxi_ncat2.h file. This register is required for Sam's PCSI patches.
Otherwise it leads to undeclared error:
In file included from ./arch/arm/include/asm/armv7.h:60,
from arch/arm/cpu/armv7/sunxi/psci.c:16:
arch/arm/cpu/armv7/sunxi/psci.c: In function ‘sunxi_cpu_set_entry’:
arch/arm/cpu/armv7/sunxi/psci.c:138:24: error:
‘SUNXI_R_CPUCFG_BASE’ undeclared (first use in this function); did you
mean ‘SUNXI_CPUCFG_BASE’?
138 | SUNXI_R_CPUCFG_BASE + SUN8I_R528_SOFT_ENTRY);
| ^~~~~~~~~~~~~~~~~~~