From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC77DC77B7E for ; Mon, 29 May 2023 20:04:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B63E284592; Mon, 29 May 2023 22:04:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="aWywnLQn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7ABA184659; Mon, 29 May 2023 22:04:47 +0200 (CEST) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 573D083741 for ; Mon, 29 May 2023 22:04:44 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb2a.google.com with SMTP id 3f1490d57ef6-ba8a0500f4aso2931199276.3 for ; Mon, 29 May 2023 13:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1685390683; x=1687982683; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=BJiNl5jpQiJQYIAQKgDBx7JOUpDMMAiY/mfcP7tB6n8=; b=aWywnLQnAOa4fvt+Ka4hE79vFPlDAFMMkDbVa1eBIj0sMMvUkb63ryQn9Kp7AZG7Mr fupI6tvBWcvS3xxcAQBjao+lZoNRhykTaWIabcsTqcq2+dksxZeIvtP7RnJACUM+8h8+ Ps+dG4hcdDikbT2knIZzToxXCI8zNIUlyIusA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685390683; x=1687982683; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BJiNl5jpQiJQYIAQKgDBx7JOUpDMMAiY/mfcP7tB6n8=; b=j1639+5mLZ6alnDBFBgQEagNAKLPJykAGx4F3+A24GZ3pHo9z8vGgosv8BzWpdDxij iui7QGYQ26/yDm6kD7bSGoiuXd11pmks9RSvb7IrBIYDKr4CbkPYOy4NMchVhVroBbid U5rK6QMUpvuYtEUwOfgjMk6xC33l6mNrRBOnIlsTXNfST7/piUcgp71Xkae8ID9Q1sm8 fXIQoWYojgJZBJ3Ke4hN+KcYEgV/VcENnsEYuMbJntvlYiu448BHq1Xa4krTEZ77tLU1 5Kekj4bajo4r43DJ75bOHJ+6c32tY3WVf4iNjsDp+AsGjRnWzk73q7kFqiOR53kzAg5G Bh6g== X-Gm-Message-State: AC+VfDyewovDKlC4+hmLQHCM+7W/lhf+PvEnevBHanFDK7gXmmoASGob F2PJpHvOnzWNrqSknrv3RAyTibu7LDkJ6kfIYzo/yw== X-Google-Smtp-Source: ACHHUZ4sl0mPog6gpAd9f7gFUBKm6M8INAaCLX2dlCW0UYIiMQqloNtHFpfOdaRNMMy4B8MrBSEy1A== X-Received: by 2002:a25:74c3:0:b0:bab:93b6:9d9b with SMTP id p186-20020a2574c3000000b00bab93b69d9bmr329381ybc.21.1685390682766; Mon, 29 May 2023 13:04:42 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-372c-5231-f3a5-e282.res6.spectrum.com. [2603:6081:7b00:6400:372c:5231:f3a5:e282]) by smtp.gmail.com with ESMTPSA id m205-20020a2571d6000000b00ba87bc06fe5sm3077399ybc.52.2023.05.29.13.04.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 May 2023 13:04:42 -0700 (PDT) Date: Mon, 29 May 2023 16:04:40 -0400 From: Tom Rini To: u-boot@lists.denx.de Cc: Ralph Siemsen Subject: [tom.rini@gmail.com: Fwd: New Defects reported by Coverity Scan for Das U-Boot] Message-ID: <20230529200440.GF3755309@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2R0FF41O8QGkXfPG" Content-Disposition: inline X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --2R0FF41O8QGkXfPG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Here's the latest report. ---------- Forwarded message --------- =46rom: Date: Mon, May 29, 2023, 11:10 AM Subject: New Defects reported by Coverity Scan for Das U-Boot To: Hi, Please find the latest report on new defect(s) introduced to Das U-Boot found with Coverity Scan. 2 new defect(s) introduced to Das U-Boot found with Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 461871: Null pointer dereferences (NULL_RETURNS) /tools/renesas_spkgimage.c: 56 in spkgimage_parse_config_line() ___________________________________________________________________________= _____________________________ *** CID 461871: Null pointer dereferences (NULL_RETURNS) /tools/renesas_spkgimage.c: 56 in spkgimage_parse_config_line() 50 char *saveptr; 51 char *delim =3D "\t "; 52 char *name =3D strtok_r(line, delim, &saveptr); 53 char *val_str =3D strtok_r(NULL, delim, &saveptr); 54 int value =3D atoi(val_str); 55 >>> CID 461871: Null pointer dereferences (NULL_RETURNS) >>> Dereferencing a pointer that might be "NULL" "name" when calling "strcmp". [Note: The source code implementation of the function has been overridden by a builtin model.] 56 if (!strcmp("VERSION", name)) { 57 conf.version =3D check_range(name, value, 1, 15); 58 } else if (!strcmp("NAND_ECC_ENABLE", name)) { 59 conf.ecc_enable =3D check_range(name, value, 0, 1); 60 } else if (!strcmp("NAND_ECC_BLOCK_SIZE", name)) { 61 conf.ecc_block_size =3D check_range(name, value, 0, 2); ** CID 461870: Resource leaks (RESOURCE_LEAK) /tools/renesas_spkgimage.c: 106 in spkgimage_parse_config_file() ___________________________________________________________________________= _____________________________ *** CID 461870: Resource leaks (RESOURCE_LEAK) /tools/renesas_spkgimage.c: 106 in spkgimage_parse_config_file() 100 101 /* Strip any trailing newline */ 102 line[strcspn(line, "\n")] =3D 0; 103 104 /* Parse the line */ 105 if (spkgimage_parse_config_line(line, line_num)) >>> CID 461870: Resource leaks (RESOURCE_LEAK) >>> Variable "fcfg" going out of scope leaks the storage it points to. 106 return -EINVAL; 107 } 108 109 fclose(fcfg); 110 111 /* Avoid divide-by-zero later on */ --=20 Tom --2R0FF41O8QGkXfPG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmR1BVEACgkQFHw5/5Y0 tywt7Av/eTysnTnJOfPd2osQr/vPVvlV02JKInJ5NiB3I8+sfacPKLIporSJmKVj EJoA0ep7wQuQ7XxxrNfj2TN0hrPtMcebgkhagdZ/56lSm1O0E445+SPr3BQdVs/K KdKKj/yY+gYu96aKjzhqw8kHdFt9FjhyIQ1zgyufI6RFvuchL5hhSTWlI5/wtkAk JySkcYHQEF3Hy+RH6oaTjnBIBqAJbr9SvpZjgmfvV8/5K+zXV5PMA9x6uWz/GOZa Aa99wljQEw5Fl8oWvz96wBHz+NS4Vw0lm4Y2lZhti2bq7weBZ+sZs3DWqDE8guqC RK4X4TI9pluKwuFRpKAd3yaWlzB9DZdVl7JE43g0ObKCNhJSsSBOg5hw2ueRd8Ps jXrQk2odlK4WKn3Z/mVyipwY5N2kLvcOYm3XsIpNNQLgMmMkzYXiClxDtLCqb4Al LpPa2PQRHAWJi8zTR8GU2K/05pQl2MZiYVG87Ed/bakpjWGhpwq0km22q0fbiXv9 emxLVT9/ =Hjdh -----END PGP SIGNATURE----- --2R0FF41O8QGkXfPG--