From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFD3AC77B7A for ; Thu, 1 Jun 2023 11:03:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1F92A862D0; Thu, 1 Jun 2023 13:03:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1685617383; bh=GXc7qff1G9b0QBfWHwDytrkFxzIkA5QZwmc11wIAWsU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=f8Fy4+2IgnfyeWgZTw2H6w2AisfjepfnFv57yjmbFdFXJTp84GjrZrQzyQ4AWGxyt Y5l5z4I+ir2Gio/m3Oc2T4E2GFZ2GhKoQVBjLIGXAe+2vrX3IrTnhNLIm3aiTlnCjt xeZCa7+0vFzssVqQTu+X+bAmgAneyHxBu0pOFsveC33djmz/dqdr9YmiLkQ86g53c7 OhNGb4YESw3XKwevXWnmtKJDsWrK2knmXBhDKc0oGT4zL1KdJrLjpwRq8lD6A1pKRE /ZbtjguAR6I+yHZc0lEgL6rqYfZMeGuNWrmhuu5oSDEzDAkimDDwNHxfvO+jl1YDk3 c80aLLrzYAggg== Received: from wsk (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C55B6846F1; Thu, 1 Jun 2023 13:02:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1685617380; bh=GXc7qff1G9b0QBfWHwDytrkFxzIkA5QZwmc11wIAWsU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=is6c5RkjuObhvFFLl13o6NwYRscpgpuxnlpwiqrt9hAqF0Cnp98Ax4AveHaIvjWjb KOmvRvQagnFncgyVlGCgmc8lsW/33CerXAQjs9+CkL16w9GY4x9q3r5Ag7rTv7//KW J21qY2jFlnDdMjip+AuxlvWc7I1oFIhgkXY8jgNauYh17RlThj3m8hraXmw1e9T9G2 oN/VdLKot/M9VfvOx7ZArz627fOaNbmw24vZgKFuLTYST9NJF3UA29cbSSBVcx6MH4 iYafm8TnLsMJ8mewcAqL3DHc4WE8v0oEbMNUEqkyfE3EaghYl7LjzNWkRZwHLkrbxo vXIzSpcH6oELQ== Date: Thu, 1 Jun 2023 13:02:51 +0200 From: Lukasz Majewski To: Marek Vasut Cc: u-boot@lists.denx.de, Tom Rini , Anatolij Gustschin , Ramon Fried , Joe Hershberger , Marek Vasut , Michal Simek Subject: Re: [PATCH v1 2/6] net: mv88e61xx: Configure PHY ports to also pass packets between them Message-ID: <20230601130251.12f18dca@wsk> In-Reply-To: <0ab25898-2fe6-7d86-7d63-ff3d43e82b63@mailbox.org> References: <20230601100005.2216345-1-lukma@denx.de> <20230601100005.2216345-3-lukma@denx.de> <0ab25898-2fe6-7d86-7d63-ff3d43e82b63@mailbox.org> Organization: denx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/gJjO5H30pRZ6hKnn7Oo_sbC"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --Sig_/gJjO5H30pRZ6hKnn7Oo_sbC Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Marek, > On 6/1/23 12:00, Lukasz Majewski wrote: > > After this change PHY ports are able to pass packets between them > > (and also to CPU port). > >=20 > > The Kconfig variable - CONFIG_MV88E61XX_PHY_PORTS - is used to get > > the PHY ports of the switch and generate proper mask. > >=20 > > Signed-off-by: Lukasz Majewski > > Reviewed-by: Ramon Fried =20 >=20 > Was there a V0 before ? Or where did these RB tags come from ? >=20 There was v1 in 2021 - The patman is not allowing "v1 RESEND" tag adding. > > --- > >=20 > > drivers/net/phy/mv88e61xx.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > >=20 > > diff --git a/drivers/net/phy/mv88e61xx.c > > b/drivers/net/phy/mv88e61xx.c index 31f9b57456d6..4aee83551beb > > 100644 --- a/drivers/net/phy/mv88e61xx.c > > +++ b/drivers/net/phy/mv88e61xx.c > > @@ -865,14 +865,19 @@ static int mv88e61xx_phy_setup(struct > > phy_device *phydev, u8 phy)=20 > > static int mv88e61xx_phy_config_port(struct phy_device *phydev, > > u8 phy) { > > + struct mv88e61xx_phy_priv *priv =3D phydev->priv; > > + u16 port_mask; > > int val; > > =20 > > val =3D mv88e61xx_port_enable(phydev, phy); > > if (val < 0) > > return val; > > =20 > > - val =3D mv88e61xx_port_set_vlan(phydev, phy, > > - 1 << CONFIG_MV88E61XX_CPU_PORT); > > + port_mask =3D PORT_MASK(priv->port_count) & > > CONFIG_MV88E61XX_PHY_PORTS; > > + port_mask &=3D ~(1 << phy); > > + port_mask |=3D (1 << CONFIG_MV88E61XX_CPU_PORT); =20 >=20 > BIT() ? I've kept the "style" from the rest of the file. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/gJjO5H30pRZ6hKnn7Oo_sbC Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmR4etsACgkQAR8vZIA0 zr1t/QgAvDFPioDMO2+9MUmgUp2MBHEtMwkgxzM7hGjAXKWPXyNCuBAbEJGzAbT6 EbJFg+eSeG/JDww96nhf3cKmwcFI2ax5fjTg7zupMakF/M+acTAD/QDBiJdVOXtQ VnoI5g509U2NJg50HxarL+gwymOvDzbqplHkeQM77vCDx8tE91DQ1lNPT8HGxT4I 8yD5nNWlZAiuq1Qn3ZzqYSRocfjxYLCHdi7uORNrYIQzmcXgjV15v2HdWwt9y27l VRZdThrWDGkxNToGlwqdYisG/p6jGBr8MTjrGQswE97lgsoeoGwm+E7uxvnNum/P WUwjG0vd3+XGAZPmiUVUtKtxKd44Aw== =Rxbo -----END PGP SIGNATURE----- --Sig_/gJjO5H30pRZ6hKnn7Oo_sbC--