public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sam Edwards <cfsworks@gmail.com>
To: u-boot@lists.denx.de
Cc: Andre Przywara <andre.przywara@arm.com>,
	Jagan Teki <jagan@amarulasolutions.com>,
	Marek Vasut <marex@denx.de>, Sam Edwards <CFSworks@gmail.com>
Subject: [PATCH 0/2] sunxi, usb: Clean up SRAM initialization code
Date: Wed,  7 Jun 2023 17:16:42 -0600	[thread overview]
Message-ID: <20230607231644.28203-1-CFSworks@gmail.com> (raw)

Hi list,

This pair of patches is a byproduct of discussion on my earlier patchset
(Patchwork series #357953), which had simply disabled this initialization where
SUNXI_SRAMC_BASE was set to null. It is true that this initialization is not
needed on newer devices, but not because the SRAMC (now called "SYSCON") has
been removed, so a null SRAMC base was not the appropriate fix.

Of the two patches here, only the first is an actual fix; the second is a
mostly-cosmetic cleanup, which also adds a TODO to make this function
independent of SUNXI_SRAMC_BASE altogether, per the aforementioned prior
discussion.

I do not have an A10, A10s, A13, GR8, or A20 against which to test this change;
a reviewer with access to one of these should verify that USB-OTG functionality
is still working. That ought to be a sufficient regression test. :)

A note to committers: If patch 1 is acceptable but patch 2 is not, go ahead and
commit only patch 1 (unless the U-Boot project specifically avoids doing this).

Thanks for your time,
Sam

Sam Edwards (2):
  usb: musb-new: sunxi: only perform SRAM initialization when necessary
  usb: musb-new: sunxi: clarify the purpose of SRAM initialization

 drivers/usb/musb-new/sunxi.c | 33 +++++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)

-- 
2.39.2


             reply	other threads:[~2023-06-07 23:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-07 23:16 Sam Edwards [this message]
2023-06-07 23:16 ` [PATCH 1/2] usb: musb-new: sunxi: only perform SRAM initialization when necessary Sam Edwards
2023-06-08 12:03   ` Andre Przywara
2023-06-09 10:00   ` Andre Przywara
2023-06-07 23:16 ` [PATCH 2/2] usb: musb-new: sunxi: clarify the purpose of SRAM initialization Sam Edwards
2023-06-09 10:13   ` Andre Przywara
2023-06-09 19:16     ` Sam Edwards
2023-06-09 19:40       ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230607231644.28203-1-CFSworks@gmail.com \
    --to=cfsworks@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=jagan@amarulasolutions.com \
    --cc=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox