From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04D24C77B7A for ; Wed, 7 Jun 2023 23:17:07 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6EE1784988; Thu, 8 Jun 2023 01:16:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="B7o5nOj5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 497AD8478A; Thu, 8 Jun 2023 01:16:55 +0200 (CEST) Received: from mail-il1-x130.google.com (mail-il1-x130.google.com [IPv6:2607:f8b0:4864:20::130]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 16C1684988 for ; Thu, 8 Jun 2023 01:16:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=cfsworks@gmail.com Received: by mail-il1-x130.google.com with SMTP id e9e14a558f8ab-33b4b70693eso10154815ab.1 for ; Wed, 07 Jun 2023 16:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686179809; x=1688771809; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GEfnzVMZKk0nQz1y/hSE0emHwMpHwuo8O6C++7FBYek=; b=B7o5nOj5Z4OSl5QElsClmIDlQEU41es8IJneHzRDM7JSmEWyoGmMlHAnKzU4FXGIxM ezovpkbIfbUrDMvqVgY6z7Dk3KW3MKdbSYCgurW1dhXi0zc/RtfEJ3V+sfUwhww1+FFc Ah3Iiuekz9NLLaBh2IP2NJ4b39NB4bSBSPWfVa0eLWDnyQcljTEm5YDoNaDIrwHuB8F7 ym8Z6kSsI6vnO65w26x+XTtc9AIWkETEvveeBIznYHscozxK5v/Di8ZSR7xEJjpylVaj OxNiJ98LpoP3Cq0sFdqUwbpUdNdf8OVto6kmRitG/4CJ4lGBUKhDv+213y3cr9k4VS4R ByTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686179809; x=1688771809; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GEfnzVMZKk0nQz1y/hSE0emHwMpHwuo8O6C++7FBYek=; b=KXFmeJhGYZzNHcMiyVB/ybKgKXC8V75d2KtrVZwJNoizKU+sJLnTyVpqZAk/KrYu/W b3VB3FHl4dGsyOj0g09SbmH2b3b4YxkXIjRCDdGgnIkxE3OKOZUt5xkcnwneXLY7JDl5 ibIjuhIep4Yy5WU1eUkdPpYZuY+GZgI1Oy6uZAFpQ6b6+OgsRf6nnoOtA2VuBbK3FVmm qcMyeXz9FJhWJcZ6hosSNhrKggVY2yHs75KdJdRNIOZgQmApH1EHr71V2RfSsr07+LsV 0O9fP8XJcycKNHMc3S1DMSRwMiYt78h6PVrXWyXrLqoQpFcHUGljkzRDbhB8OYyXOEma JebA== X-Gm-Message-State: AC+VfDxZjLkHybNSL8cvuz0SxSigHWBA7JWvTZiLxwkwa1jvIlKCqCp9 wvUXBoFdu7yocEVAGuPPszOttv+tBC61c18O X-Google-Smtp-Source: ACHHUZ6BduRN5l7Qcv6N1oXuznPXemXG3XRQ1220Z4PfbXERHTUrGV6UetGnd0jRk7vlVyVT85zENQ== X-Received: by 2002:a92:d646:0:b0:338:18f1:db72 with SMTP id x6-20020a92d646000000b0033818f1db72mr10294289ilp.29.1686179809509; Wed, 07 Jun 2023 16:16:49 -0700 (PDT) Received: from celestia.nettie.lan ([2001:470:42c4:101:928e:2611:457e:59ff]) by smtp.gmail.com with ESMTPSA id g6-20020a0566380c4600b0040f7db6a264sm3560614jal.114.2023.06.07.16.16.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 16:16:48 -0700 (PDT) From: Sam Edwards X-Google-Original-From: Sam Edwards To: u-boot@lists.denx.de Cc: Andre Przywara , Jagan Teki , Marek Vasut , Sam Edwards Subject: [PATCH 0/2] sunxi, usb: Clean up SRAM initialization code Date: Wed, 7 Jun 2023 17:16:42 -0600 Message-Id: <20230607231644.28203-1-CFSworks@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi list, This pair of patches is a byproduct of discussion on my earlier patchset (Patchwork series #357953), which had simply disabled this initialization where SUNXI_SRAMC_BASE was set to null. It is true that this initialization is not needed on newer devices, but not because the SRAMC (now called "SYSCON") has been removed, so a null SRAMC base was not the appropriate fix. Of the two patches here, only the first is an actual fix; the second is a mostly-cosmetic cleanup, which also adds a TODO to make this function independent of SUNXI_SRAMC_BASE altogether, per the aforementioned prior discussion. I do not have an A10, A10s, A13, GR8, or A20 against which to test this change; a reviewer with access to one of these should verify that USB-OTG functionality is still working. That ought to be a sufficient regression test. :) A note to committers: If patch 1 is acceptable but patch 2 is not, go ahead and commit only patch 1 (unless the U-Boot project specifically avoids doing this). Thanks for your time, Sam Sam Edwards (2): usb: musb-new: sunxi: only perform SRAM initialization when necessary usb: musb-new: sunxi: clarify the purpose of SRAM initialization drivers/usb/musb-new/sunxi.c | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) -- 2.39.2