* [PATCH] sunxi: Fix typo in include guard
@ 2023-05-12 21:22 Sam Edwards
2023-05-15 9:48 ` Andre Przywara
2023-06-07 22:22 ` Andre Przywara
0 siblings, 2 replies; 4+ messages in thread
From: Sam Edwards @ 2023-05-12 21:22 UTC (permalink / raw)
To: u-boot; +Cc: Andre Przywara, Jagan Teki, Sam Edwards
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
---
arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/include/asm/arch-sunxi/pmic_bus.h b/arch/arm/include/asm/arch-sunxi/pmic_bus.h
index 3ccfe138f3..5ab9b2809f 100644
--- a/arch/arm/include/asm/arch-sunxi/pmic_bus.h
+++ b/arch/arm/include/asm/arch-sunxi/pmic_bus.h
@@ -6,7 +6,7 @@
*/
#ifndef _SUNXI_PMIC_BUS_H
-#define _SUNXI_PMIS_BUS_H
+#define _SUNXI_PMIC_BUS_H
int pmic_bus_init(void);
int pmic_bus_read(u8 reg, u8 *data);
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sunxi: Fix typo in include guard
2023-05-12 21:22 [PATCH] sunxi: Fix typo in include guard Sam Edwards
@ 2023-05-15 9:48 ` Andre Przywara
2023-05-16 1:34 ` Sam Edwards
2023-06-07 22:22 ` Andre Przywara
1 sibling, 1 reply; 4+ messages in thread
From: Andre Przywara @ 2023-05-15 9:48 UTC (permalink / raw)
To: Sam Edwards; +Cc: u-boot, Jagan Teki
On Fri, 12 May 2023 15:22:14 -0600
Sam Edwards <cfsworks@gmail.com> wrote:
Hi Sam,
Good catch! It's not the first time we see misspelled preprocessor
symbols, although that typically happens with Kconfig names.
How did you find this? Just by accident? I was wondering if we could
check the tree automatically for those accidents.
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
> arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-sunxi/pmic_bus.h b/arch/arm/include/asm/arch-sunxi/pmic_bus.h
> index 3ccfe138f3..5ab9b2809f 100644
> --- a/arch/arm/include/asm/arch-sunxi/pmic_bus.h
> +++ b/arch/arm/include/asm/arch-sunxi/pmic_bus.h
> @@ -6,7 +6,7 @@
> */
>
> #ifndef _SUNXI_PMIC_BUS_H
> -#define _SUNXI_PMIS_BUS_H
> +#define _SUNXI_PMIC_BUS_H
>
> int pmic_bus_init(void);
> int pmic_bus_read(u8 reg, u8 *data);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sunxi: Fix typo in include guard
2023-05-15 9:48 ` Andre Przywara
@ 2023-05-16 1:34 ` Sam Edwards
0 siblings, 0 replies; 4+ messages in thread
From: Sam Edwards @ 2023-05-16 1:34 UTC (permalink / raw)
To: Andre Przywara; +Cc: u-boot, Jagan Teki
On 5/15/23 03:48, Andre Przywara wrote:
Ahoy, Andre!
> How did you find this? Just by accident? I was wondering if we could
> check the tree automatically for those accidents.
I found it both automatically and by accident. :)
My cross-compiler of choice is Clang (as I don't have to
rebuild/reinstall it for each target) and its enabled-by-default
-Wheader-guard diagnostic flagged that for me.
Regards,
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sunxi: Fix typo in include guard
2023-05-12 21:22 [PATCH] sunxi: Fix typo in include guard Sam Edwards
2023-05-15 9:48 ` Andre Przywara
@ 2023-06-07 22:22 ` Andre Przywara
1 sibling, 0 replies; 4+ messages in thread
From: Andre Przywara @ 2023-06-07 22:22 UTC (permalink / raw)
To: Sam Edwards; +Cc: u-boot, Jagan Teki
On Fri, 12 May 2023 15:22:14 -0600
Sam Edwards <cfsworks@gmail.com> wrote:
> Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Applied to sunxi/master.
Thanks,
Andre
> ---
> arch/arm/include/asm/arch-sunxi/pmic_bus.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-sunxi/pmic_bus.h b/arch/arm/include/asm/arch-sunxi/pmic_bus.h
> index 3ccfe138f3..5ab9b2809f 100644
> --- a/arch/arm/include/asm/arch-sunxi/pmic_bus.h
> +++ b/arch/arm/include/asm/arch-sunxi/pmic_bus.h
> @@ -6,7 +6,7 @@
> */
>
> #ifndef _SUNXI_PMIC_BUS_H
> -#define _SUNXI_PMIS_BUS_H
> +#define _SUNXI_PMIC_BUS_H
>
> int pmic_bus_init(void);
> int pmic_bus_read(u8 reg, u8 *data);
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-07 22:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-12 21:22 [PATCH] sunxi: Fix typo in include guard Sam Edwards
2023-05-15 9:48 ` Andre Przywara
2023-05-16 1:34 ` Sam Edwards
2023-06-07 22:22 ` Andre Przywara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox