Re: [PATCH 2/3] drivers: musb-new: add allwinner f1c100s

[Andre Przywara <andre.przywara@arm.com>]

On Fri, 9 Jun 2023 14:11:53 +0000
路辉 <luhux76@gmail.com> wrote:

Hi,

> From fe7d48e84bb3c72d219f37eed51ea766f83b4bec Mon Sep 17 00:00:00 2001
> From: Lu Hui <luhux76@gmail.com>
> Date: Fri, 9 Jun 2023 22:05:23 +0800
> Subject: [PATCH 2/3] drivers: musb-new: add allwinner f1c100s configuration

thanks for sending this. If this patch should be considered for
merging, you need a few lines of commit message, and more importantly
your Signed-off-by: line.

> ---
>  drivers/usb/musb-new/sunxi.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/musb-new/sunxi.c b/drivers/usb/musb-new/sunxi.c
> index dc4cfc2194..1c90739cea 100644
> --- a/drivers/usb/musb-new/sunxi.c
> +++ b/drivers/usb/musb-new/sunxi.c
> @@ -4,6 +4,7 @@
>   *
>   * Copyright © 2015 Hans de Goede <hdegoede@redhat.com>
>   * Copyright © 2013 Jussi Kivilinna <jussi.kivilinna@iki.fi>
> + * Copyright © 2023 Lu Hui <luhux76@gmail.com>

This is not needed, only significant contributions require
adding a copyright line. The license is much more important.

>   *
>   * Based on the sw_usb "Allwinner OTG Dual Role Controller" code.
>   *  Copyright 2007-2012 (C) Allwinner Technology Co., Ltd.
> @@ -519,6 +520,10 @@ static const struct sunxi_musb_config sun8i_h3_cfg = {
>      .config = &musb_config_h3,
>  };
> 
> +static const struct sunxi_musb_config suniv_f1c100s_cfg = {
> +    .config = &musb_config,
> +};

Since is not needed, as it's identical to the A10 structure ...

> +
>  static const struct udevice_id sunxi_musb_ids[] = {
>      { .compatible = "allwinner,sun4i-a10-musb",
>              .data = (ulong)&sun4i_a10_cfg },
> @@ -528,6 +533,8 @@ static const struct udevice_id sunxi_musb_ids[] = {
>              .data = (ulong)&sun6i_a31_cfg },
>      { .compatible = "allwinner,sun8i-h3-musb",
>              .data = (ulong)&sun8i_h3_cfg },
> +    { .compatible = "allwinner,suniv-f1c100s-musb",
> +            .data = (ulong)&suniv_f1c100s_cfg },

... which you can just reference here directly.

Otherwise this matches the patch I have prepared here as well, I just
wanted to test host mode before sending.

If you resend this one patch with your Signed-off-by: (instead of
Copyright), and using sun4i_a10_cfg, I am happy to take it.

Thanks,
Andre